[No QA] Update Configure-Quickbooks-Online.md - #92603
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://38df1cfa.helpdot.pages.dev ⚡️ Updated articles: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2272afd065
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - If marked as paid in QuickBooks Online, the report will show as reimbursed in Expensify | ||
| - If reimbursed via ACH in Expensify, the status will sync to paid in QuickBooks | ||
| - **Invoice collection account**: Select where paid invoices are stored | ||
| - **QuickBooks bill payment account**: Select where paid expense reports are stored |
There was a problem hiding this comment.
Describe the bill payment account as the payment source
In the QBO advanced UI I inspected, this setting updates reimbursementAccountID and the selector copy says to choose where bills are paid from (src/pages/workspace/accounting/qbo/advanced/QuickbooksAccountSelectPage.tsx, accountSelectDescription), while invoice collections use collectionAccountID separately. Describing the bill payment account as where paid expense reports are “stored” can lead admins configuring Sync reimbursed reports to pick the wrong QuickBooks account; this should say it is the account used to create/pay bill payments.
Useful? React with 👍 / 👎.
HelpDot Documentation ReviewOverall AssessmentThis PR updates the QuickBooks Online advanced settings documentation to replace a single "Invoice collection account" entry with two more specific entries: "QuickBooks bill payment account" and "QuickBooks invoice collections account." The change improves accuracy by distinguishing between where paid expense reports and paid invoices are stored, and the new labels appear to reflect updated or more precise UI terminology. Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md governance standards. Evaluation covers only the proposed changes in this PR. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.0-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀
|
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari