Skip to content

[No QA] Update Configure-Quickbooks-Online.md - #92603

Merged
stephanieelliott merged 1 commit into
mainfrom
brianlee-expensify-patch-4
Jun 5, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
brianlee-expensify-patch-4

Conversation

@brianlee-expensify

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@OSBotify

OSBotify commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://38df1cfa.helpdot.pages.dev ⚡️

Updated articles:

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2272afd065

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

- If marked as paid in QuickBooks Online, the report will show as reimbursed in Expensify
- If reimbursed via ACH in Expensify, the status will sync to paid in QuickBooks
- **Invoice collection account**: Select where paid invoices are stored
- **QuickBooks bill payment account**: Select where paid expense reports are stored

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Describe the bill payment account as the payment source

In the QBO advanced UI I inspected, this setting updates reimbursementAccountID and the selector copy says to choose where bills are paid from (src/pages/workspace/accounting/qbo/advanced/QuickbooksAccountSelectPage.tsx, accountSelectDescription), while invoice collections use collectionAccountID separately. Describing the bill payment account as where paid expense reports are “stored” can lead admins configuring Sync reimbursed reports to pick the wrong QuickBooks account; this should say it is the account used to create/pay bill payments.

Useful? React with 👍 / 👎.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates the QuickBooks Online advanced settings documentation to replace a single "Invoice collection account" entry with two more specific entries: "QuickBooks bill payment account" and "QuickBooks invoice collections account." The change improves accuracy by distinguishing between where paid expense reports and paid invoices are stored, and the new labels appear to reflect updated or more precise UI terminology.

Scores Summary

  • Readability: 9/10 - The two new bullet points are clear, concise, and follow the same pattern as surrounding content. Each setting has a brief, actionable description. The split from one line into two makes the distinction between expense reports and invoices immediately obvious.
  • AI Readiness: 8/10 - The new labels include the product name "QuickBooks" which improves semantic retrieval and disambiguation. The descriptions are specific enough for AI systems to match user queries about bill payments vs. invoice collections. (Minor deduction: pre-existing structural issues in the file affect overall AI readiness, but those are outside the scope of this diff.)
  • Style Compliance: 9/10 - Setting names are properly bolded per governance rules. Sentence case appears correct. The descriptions follow the established pattern used by other settings in the same section. The labels appear to use exact UI terminology with the "QuickBooks" prefix.

Key Findings

  • Positive: The change correctly splits a single ambiguous setting into two distinct settings, each with a clear purpose. This eliminates potential confusion between expense report storage and invoice storage.
  • Positive: Bold formatting on setting names (QuickBooks bill payment account and QuickBooks invoice collections account) is correct per HELPSITE_NAMING_CONVENTIONS.md.
  • Positive: The descriptions are concise and action-oriented, consistent with the style of adjacent settings in the same section.
  • Verification needed: The governance rules require that UI labels match the product exactly. The reviewer should confirm that "QuickBooks bill payment account" and "QuickBooks invoice collections account" are the exact labels shown in the QuickBooks Online advanced settings UI. If the UI uses different capitalization or wording, the labels must be adjusted to match.

Recommendations

  1. Verify UI label accuracy: Confirm that both new setting names exactly match what users see in the product UI under Workspaces > Accounting > QuickBooks Online > Advanced. This is the most important check per the Deterministic Writing Rule in HELPSITE_NAMING_CONVENTIONS.md.
  2. No structural changes needed: The diff maintains the existing formatting pattern and does not introduce any new structural issues.

Files Reviewed

  • docs/articles/new-expensify/connections/quickbooks-online/Configure-Quickbooks-Online.md - Two lines modified in the Advanced Settings section. Change is well-scoped and maintains consistency with the rest of the article.

Review based on docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md governance standards. Evaluation covers only the proposed changes in this PR.

@stephanieelliott
stephanieelliott merged commit e921dfb into main Jun 5, 2026
17 checks passed
@stephanieelliott
stephanieelliott deleted the brianlee-expensify-patch-4 branch June 5, 2026 02:27
@OSBotify

OSBotify commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.0-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants