Skip to content

[No QA] Docs updates for E/A#91717 QBO vendor bill available with report field locations - #92457

Merged
CortneyOfstad merged 3 commits into
mainfrom
docs-qbo-vendor-bill-report-field-locations
Jun 8, 2026
Merged

CortneyOfstad merged 3 commits into
mainfrom
docs-qbo-vendor-bill-report-field-locations

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Expensify/App#91717 changed the QuickBooks Online company card export picker so the Vendor bill option is only hidden when locations are imported as tags (syncLocations === TAG). When locations are imported as report fields (Control plan), Vendor bill remains available, and the in-product footer copy now describes the tag-specific restriction.

This updates Configure-Quickbooks-Online.md to match that behavior:

  • Import > Locations note: Clarified that locations must be imported as report fields for Vendor bill / Check exports, and that those options are unavailable when locations are imported as tags. Also fixed casing (Vendor bill) to match the UI.
  • Export company card expenses as > Vendor bill: Added a note that Vendor bill is unavailable when locations are imported as tags, mirroring the in-product footer.
  • FAQ "Why can't I export reports as vendor bills or checks?": Removed the inaccurate "Locations can only be used as tags" statement. Exports are blocked specifically when locations are imported as tags; importing locations as report fields (Control plan) keeps Vendor bill and Check available.

Fixed Issues

$ #83788

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

QA

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.


@yichensunjoe, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Vendor bill and check exports are unavailable only when QuickBooks Online
locations are imported as tags. When locations are imported as report fields
(Control plan), these export options remain available.

Co-authored-by: Joe.S <yichensunjoe@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team June 3, 2026 00:23
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 3, 2026

Copy link
Copy Markdown
Contributor

I reviewed the docs update against #91717. The direction matches the product behavior, but one existing line still reads:

Locations: Import as tags.

That still implies tags are the only supported import mode, which conflicts with the new note explaining that Vendor bill / Check remain available when locations are imported as report fields. I think this should be adjusted before marking the PR ready, e.g.:

Locations: Import as tags or report fields.

The rest of the changes look aligned with the current behavior: Vendor bill and Check should be unavailable only when locations are imported as tags, and available when locations are imported as report fields on Control.

@stephanieelliott
stephanieelliott marked this pull request as ready for review June 8, 2026 04:58
@stephanieelliott
stephanieelliott self-requested a review as a code owner June 8, 2026 04:58
@melvin-bot

melvin-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @CortneyOfstad

@melvin-bot
melvin-bot Bot requested review from CortneyOfstad and dmkt9 June 8, 2026 04:58
@melvin-bot

melvin-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

@dmkt9 @CortneyOfstad One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team June 8, 2026 04:58
@stephanieelliott

Copy link
Copy Markdown
Contributor

Good catch, thanks @yichensunjoe! I've committed that change

@github-actions github-actions Bot changed the title Docs updates for E/A#91717 QBO vendor bill available with report field locations [No QA] Docs updates for E/A#91717 QBO vendor bill available with report field locations Jun 8, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott self-assigned this Jun 8, 2026
- **Locations**: Import as tags.
- Note: If you export using the Vendor Bill or Check options, then locations must be configured as report fields, which are only available on the [**Control** plan](https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Billing-Overview#control-plan).
- **Locations**: Import as tags or report fields.
- Note: If you export using the Vendor bill or Check options, then locations must be imported as report fields, which are only available on the [**Control** plan](https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Billing-Overview#control-plan). When locations are imported as tags, the Vendor bill and Check export options are unavailable.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-linking violation: Use a relative link instead of a full URL per HELP_AUTHORING_GUIDELINES.md Section 7 ("Use relative links only. Do not use full URLs.").

Replace:

[**Control** plan](https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Billing-Overview#control-plan)

with:

[**Control** plan](/articles/new-expensify/billing-and-subscriptions/Billing-Overview#control-plan)

(Note: This was inherited from the previous version of this line, but since the line is being modified, it's a good opportunity to fix it.)

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates the QuickBooks Online configuration article to reflect a product change: locations can now be imported as report fields (not only tags), and vendor bill/check exports are unavailable when locations are imported as tags. The changes are accurate, well-scoped, and improve clarity in three places (import settings, export settings, and the FAQ). The diff is small and focused.

Scores Summary

  • Readability: 9/10 - The updated sentences are clear and informative. The added note in the import section is a long single sentence that packs two distinct conditions; splitting it could improve scannability, but it remains understandable as-is. The FAQ bullet list formatting improvement (adding ", or") is a nice touch.
  • AI Readiness: 8/10 - The changes use full feature names ("Vendor bill", "Check", "report fields", "Control plan") consistently, which supports semantic retrieval. No new headings were added or modified, so heading-level AI readiness is unaffected. Minor deduction: the changed line retains a full URL cross-link rather than a relative link, which the governance discourages (though the URL itself was carried over from the prior version).
  • Style Compliance: 9/10 - The capitalization change from "Vendor Bill" to "Vendor bill" brings the text into closer alignment with sentence-case conventions per the naming guidelines. "Check" is consistently capitalized as a UI export type. The term "report fields" is used consistently. One minor note: confirm that "Vendor bill" (lowercase "b") matches the exact UI label -- if the product UI shows "Vendor Bill" with a capital B, the old version was correct and this change would be a regression.

Key Findings

  • The core content change is accurate and well-placed: the constraint between locations-as-tags and vendor bill/check exports is now documented in all three relevant locations (import, export, FAQ), reducing the chance a user misses it.
  • The FAQ answer is meaningfully improved. The old answer incorrectly stated "Locations can only be used as tags" and suggested upgrading to Control without explaining the mechanism. The new answer correctly explains the relationship and provides two actionable solutions.
  • The full URL link to the Billing Overview article (https://help.expensify.com/...) on the modified import-settings line should ideally be a relative link per cross-linking standards. This is a pre-existing issue carried forward, but since the line was touched in this diff, it is worth flagging for a future pass.
  • No structural issues were introduced. The diff does not add or modify any headings, so it does not affect the file's heading hierarchy.

Recommendations

  1. Verify "Vendor bill" capitalization against the live UI. If the UI displays "Vendor Bill" (capital B), revert to the old capitalization. If it displays "Vendor bill" (lowercase b), the change is correct.
  2. Consider converting the full URL on the modified line to a relative link (e.g., /articles/new-expensify/billing-and-subscriptions/Billing-Overview#control-plan) to comply with the cross-linking standard. This is low priority since it is a pre-existing issue.
  3. Optional readability improvement: In the import section note, consider splitting the long sentence into two for easier scanning. For example: "If you export using the Vendor bill or Check options, then locations must be imported as report fields, which are only available on the Control plan. When locations are imported as tags, the Vendor bill and Check export options are unavailable." (This is actually already two sentences -- the length is borderline but acceptable.)

Files Reviewed

  • docs/articles/new-expensify/connections/quickbooks-online/Configure-Quickbooks-Online.md -- Three targeted updates (import section, export section, FAQ) that correctly document the new vendor bill availability behavior with location import settings. Changes are accurate and well-integrated.

@OSBotify

OSBotify commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://49d56429.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott removed the request for review from dmkt9 June 8, 2026 05:18
@CortneyOfstad
CortneyOfstad merged commit 56a60af into main Jun 8, 2026
15 checks passed
@CortneyOfstad
CortneyOfstad deleted the docs-qbo-vendor-bill-report-field-locations branch June 8, 2026 19:29
@OSBotify

OSBotify commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/CortneyOfstad in version: 9.4.1-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.1-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants