[No QA] Docs updates for E/A#91717 QBO vendor bill available with report field locations - #92457
Conversation
Vendor bill and check exports are unavailable only when QuickBooks Online locations are imported as tags. When locations are imported as report fields (Control plan), these export options remain available. Co-authored-by: Joe.S <yichensunjoe@users.noreply.github.com>
|
I reviewed the docs update against #91717. The direction matches the product behavior, but one existing line still reads:
That still implies tags are the only supported import mode, which conflicts with the new note explaining that Vendor bill / Check remain available when locations are imported as report fields. I think this should be adjusted before marking the PR ready, e.g.:
The rest of the changes look aligned with the current behavior: Vendor bill and Check should be unavailable only when locations are imported as tags, and available when locations are imported as report fields on Control. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@dmkt9 @CortneyOfstad One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Good catch, thanks @yichensunjoe! I've committed that change |
This comment has been minimized.
This comment has been minimized.
| - **Locations**: Import as tags. | ||
| - Note: If you export using the Vendor Bill or Check options, then locations must be configured as report fields, which are only available on the [**Control** plan](https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Billing-Overview#control-plan). | ||
| - **Locations**: Import as tags or report fields. | ||
| - Note: If you export using the Vendor bill or Check options, then locations must be imported as report fields, which are only available on the [**Control** plan](https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Billing-Overview#control-plan). When locations are imported as tags, the Vendor bill and Check export options are unavailable. |
There was a problem hiding this comment.
Cross-linking violation: Use a relative link instead of a full URL per HELP_AUTHORING_GUIDELINES.md Section 7 ("Use relative links only. Do not use full URLs.").
Replace:
[**Control** plan](https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Billing-Overview#control-plan)
with:
[**Control** plan](/articles/new-expensify/billing-and-subscriptions/Billing-Overview#control-plan)
(Note: This was inherited from the previous version of this line, but since the line is being modified, it's a good opportunity to fix it.)
HelpDot Documentation ReviewOverall AssessmentThis PR updates the QuickBooks Online configuration article to reflect a product change: locations can now be imported as report fields (not only tags), and vendor bill/check exports are unavailable when locations are imported as tags. The changes are accurate, well-scoped, and improve clarity in three places (import settings, export settings, and the FAQ). The diff is small and focused. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
|
A preview of your ExpensifyHelp changes have been deployed to https://49d56429.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/CortneyOfstad in version: 9.4.1-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.1-6 🚀
|
Explanation of Change
Expensify/App#91717 changed the QuickBooks Online company card export picker so the Vendor bill option is only hidden when locations are imported as tags (
syncLocations === TAG). When locations are imported as report fields (Control plan), Vendor bill remains available, and the in-product footer copy now describes the tag-specific restriction.This updates
Configure-Quickbooks-Online.mdto match that behavior:Fixed Issues
$ #83788
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
QA
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
@yichensunjoe, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.