[No QA] Update Chat-Features-and-Moderation-Tools.md - #92272
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://872ed186.helpdot.pages.dev ⚡️ Updated articles: |
HelpDot Documentation ReviewOverall AssessmentThis PR makes three small wording changes in the "Leave a Chat Room" section of the Chat Features and Moderation Tools article. Two changes improve terminology consistency ("room" to "chat room"), and one replaces a prohibited UI reference ("Click the 3-dot menu in the top right") with a more accurate instruction ("Click the chat room header"). The changes are directionally positive and address a real governance violation, though one introduces a minor new concern. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.0-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀
|
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari