[No QA] Help Site: Add "Explore-what's-changed-in-New-Expensify.md and update migration guides - #92126
Conversation
…om Coming-from-Classic guides Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
Fixed the failing spellcheck check: the word |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…nged-in-New-Expensify.md
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @lschurr |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44eb3d064a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new article ("Explore what's changed in New Expensify") and updates the two existing Coming-from-Classic migration guides to cross-link to it. The new article is well-structured, covers a clear single workflow (discovering what is new), and uses descriptive cross-link anchor text throughout. However, there is one critical issue -- all cross-links to the new article are broken -- and a handful of structural and formatting items that need attention before merging. Scores Summary
Key FindingsCritical -- must fix before merge:
Should fix:
Positive aspects:
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
… links
The spellcheck workflow's xargs call fails on the apostrophe in
Explore-what's-changed-in-New-Expensify.md ("unmatched single quote").
Rename the file to Explore-whats-changed-in-New-Expensify.md and update
the two migration guides to point to the corrected slug and display name.
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
Fixed the failing Root cause: The new article was named Fix: Renamed the file to |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new "Explore what's changed in New Expensify" overview article and cross-links it from the two existing "Coming from Expensify Classic" guides. The new article is well-written and clearly organized, with strong metadata and good cross-link anchor text throughout. However, several structural violations of the HelpDot authoring governance must be addressed before merge. Scores Summary
Key FindingsCritical issues that must be addressed:
Positive aspects worth highlighting:
Minor issues:
Recommendations
Files Reviewed
Generated by HelpDot Summary Reviewer |
|
Applied all relevant bot comments! This is a one-off article designed for a human audience, so it intentionally breaks many of the AI-optimization style rules in favor of human readability. |
|
A preview of your ExpensifyHelp changes have been deployed to https://dcb1b6e2.helpdot.pages.dev ⚡️ Updated articles: |
|
Looks good from a CX team review! |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.0-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀
|
Explanation of Change
Adds a new help article — What's New and Better in New Expensify — that highlights the improvements available to members switching from Expensify Classic and links each one to the relevant existing help article. The article leads with the most useful improvements (customizable and savable searches, bulk pay, full approver visibility, expense-level commenting, and Insights) and then covers the remaining items requested in the linked task (map-based mileage on mobile, Workspace merchant rules, cross-platform parity, unassigned company cards, natural-language expense editing with Concierge, the "Exported to" filter, exporting Integration Server templates from the expense level, and amending the transaction import date after a card is assigned).
The two existing Coming-from-Classic guides are updated to surface the most useful improvements (customizable searches called out by name) and link out to the new article as the single destination for "everything that is new and better":
Coming-from-Expensify-Classic-for-Submitters-and-Approvers.md— adds a callout near the top, expands the "More powerful search and reporting tools" bullet to explicitly highlight customizable columns, more filters, and saved searches, and links to the new article from the "What new features can I use" FAQ.Coming-from-Expensify-Classic-for-Workspace-Admins.md— adds a callout near the top, links to the new article from the "How Workspace management continues to improve" section alongside the existing Product Updates blog link, and links from the "What new features can I use" FAQ.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/629165
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari