[NoQA] [HR Import] Error states + reconnect prompt on the HR card by mhawryluk · Pull Request #91975 · Expensify/App

mhawryluk · 2026-05-28T14:13:14Z

Explanation of Change

When an HR connection's lastSync.isAuthenticationError is set, the HR provider card switches into a "reconnect mode": a red "Couldn't connect to {provider} due to an expired connection. Reconnect." banner is shown, where the inline "Reconnect" CTA re-launches the connection flow. The overflow menu's first item also flips from "Sync now" to "Reconnect". A red-dot indicator is shown on the workspace HR row and bubbles up to the Workspaces tab.

Fixed Issues

$ #90605
PROPOSAL: N/A

Tests

Make sure the mergeHRConnections beta is enabled.
Open a workspace with a Merge HR connection.
Remove the connection on the provider's side or in Merge dashboard and click "Sync now" back in Expensify. (or mock the Onyx data: Onyx.merge('policy_<policyID>', {connections: {merge_hris: {lastSync: {isAuthenticationError: true}}}}))
Verify there is a red error message under the connection header and a "Reconnect" item in the three-dot menu, instead of "Sync now".
Verify clicking on "Reconnect" reopens the connection flow.
Verify there is a RBR dot in: the HR tab menu item, that workspace's row in the Workspaces list, the Workspaces icon in the navigation tab bar, the Debug Mode banner.
Verify the grey subtitle under the provider's name shows in between synchronizations either "Last synced " or "Not synced" when no synchronization ever succeeded.

Offline tests

Verify the "Reconnect" button in the three dot menu is disabled when offline.

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-06-26.at.11.32.47.mov

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-06-26.at.11.41.12.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Nagranie.z.ekranu.2026-06-29.o.19.28.53.mov

melvin-bot · 2026-05-28T14:13:23Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

…licyBrickRoadIndicatorStatus

…on in getHRCards function

mhawryluk · 2026-06-19T12:45:21Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf50043b32

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-19T12:50:06Z

+                {`${translate('workspace.hr.authenticationError', card.displayName)} `}
+                <TextLink
+                    style={[styles.link, styles.fontSizeLabel]}
+                    onPress={handleConnect}


Disable the inline reconnect link while offline

When the app is offline and an HR connection needs reconnecting, the overflow Reconnect item is disabled via disabled: isOffline, but this inline link still calls handleConnect. This lets users launch the HR connection flow while offline even though the other connect/reconnect entry points are blocked, leading to an avoidable failing web/OAuth flow.

Useful? React with 👍 / 👎.

not sure, we don't really have a pattern of disabling links when offline

jmusial

Looks good, couple NAB comments

melvin-bot · 2026-06-29T17:32:30Z

@Ollyws @roryabraham One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mhawryluk · 2026-06-29T17:32:55Z

cc: @bernhardoj or @ikevin127 (HR import project)

bernhardoj · 2026-06-30T14:19:44Z

I'm feeling unwell today. I'll review this tomorrow if not urgent.

bernhardoj · 2026-07-01T16:15:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.2.mp4

Android: mWeb Chrome

android.mweb.2.mp4

iOS: HybridApp

ios.2.mp4

iOS: mWeb Safari

ios.mweb.2.mp4

MacOS: Chrome / Safari

web.2.mp4

bernhardoj · 2026-07-02T03:03:10Z

Done testing. @jmusial there is a conflict. Also, wdyt of this comment?

mhawryluk · 2026-07-02T08:19:27Z

@bernhardoj I resolved the conflict and implemented the suggestion

bernhardoj

Thanks! All good from me!

cristipaval · 2026-07-02T09:55:23Z

On you now, @roryabraham

OSBotify · 2026-07-02T18:12:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-02T18:21:40Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-02T18:29:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91975.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f2943abcbca-d099703-b1f97faed5321e3e6e8d7a838da927b1e0e088d3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f2943ab-d099703-6943aa93525ad1f64e4ace46ffd401eec493ec54/index.html

Web 🕸️
https://91975.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-03T16:42:00Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.27-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-07-06T15:27:25Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

[HR Import] Error states + reconnect prompt on the HR card

49ee44d

melvin-bot Bot assigned mhawryluk May 28, 2026

mhawryluk changed the title ~~[HR Import] Error states + reconnect prompt on the HR card~~ [NoQA] [HR Import] Error states + reconnect prompt on the HR card May 28, 2026

mhawryluk closed this Jun 2, 2026

mhawryluk reopened this Jun 18, 2026

mhawryluk added 10 commits June 19, 2026 11:10

Merge branch 'main' into merge-hr/error-reconnect

07a6a45

Move shouldShowHRConnectionError to HrUtils

7711803

FIx shouldShowHRConnectionError import

2aad24e

Show RBR in tab icon and debug mode

858bf02

Fix cycle import and move isMergeHRCompleteSetupNeeded check to getPo…

9438ad2

…licyBrickRoadIndicatorStatus

Don't hide sync description on needsReconnect

b5f8666

Fix comment

ce3c3a6

Refactor HRProviderCard menu item logic and update needsSetup conditi…

1e4065b

…on in getHRCards function

Refactor shouldShowHRConnectionError

9ce2d32

Merge branch 'main' into merge-hr/error-reconnect

bf50043

chatgpt-codex-connector Bot reviewed Jun 19, 2026

View reviewed changes

Guard for read only mode in handleConnect

faab660

jmusial reviewed Jun 22, 2026

View reviewed changes

Comment thread src/libs/HRUtils.ts

Comment thread src/pages/workspace/WorkspaceInitialPage.tsx Outdated

mhawryluk added 5 commits June 22, 2026 12:23

Add tests for shouldShowHRConnectionError

475bd39

Add a getHRBrickRoadIndicator util

a208db5

Add "Not synced" connectionDescription to HRProviderCard

c42e662

Update authenticationError copy

fc2a1a5

Decrease the number of eslint errors in HrUtilsTest.ts

5f1462a

cristipaval self-requested a review June 25, 2026 11:13

mhawryluk added 4 commits June 25, 2026 17:33

Merge branch 'main' into merge-hr/error-reconnect

18fcbcd

Fix after merge

f68d7b3

Revert the changes to getPolicyBrickRoadIndicatorStatus

13458d2

Show "Not synced" only when no successful sync ever happened

981678d

melvin-bot Bot requested review from Ollyws and roryabraham and removed request for a team June 29, 2026 17:32

cristipaval requested review from bernhardoj and removed request for Ollyws June 29, 2026 19:04

bernhardoj reviewed Jul 1, 2026

View reviewed changes

Comment thread src/libs/PolicyUtils.ts

bernhardoj reviewed Jul 1, 2026

View reviewed changes

Comment thread src/pages/workspace/hr/utils.ts Outdated

mhawryluk added 2 commits July 2, 2026 09:55

Merge branch 'main' into merge-hr/error-reconnect

06f0b9c

Construct configRows only when state.needsReconnect is false

d1b98eb

bernhardoj approved these changes Jul 2, 2026

View reviewed changes

cristipaval approved these changes Jul 2, 2026

View reviewed changes

roryabraham approved these changes Jul 2, 2026

View reviewed changes

roryabraham merged commit f2943ab into Expensify:main Jul 2, 2026
38 checks passed

OSBotify mentioned this pull request Jul 3, 2026

Deploy Checklist: New Expensify 2026-07-03 #95291

Closed

98 tasks

melvin-bot Bot mentioned this pull request Jul 6, 2026

[Due for payment 2026-07-13] [HR Import] Error states + reconnect prompt on the HR card [F12] #90605

Closed

quinthar added the #convert label Aug 11, 2026

dylanexpensify mentioned this pull request Aug 18, 2026

C+ payment for Merge.dev #98856

Open

Conversation

mhawryluk commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

mhawryluk commented Jun 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

mhawryluk Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented Jun 29, 2026

Uh oh!

mhawryluk commented Jun 29, 2026

Uh oh!

bernhardoj commented Jun 30, 2026

Uh oh!

Uh oh!

Uh oh!

bernhardoj commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

bernhardoj commented Jul 2, 2026

Uh oh!

mhawryluk commented Jul 2, 2026

Uh oh!

bernhardoj left a comment

Choose a reason for hiding this comment

Uh oh!

cristipaval commented Jul 2, 2026

Uh oh!

Uh oh!

OSBotify commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

OSBotify commented Jul 3, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mhawryluk commented May 28, 2026 •

edited

Loading

bernhardoj commented Jul 1, 2026 •

edited

Loading