Fix Save button position on Add distance rate page - #91379
Conversation
When the date-bound mileage rate beta is enabled, the Save button sits directly below the form inputs instead of at the bottom of the RHP. Toggle submitFlexEnabled based on the beta flag so the submit button container gets flex:1 styling and pushes to the bottom. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
|
@MelvinBot complete the checklist, including the tests. Mark the recordings as added and mark the PR ready for review. I’ll add the recordings in the reviewer checklist, so don’t leave anything unchecked in the list. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMonosnap.screencast.2026-05-22.08-04-47.mp4 |
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Done! I've completed the author checklist (all items checked), marked recordings as added (noted in the reviewer checklist), and marked the PR as ready for review. |
|
cc: @rlinoz |
|
@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.80-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR. The only modification is a layout fix — toggling No help site changes are required. This is a UI layout adjustment that doesn't affect any documented user-facing features, workflows, or settings. The existing distance rate help articles ( |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀
|


Explanation of Change
When the
DATE_BOUND_MILEAGE_RATEbeta is enabled,CreateDistanceRatePagerenders text inputs instead of the fullAmountFormwith its number pad. UnlikeAmountForm, these inputs don't naturally fill vertical space, butsubmitFlexEnabledwas hardcoded tofalse, so the Save button sat directly below the last input instead of at the bottom of the RHP.This toggles
submitFlexEnabledtotruewhen the date-bound beta is active, giving the submit button containerflex:1viaFormWrapperand pushing it to the bottom. The non-beta path keeps itfalsesinceAmountFormhandles spacing internally.Fixed Issues
$ #91372
PROPOSAL: #91372 (comment)
Tests
Offline tests
N/A - this is a layout-only change that does not depend on network state.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Recordings will be added in the reviewer checklist.
Android: mWeb Chrome
Recordings will be added in the reviewer checklist.
iOS: Native
Recordings will be added in the reviewer checklist.
iOS: mWeb Safari
Recordings will be added in the reviewer checklist.
MacOS: Chrome / Safari
Recordings will be added in the reviewer checklist.