Hide agent timezone from profile page and composer by MelvinBot · Pull Request #91347 · Expensify/App

MelvinBot · 2026-05-21T21:10:23Z

Explanation of Change

Agent accounts (agent_*@expensify.ai) currently show their local time in two places: on the agent's profile page and above the composer in agent DMs. This PR hides the local time display for agent accounts by adding isAgentEmail checks in both locations.

ProfilePage.tsx: Added !isAgentEmail(login) to the shouldShowLocalTime condition
ComposerLocalTime.tsx: Added isAgentEmail(reportRecipient?.login) early return check

Fixed Issues

$ #91346
PROPOSAL: #91346 (comment)

Tests

Go into the chat with an agent
Verify that no time is shown above the message bar telling you their local time
Click his profile
Check that no "Local Time" is shown
Go into a chat with a non-agent profile
Check that local time is shown above the message bar
Go into their profile
Check that Local Time is shown

Verify that no errors appear in the JS console

Offline tests

N/A — This change only affects UI visibility logic and has no offline implications.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Add isAgentEmail checks to hide local time display when viewing an agent's profile page and in the composer area of agent DMs. Co-authored-by: Nicolás Bonet <NicolasBonet@users.noreply.github.com>

github-actions · 2026-05-21T21:16:13Z

🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

codecov · 2026-05-21T21:20:08Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...x/report/ReportActionCompose/ComposerLocalTime.tsx	`100.00% <100.00%> (+21.42%)`	⬆️
src/pages/ProfilePage.tsx	`0.00% <0.00%> (ø)`
... and 26 files with indirect coverage changes

melvin-bot · 2026-05-21T21:31:49Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NicolasBonet · 2026-05-21T21:32:58Z

@MelvinBot add tests to increase coverage

Add unit tests to verify that ComposerLocalTime hides the local time display for agent accounts (agent_*@expensify.ai) while still showing it for regular participants. Co-authored-by: Nicolás Bonet <NicolasBonet@users.noreply.github.com>

melvin-bot · 2026-05-21T21:42:31Z

@NicolasBonet Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-05-21T21:42:38Z

Added tests for ComposerLocalTime in tests/unit/ComposerLocalTimeTest.tsx:

renders local time for a non-agent participant — verifies ParticipantLocalTime renders for a normal user with a valid timezone
returns null for an agent participant — verifies the component renders nothing when the recipient has an agent_*@expensify.ai email

Both tests pass locally. The isAgentEmail utility already has thorough unit test coverage in tests/unit/SessionUtilsTest.ts.

NicolasBonet · 2026-05-21T21:47:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

In the issue description

- Use for…of instead of .forEach() (unicorn/no-array-for-each) - Use getByText instead of queryByText for presence assertion (testing-library/prefer-presence-queries) Co-authored-by: Nicolás Bonet <NicolasBonet@users.noreply.github.com>

MelvinBot · 2026-05-21T21:54:55Z

Fixed the failing ESLint check: replaced .forEach() with for…of and queryByText with getByText in tests/unit/ComposerLocalTimeTest.tsx.

github-actions · 2026-05-22T13:04:35Z

🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-22T13:10:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91347.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5449c10-b7e4ee8-d1354f54ada99a1f0d1f24e039509e5691a26a80/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5449c10-b7e4ee8-6c4c01b24a3572327ecf9adc468e135a7a5ac938/index.html

Web 🕸️
https://91347.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-22T13:12:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-22T22:45:40Z

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.3.80-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-22T22:47:06Z

No help site changes required.

I reviewed the PR changes and searched all help site articles under App/docs/articles. The PR hides the local time display for agent accounts (agent_*@expensify.ai) on profile pages and above the composer in DMs. The help site timezone articles (Account-Settings.md, Set-Timezone.md) only cover setting your own timezone — they don't document viewing another user's local time in chat or on profiles. No articles reference agent accounts or this specific UI feature, so no documentation updates are needed.

OSBotify · 2026-05-25T22:38:10Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Hide local time for agent accounts on profile and composer

3c9daee

Add isAgentEmail checks to hide local time display when viewing an agent's profile page and in the composer area of agent DMs. Co-authored-by: Nicolás Bonet <NicolasBonet@users.noreply.github.com>

MelvinBot assigned NicolasBonet May 21, 2026

MelvinBot requested a review from a team May 21, 2026 21:10

MelvinBot mentioned this pull request May 21, 2026

[Due for payment 2026-06-01] [$250] Don't show agent timezone #91346

Closed

This comment has been minimized.

Sign in to view

NicolasBonet marked this pull request as ready for review May 21, 2026 21:31

NicolasBonet requested a review from a team as a code owner May 21, 2026 21:31

melvin-bot Bot requested review from ShridharGoel and heyjennahay and removed request for a team May 21, 2026 21:31

melvin-bot Bot removed the request for review from a team May 21, 2026 21:31

MelvinBot requested a review from a team as a code owner May 21, 2026 21:42

melvin-bot Bot requested review from NicolasBonet and removed request for a team May 21, 2026 21:42

Fix ESLint errors in ComposerLocalTimeTest

4dafede

- Use for…of instead of .forEach() (unicorn/no-array-for-each) - Use getByText instead of queryByText for presence assertion (testing-library/prefer-presence-queries) Co-authored-by: Nicolás Bonet <NicolasBonet@users.noreply.github.com>

NicolasBonet approved these changes May 21, 2026

View reviewed changes

ShridharGoel approved these changes May 22, 2026

View reviewed changes

melvin-bot Bot requested a review from NicolasBonet May 22, 2026 05:19

github-actions Bot reviewed May 22, 2026

View reviewed changes

Comment thread src/pages/ProfilePage.tsx

github-actions Bot reviewed May 22, 2026

View reviewed changes

Comment thread src/pages/inbox/report/ReportActionCompose/ComposerLocalTime.tsx

NicolasBonet merged commit 5449c10 into main May 22, 2026
40 checks passed

NicolasBonet deleted the claude-hideAgentTimezone branch May 22, 2026 13:03

OSBotify mentioned this pull request May 22, 2026

Deploy Checklist: New Expensify 2026-05-22 #91472

Closed

71 tasks

quinthar added the #ai label Aug 11, 2026

Conversation

MelvinBot commented May 21, 2026 • edited by NicolasBonet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

codecov Bot commented May 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

melvin-bot Bot commented May 21, 2026

Uh oh!

NicolasBonet commented May 21, 2026

Uh oh!

melvin-bot Bot commented May 21, 2026

Uh oh!

MelvinBot commented May 21, 2026

Uh oh!

NicolasBonet commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented May 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 22, 2026

Uh oh!

github-actions Bot commented May 22, 2026

Uh oh!

OSBotify commented May 22, 2026

Uh oh!

OSBotify commented May 22, 2026

Uh oh!

MelvinBot commented May 22, 2026

Uh oh!

OSBotify commented May 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented May 21, 2026 •

edited by NicolasBonet

Loading

codecov Bot commented May 21, 2026 •

edited by github-actions Bot

Loading

NicolasBonet commented May 21, 2026 •

edited

Loading