Skip to content

Simplify the ready state of the welcome task #9132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techievivek merged 3 commits into from
May 24, 2022
Merged

Simplify the ready state of the welcome task #9132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e54c66d
Simplify the ready state of the welcome task
tgolen May 23, 2022
6fb93fe
Merge branch 'main' into tgolen-simplify-welcome-ready
tgolen May 24, 2022
bb2b7fa
Remove createonreadytask
tgolen May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/libs/actions/Welcome.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ import * as Policy from './Policy';
import ONYXKEYS from '../../ONYXKEYS';
import NameValuePair from './NameValuePair';
import CONST from '../../CONST';
import createOnReadyTask from '../createOnReadyTask';
Comment thread
Luke9389 marked this conversation as resolved.

const readyTask = createOnReadyTask();
let resolveIsReadyPromise;
let isReadyPromise = new Promise((resolve) => {
resolveIsReadyPromise = resolve;
});

let isFirstTimeNewExpensifyUser;
let isLoadingReportData = true;
Expand All @@ -28,7 +30,7 @@ function checkOnReady() {
return;
}

readyTask.setIsReady();
resolveIsReadyPromise();
}

Onyx.connect({
Expand Down Expand Up @@ -91,7 +93,7 @@ Onyx.connect({
* @param {Function} params.showCreateMenu
*/
function show({routes, showCreateMenu}) {
readyTask.isReady().then(() => {
isReadyPromise.then(() => {
if (!isFirstTimeNewExpensifyUser) {
return;
}
Expand Down Expand Up @@ -122,7 +124,9 @@ function show({routes, showCreateMenu}) {
}

function resetReadyCheck() {
readyTask.reset();
isReadyPromise = new Promise((resolve) => {
resolveIsReadyPromise = resolve;
});
}

export {
Expand Down
26 changes: 0 additions & 26 deletions src/libs/createOnReadyTask.js
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions tests/unit/createOnReadyTaskTest.js
View file
Open in desktop

This file was deleted.