Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
initial review done here! software-mansion-labs#340 |
|
@codex review |
|
|
💡 Codex Review Preserve fullscreen route when guard redirects to modal
Resetting to ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
…ooms/add-go-to-room-row-in-rhp
bee8f19 to
30d72bc
Compare
…-rooms/add-go-to-room-row-in-rhp
|
@grgia Could you run transcription workflow here please? :) |
9ee341a to
eedc2ab
Compare
|
@jakubstec ran it |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index d667dfc8f8e..2968c39685a 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4414,6 +4414,7 @@ ${amount} für ${merchant} – ${date}`,
cardAdminAlternateText: 'Arbeitsbereichskarten verwalten.',
peopleAdminAlternateText: 'Mitglieder und Genehmigungsabläufe verwalten.',
paymentsAdminAlternateText: 'Workflow-Zahlungen verwalten.',
+ goToRoom: 'Zum Raum gehen',
},
createdForClient: {
title: 'Du hast einen Workspace für deinen Kunden erstellt!',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 124f418aa5b..956704d2630 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -4306,6 +4306,7 @@ ${amount} para ${merchant} - ${date}`,
cardAdminAlternateText: 'Gestiona tarjetas del espacio de trabajo.',
peopleAdminAlternateText: 'Gestiona miembros y flujos de aprobación.',
paymentsAdminAlternateText: 'Gestiona los pagos del flujo de trabajo.',
+ goToRoom: 'Ir a la sala',
},
createdForClient: {
title: '¡Has creado un espacio de trabajo para tu cliente!',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index ad9c0776904..8d7cd72aa93 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2814,9 +2814,9 @@ ${amount} pour ${merchant} - ${date}`,
title: 'Modifier l’agent',
agentName: 'Nom de l’agent',
instructions: 'Écrire des instructions personnalisées',
- chatWithAgent: 'Discuter avec l\u2019agent',
+ chatWithAgent: 'Discuter avec l’agent',
copilotIntoAccount: 'Copilote dans le compte',
- deleteAgent: 'Supprimer l\u2019agent',
+ deleteAgent: 'Supprimer l’agent',
deleteAgentTitle: 'Supprimer l’agent ?',
deleteAgentMessage: 'Voulez-vous vraiment supprimer cet agent ? Cette action est irréversible.',
},
@@ -2979,7 +2979,7 @@ ${amount} pour ${merchant} - ${date}`,
phoneOrEmail: 'Téléphone ou e-mail',
error: {
agentSignInBlocked:
- 'Les comptes d\u2019agent ne permettent pas de se connecter directement. Pour utiliser un agent, connectez-vous avec votre propre compte et accédez-y via Copilot.',
+ 'Les comptes d’agent ne permettent pas de se connecter directement. Pour utiliser un agent, connectez-vous avec votre propre compte et accédez-y via Copilot.',
invalidFormatEmailLogin: 'L’adresse e-mail saisie est invalide. Veuillez corriger le format et réessayer.',
},
cannotGetAccountDetails: 'Impossible de récupérer les détails du compte. Veuillez essayer de vous reconnecter.',
@@ -4425,6 +4425,7 @@ ${amount} pour ${merchant} - ${date}`,
cardAdminAlternateText: 'Gérer les cartes de l’espace de travail.',
peopleAdminAlternateText: 'Gérez les membres et les workflows d’approbation.',
paymentsAdminAlternateText: 'Gérer les paiements de workflow.',
+ goToRoom: 'Aller au salon',
},
createdForClient: {
title: 'Vous avez créé un espace de travail pour votre client !',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index a6b6451b56b..5a5eeb2fcc1 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2802,8 +2802,8 @@ ${amount} per ${merchant} - ${date}`,
title: 'Modifica agente',
agentName: 'Nome agente',
instructions: 'Scrivi istruzioni personalizzate',
- chatWithAgent: 'Chatta con l\u2019agente',
- copilotIntoAccount: 'Copilot nell\u2019account',
+ chatWithAgent: 'Chatta con l’agente',
+ copilotIntoAccount: 'Copilot nell’account',
deleteAgent: 'Elimina agente',
deleteAgentTitle: 'Eliminare agente?',
deleteAgentMessage: 'Sei sicuro di voler eliminare questo agente? Questa azione non può essere annullata.',
@@ -4399,6 +4399,7 @@ ${amount} per ${merchant} - ${date}`,
cardAdminAlternateText: 'Gestisci le carte dello spazio di lavoro.',
peopleAdminAlternateText: 'Gestisci i membri e i flussi di approvazione.',
paymentsAdminAlternateText: 'Gestisci i pagamenti del flusso di lavoro.',
+ goToRoom: 'Vai alla stanza',
},
createdForClient: {
title: 'Hai creato uno spazio di lavoro per il tuo cliente!',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 6f7b222188d..1b3e47b5a1e 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4371,6 +4371,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
cardAdminAlternateText: 'ワークスペースカードを管理します。',
peopleAdminAlternateText: 'メンバーと承認ワークフローを管理します。',
paymentsAdminAlternateText: 'ワークフローの支払いを管理します。',
+ goToRoom: 'ルームに移動',
},
createdForClient: {
title: 'クライアントのワークスペースを作成しました！',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 8c3fcff4afb..88f566cd0fd 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4395,6 +4395,7 @@ ${amount} voor ${merchant} - ${date}`,
cardAdminAlternateText: 'Werkruimtekaarten beheren.',
peopleAdminAlternateText: 'Beheer leden en goedkeuringsworkflows.',
paymentsAdminAlternateText: 'Workflowsbetalingen beheren.',
+ goToRoom: 'Ga naar kamer',
},
createdForClient: {
title: 'Je hebt een werkruimte voor je klant aangemaakt!',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 16658367633..370896641d2 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -4387,6 +4387,7 @@ ${amount} dla ${merchant} - ${date}`,
cardAdminAlternateText: 'Zarządzaj kartami przestrzeni roboczej.',
peopleAdminAlternateText: 'Zarządzaj członkami i procesami akceptacji.',
paymentsAdminAlternateText: 'Zarządzaj płatnościami w przepływie pracy.',
+ goToRoom: 'Przejdź do pokoju',
},
createdForClient: {
title: 'Utworzyłeś przestrzeń roboczą dla swojego klienta!',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index e99cb41e547..65bc9a74948 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4389,6 +4389,7 @@ ${amount} para ${merchant} - ${date}`,
cardAdminAlternateText: 'Gerenciar cartões do workspace.',
peopleAdminAlternateText: 'Gerencie membros e fluxos de aprovação.',
paymentsAdminAlternateText: 'Gerencie pagamentos de fluxo de trabalho.',
+ goToRoom: 'Ir para a sala',
},
createdForClient: {
title: 'Você criou um espaço de trabalho para seu cliente!',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 9743c91cd4c..87509be24a1 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4293,6 +4293,7 @@ ${amount}，商户：${merchant} - 日期：${date}`,
cardAdminAlternateText: '管理工作区卡片。',
peopleAdminAlternateText: '管理成员和审批流程。',
paymentsAdminAlternateText: '管理工作流付款。',
+ goToRoom: '进入房间',
},
createdForClient: {
title: '您已为客户创建了工作区！',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@jakubstec anything blocking us from moving forward? |
|
@dylanexpensify hey, while I was OoO, @sumo-slonik has included this code in his PR here #92096, so we might consider his PR as main for this issue |
|
@jakubstec I merged the other PR, can you confirm what to do about this one 🙏 |
We’ll close this one. |
6 participants
Explanation of Change
Added
Go to roomrow in workspace room details RHP, to handle navigation. Visible only when users have accessed the Details page from any screen that is not the report (#Room) itselfFixed Issues
$ #89902
PROPOSAL:
Tests
Verify, that room is correctly created and you are navigated to room chat screen
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
roomrow.mp4