Skip to content

[No QA] Add redirect for uploading expense policy document - #91135

Merged
VictoriaExpensify merged 1 commit into
mainfrom
stephanieelliott-patch-1
May 19, 2026
Merged

VictoriaExpensify merged 1 commit into
mainfrom
stephanieelliott-patch-1

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

Update redirects file for new link

@stephanieelliott
stephanieelliott requested a review from a team as a code owner May 19, 2026 22:38
@stephanieelliott stephanieelliott self-assigned this May 19, 2026
@stephanieelliott
stephanieelliott requested review from VictoriaExpensify and removed request for a team May 19, 2026 22:39
@melvin-bot
melvin-bot Bot requested a review from Valforte May 19, 2026 22:39
@melvin-bot

melvin-bot Bot commented May 19, 2026

Copy link
Copy Markdown

@Valforte Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NOTE: It looks like docs/redirects.csv was modified in this PR. Please see this SO for special instructions on how to review changes to that file.

@stephanieelliott
stephanieelliott removed the request for review from Valforte May 19, 2026 22:40
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single redirect entry to docs/redirects.csv, mapping the old URL path Upload-an-expense-policy-document to the new path Add-an-Expense-Policy-to-a-Workspace. No article content is added or modified -- this is purely a redirect update.

Scores Summary

  • Readability: 10/10 - Not applicable; no prose content was changed. The redirect entry is correctly formatted as a two-column CSV row.
  • AI Readiness: 10/10 - Not applicable; no metadata, headings, or article content involved. The new target URL uses a task-based slug ("Add-an-Expense-Policy-to-a-Workspace"), which aligns well with AI retrieval conventions.
  • Style Compliance: 10/10 - Not applicable; no UI terminology, navigation instructions, or article structure to evaluate.

Key Findings

  • The redirect follows the existing CSV format (old URL, new URL) consistent with all other entries in the file.
  • The new target path uses task-based naming ("Add an Expense Policy to a Workspace"), which is preferable over the old path ("Upload an expense policy document") from a governance perspective -- it starts with an action verb and includes the feature context.
  • No content, structural, or style issues to flag.

Recommendations

  • None. This is a straightforward, well-formed redirect addition.

Files Reviewed

  • docs/redirects.csv -- One redirect line added. No issues found.

@github-actions github-actions Bot changed the title Add redirect for uploading expense policy document [No QA] Add redirect for uploading expense policy document May 19, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://a877e768.helpdot.pages.dev ⚡️

@VictoriaExpensify
VictoriaExpensify merged commit b6209dc into main May 19, 2026
22 checks passed
@VictoriaExpensify
VictoriaExpensify deleted the stephanieelliott-patch-1 branch May 19, 2026 23:02
@melvin-bot

melvin-bot Bot commented May 19, 2026

Copy link
Copy Markdown

@VictoriaExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label May 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single redirect entry in docs/redirects.csv, pointing the old URL (Upload-an-expense-policy-document) to the new article (Add-an-Expense-Policy-to-a-Workspace). No article content is added or modified. The change is straightforward and well-formed.

Scores Summary

  • Readability: 10/10 - Not applicable to article content; the redirect entry is clear and correctly formatted.
  • AI Readiness: 10/10 - Not applicable; no article metadata or headings are changed. The new target article title ("Add an Expense Policy to a Workspace") is task-based and includes the feature name, which is a good sign.
  • Style Compliance: 10/10 - The redirect follows the established CSV format (old URL, new URL) consistent with all other entries in the file.

Key Findings

  • The redirect format matches the existing pattern in redirects.csv (full source URL, full destination URL, comma-separated).
  • The target article (Add-an-Expense-Policy-to-a-Workspace.md) exists in the repository, so the redirect will resolve correctly.
  • The old URL path (Upload-an-expense-policy-document) does not have a corresponding article file, confirming the redirect is necessary to avoid a broken link.
  • The new article title uses a task-based verb ("Add") which aligns with the heading rules in HELP_AUTHORING_GUIDELINES.md.

Recommendations

  • No changes needed. This is a clean, correctly formatted redirect addition.

Files Reviewed

  • docs/redirects.csv -- One line added. Redirect is valid and properly formatted.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.3.79-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants