fix: Card details page title and toggle button spacing

[samranahm]

Explanation of Change

Fixed Issues

$ #88234
PROPOSAL: #88234 (comment)

Tests

1. Open Account tab and navigate to Wallet
2. Press "Add personnel card" and press next
3. Select United States on "Where’s your bank located?"
4. Select "Mock bank" and press Next
5. Under "Assigned cards" select the mock card to open "Card details"
6. Verify "Mark transactions as reimbursable" title and toggle button has proper spacing
7. Select another local i.e "Français" and verify text wrap to next line if it exceed the limit on first row

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android.native.mp4

Android: mWeb Chrome

Android.mWeb.Chrome.mp4

iOS: Native

IOS.Native.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

macOS.Chrome.mp4

---

^{Need help on this PR? Tag @codesmith with what you need.}

• Let Codesmith autofix CI failures and bot reviews

[melvin-bot]

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Copilot]

Pull request overview

This PR adjusts the layout of ToggleSettingOptionRow (used across multiple settings screens, including the personal card details header menu) to improve spacing between the title/subtitle content and the trailing switch—especially in longer translations where wrapping occurs.

Changes:

• Increased top spacing for subtitles rendered below the switch (mt1 → mt3).
• Added right margin to the default title container to create a consistent gap from the switch (mr3).
• Removed a conditional fixed-height constraint on the main row container when subtitles are placed below the switch.

Comments suppressed due to low confidence (2)

src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx:199

• The new right margin (styles.mr3) is only applied in the default title rendering path. When customTitle is provided, there’s no equivalent spacing, so custom titles can still end up too close to the switch. Consider moving the margin/spacing to a shared container so it applies to both title and customTitle.

            {customTitle ?? (
                <View style={[styles.flexColumn, styles.flex1, styles.mr3]}>
                    <Text

src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx:239

• Removing the conditional styles.h10 means the row can shrink to the intrinsic height of its contents (e.g. ~28px for the switch), reducing the tappable area for the row when shouldPlaceSubtitleBelowSwitch is true. If the fixed height was causing wrapping/clipping issues, consider using a minHeight (e.g. styles.mnh40) instead of removing the height constraint entirely.

                <View style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween]}>

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...es/workspace/workflows/ToggleSettingsOptionRow.tsx	100.00% <100.00%> (ø)
... and 15 files with indirect coverage changes

[truph01]

@samranahm Could you merge main?

[samranahm]

@truph01 All yours, please take a look.

[truph01]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

[truph01]

@samranahm Do you think we should revert all changes related to vertical style since it is out of scope?

[samranahm]

@truph01 we can absolutely do that but then this way there'd be little vertical spacing between title and subtitle when title wraps to second line.

Here's the vertical space when title on single line

Title wraps to second line

Narrow vertical gap	Same gap as single line

[truph01]

@samranahm Could you ask the design team to confirm about the change we made in vertical spacing?

[samranahm]

@Expensify/design We have added vertical spacing on the "Card details" page between the "Mark transactions as reimbursable" title and the subtitle below.

Problem: When the title remains on a single line, we get the desired vertical spacing we needed. However, now we’ve introduced title wrapping, the title and subtitle keep their positions intact, which leads to a very narrow gap between the title and subtitle.

Can you please take a look at this #91115 (comment) and confirm the vertical spacing?

[samranahm]

@dubielzyk-expensify Can you see the above comment please.

[dubielzyk-expensify]

The name and toggle are still very close to me. I'd add 8px or so padding. Curious if @Expensify/design agrees though.

[shawnborton]

Yeah I agree, I think there should be like 24px of visible gap between the elements on each of those rows. It just depends how much vertical padding each row is already wrapped with.... typically we do 12px of vertical padding on each row and then 0 gap between them, which gives us the 24px effect.

[JmillsExpensify]

LGTM

[samranahm]

Thanks for the feedback! I've updated the gap between from mr3 to mr6 24px. @truph01 please take a look.

[JmillsExpensify]

LGTM

[samranahm]

@marcochavezf Gentle bump.

[github-actions]

🚧 @marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91115.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b8ccf8021b4-136c658-80cb7162da7abf7d5ade0e0e6ef690e30128b558/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b8ccf80-136c658-08188f56c4fd9e006affbdf8bdcc8619894ec254/index.html

Web 🕸️
https://91115.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[MelvinBot]

Help site review — No changes required

I reviewed the changes in this PR against Expensify's help site files under App/docs/articles.

Conclusion: No help site documentation updates are required.

Reasoning: This PR is a purely visual/styling fix. The only file changed is src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx, and the change consists entirely of margin spacing adjustments:

• styles.mt1 → styles.mt3 for the subtitle when placed below the switch (top spacing)
• Added styles.mr6 to the title column (right margin so the title text wraps before colliding with the toggle)

There are no changes to:

• User-facing copy, labels, button text, or feature names
• Feature behavior or workflows
• Settings, configuration options, or navigation

Help site articles document product behavior and user-facing copy/workflows. Since this PR only adjusts pixel-level spacing to fix a layout overlap, there is nothing in the help site that needs to be updated, and no draft docs PR has been created.

---

@samranahm, no help site PR was created because this change is styling-only with no user-facing or behavioral impact. If you believe a docs update is needed for related behavior I may have missed, let me know and I'll take another look.

[OSBotify]

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.12-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[MelvinBot]

🤖 No help site changes required.

I reviewed the changes in this PR. The only modified file is src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx, and the diff is purely a visual spacing fix:

• Subtitle top margin changed from mt1 → mt3 when placed below the switch
• Added mr6 (right margin) to the title column so long titles wrap correctly instead of crowding the toggle

These are CSS/layout-only adjustments. No user-facing copy, feature names, settings labels, tab names, buttons, or behaviors were added or changed.

Expensify's help site files under App/docs/articles document features, workflows, and behaviors — not pixel-level spacing or layout of UI components. Since nothing documented on the help site is affected, no draft docs PR was created.

@samranahm, since this change doesn't affect any documented behavior, there's no linked help site PR to review. If you believe a specific article is impacted (e.g. a screenshot that should be refreshed), let me know which one and I'll create the draft PR.

[OSBotify]

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.14-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅