Support CMD+click on search and workspace rows by KJ21-ENG · Pull Request #91021 · Expensify/App

KJ21-ENG · 2026-05-18T22:08:31Z

Explanation of Change

Adds web-only modified-click handling for internal Search result rows and workspace rows. Press handlers now preserve the mouse event, open the same computed route in a new browser tab for CMD/CTRL + primary-click, and keep normal clicks, keyboard activation, mobile/native behavior, inline editing, and selection mode on the existing current-tab flow. Grouped expense headers and expanded child row/View/arrow paths are included.

Ready for review: targeted formatting/lint/type checks, focused Jest coverage, and an independent regression audit are complete. Manual recording is attached for MacOS; native/mobile sections are N/A because the new helper is a native no-op and the user-facing behavior is web modified-click.

Fixed Issues

$ #90951
PROPOSAL: #90951 (comment)

Tests

Open the web app on MacOS Chrome or Safari.
Go to Spend > Expenses.
CMD+click an expense row and verify the destination opens in a new browser tab while the current tab stays on the Search page.
Plain-click the same expense row and verify it still opens in the current tab/RHP as before.
Go to Spend > Reports.
CMD+click a report result row and verify the destination opens in a new browser tab while the current tab stays on the Search page.
Test grouped expense results: CMD+click a grouped expense header, an expanded child row, the child View button, and the wide-layout arrow. Verify each opens the same target route in a new browser tab.
Verify grouped expand/collapse arrows still only expand/collapse the group and do not open a new tab.
Go to Workspaces.
CMD+click a workspace row and verify the workspace editor opens in a new browser tab.
Plain-click the same workspace row and verify it still navigates in the current tab.
Focus a Search or Workspace row and press Enter. Verify keyboard activation still navigates in the current tab and does not open a new tab.

Targeted checks completed:

npx prettier --experimental-cli --no-cache --write --ignore-unknown <changed files> and git diff --check
./scripts/lint.sh <changed files>
npm run typecheck-tsgo (only unrelated existing repo errors remain outside this PR)
npm test -- --runTestsByPath tests/ui/BaseListItemTest.tsx tests/unit/TransactionGroupListItemTest.tsx tests/ui/ReportListItemHeaderTest.tsx tests/ui/WorkspaceListPageTest.tsx tests/unit/Search/SearchUIUtilsTest.ts --runInBand --silent
Independent regression audit found no blocking regressions
Verify that no errors appear in the JS console

Offline tests

Go offline in the browser devtools/network controls.
Repeat the CMD+click checks for one Search result row and one Workspace row.
Verify each internal route opens in a new browser tab and the current tab does not navigate.

Verify that no errors appear in the JS console

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

desktop_chrome1779141576349929.mp4

codecov · 2026-05-18T22:17:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ts/Search/SearchList/ListItem/ActionCell/index.tsx	`62.50% <ø> (ø)`
src/components/Search/SearchList/index.tsx	`54.65% <ø> (ø)`
...components/SelectionList/ListItem/BaseListItem.tsx	`88.31% <ø> (ø)`
...ents/TransactionItemRow/TransactionItemRowWide.tsx	`96.03% <ø> (+0.94%)`	⬆️
.../helpers/openInternalRouteInNewTab/index.native.ts	`100.00% <100.00%> (ø)`
src/libs/SearchUIUtils.ts	`64.14% <100.00%> (ø)`
src/pages/workspace/WorkspacesListRow.tsx	`92.50% <ø> (ø)`
...earch/SearchList/ListItem/ReportListItemHeader.tsx	`90.19% <50.00%> (ø)`
...h/SearchList/ListItem/TransactionGroupListItem.tsx	`73.10% <50.00%> (ø)`
.../TransactionListItem/TransactionListItemNarrow.tsx	`0.00% <0.00%> (ø)`
... and 6 more
... and 16 files with indirect coverage changes

melvin-bot · 2026-05-18T22:59:42Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2026-05-19T13:52:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-05-21.at.3.41.05.AM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-21.at.3.32.34.AM.mov

Screen.Recording.2026-05-21.at.3.36.19.AM.mov

…click-new-tab # Conflicts: # src/components/Search/SearchList/ListItem/TransactionGroupListExpanded.tsx # src/components/Search/index.tsx # src/libs/SearchUIUtils.ts

ShridharGoel · 2026-05-20T22:01:33Z

@KJ21-ENG Can you also include some mobile videos while checking that long press and multiple selection related things are working fine there?

Beamanator

LGTM

github-actions · 2026-05-21T14:05:53Z

🚧 @Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-21T14:10:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91021.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-08de77f-fdf8a2c-5e7c0434144e798272a0ed8d1325b8e7651cca29/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-08de77f-fdf8a2c-aa8900a6f1265a5b311c560613bdf2f375c98d72/index.html

Web 🕸️
https://91021.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-21T14:15:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-21T21:52:25Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.3.79-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-21T21:55:23Z

Yes, help site changes are needed. PR #91021 adds CMD/Ctrl+click support for opening search results and workspace rows in a new browser tab — this is a new web navigation capability worth documenting.

Draft PR created: #91360

Changes made to docs/articles/new-expensify/getting-started/Navigating-New-Expensify.md:

Added a new section "How to open items in a new browser tab on web" covering CMD (Mac) / Ctrl (Windows/Linux) + click on Spend and Workspaces rows
Added an FAQ entry for the CMD+click feature
Updated keywords and internalScope metadata

Please mark it as "Ready for review" when it is ready for review.

OSBotify · 2026-05-22T22:26:20Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Support modified-click opening rows in new tabs

c401422

melvin-bot Bot assigned KJ21-ENG May 18, 2026

KJ21-ENG added 2 commits May 19, 2026 04:17

Fix targeted validation issues

5d8511c

Record final validation

e7eb9aa

KJ21-ENG marked this pull request as ready for review May 18, 2026 22:59

KJ21-ENG requested review from a team as code owners May 18, 2026 22:59

melvin-bot Bot requested review from ShridharGoel and removed request for a team May 18, 2026 22:59

melvin-bot Bot requested review from heyjennahay and removed request for a team May 18, 2026 22:59

KJ21-ENG mentioned this pull request May 18, 2026

[Due for payment 2026-05-29] [$250] [CFI] Support CMD+click on search results and the list of workspaces to open a new tab #90951

Closed

7 tasks

github-actions Bot reviewed May 18, 2026

View reviewed changes

Comment thread src/libs/Navigation/helpers/openInternalRouteInNewTab/index.native.ts Outdated

github-actions Bot reviewed May 18, 2026

View reviewed changes

Comment thread src/components/Search/SearchList/ListItem/TransactionListItem/index.tsx

Address review consistency comments

c74b031

ShridharGoel reviewed May 19, 2026

View reviewed changes

Comment thread src/components/SelectionList/ListItem/BaseListItem.tsx Outdated

Comment thread src/components/SelectionList/ListItem/BaseListItem.tsx Outdated

KJ21-ENG added 2 commits May 19, 2026 20:30

Revert unnecessary BaseListItem prop expansion

d7c3c2a

Merge remote-tracking branch 'upstream/main' into KJ21-ENG/90951-cmd-…

e665ff6

…click-new-tab # Conflicts: # src/components/Search/SearchList/ListItem/TransactionGroupListExpanded.tsx # src/components/Search/index.tsx # src/libs/SearchUIUtils.ts

ShridharGoel suggested changes May 20, 2026

View reviewed changes

Comment thread src/components/Search/SearchList/ListItem/TransactionGroupListExpanded.tsx

ShridharGoel approved these changes May 21, 2026

View reviewed changes

melvin-bot Bot requested a review from Beamanator May 21, 2026 12:14

Beamanator approved these changes May 21, 2026

View reviewed changes

Beamanator merged commit 08de77f into Expensify:main May 21, 2026
46 checks passed

OSBotify mentioned this pull request May 21, 2026

Deploy Checklist: New Expensify 2026-05-21 #91350

Closed

MelvinBot mentioned this pull request May 21, 2026

Docs updates for E/A#91021 Add CMD+click new tab navigation docs #91360

Closed

aswin-s mentioned this pull request Jul 17, 2026

[Due for payment 2026-08-10] [$250] Workspace - CMD+click on workspace row does not open workspace in new tab #96384

Closed

7 tasks

quinthar added the #migrate label Aug 11, 2026

Conversation

KJ21-ENG commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 18, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 18, 2026

Uh oh!

Uh oh!

Uh oh!

ShridharGoel commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

ShridharGoel commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

MelvinBot commented May 21, 2026

Uh oh!

OSBotify commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

KJ21-ENG commented May 18, 2026 •

edited

Loading

codecov Bot commented May 18, 2026 •

edited by github-actions Bot

Loading

ShridharGoel commented May 19, 2026 •

edited

Loading

ShridharGoel commented May 20, 2026 •

edited

Loading