Part 9 - Add delegateAccountIDParam to IOU + ReportPreview builders and thread through action helpers by Krishna2323 · Pull Request #90901 · Expensify/App

Krishna2323 · 2026-05-16T23:50:50Z

Explanation of Change

Fixed Issues

$ #66425
PROPOSAL:

Tests

Account A grants copilot access to Account B
Account B switches to act as Account A (delegate mode)
Submit an expense (e.g. $25 to a workspace)
Verify: The delegate indicator ("on behalf of Account A") appears on the optimistic report action
Switch back to acting as yourself, submit another expense
Verify: No delegate indicator appears

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Monosnap.screencast.2026-05-17.05-51-29.mp4

codecov · 2026-05-16T23:59:14Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`83.05% <100.00%> (+<0.01%)`	⬆️
src/libs/actions/IOU/Hold.ts	`93.75% <ø> (ø)`
src/libs/actions/IOU/MoneyRequestBuilder.ts	`89.11% <100.00%> (ø)`
src/libs/actions/IOU/PayMoneyRequest.ts	`81.34% <100.00%> (ø)`
src/libs/actions/IOU/RejectMoneyRequest.ts	`77.83% <100.00%> (ø)`
src/libs/actions/IOU/SendInvoice.ts	`95.96% <100.00%> (ø)`
src/libs/actions/IOU/TrackExpense.ts	`81.04% <100.00%> (ø)`
src/libs/actions/MergeTransaction.ts	`67.89% <ø> (ø)`
src/libs/actions/Report/index.ts	`69.43% <100.00%> (-0.11%)`	⬇️
src/libs/actions/Search.ts	`32.87% <ø> (ø)`
... and 4 more
... and 9 files with indirect coverage changes

Krishna2323 · 2026-05-17T00:16:08Z

@codex review

chatgpt-codex-connector · 2026-05-17T00:20:13Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-05-17T00:23:48Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

… through action helpers Signed-off-by: krishna2323 <belivethatkg@gmail.com>

…declarations Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-05-21T17:54:29Z

@DylanDylann friendly bump

Krishna2323 · 2026-05-25T05:06:01Z

@DylanDylann could you please take a look?

DylanDylann · 2026-05-27T04:17:07Z

@Krishna2323 Could you merge new main?

DylanDylann · 2026-05-27T04:26:37Z

@Krishna2323 Could you provide a short summary of the changes? I noticed you added new optional params to many functions. Is it possible to complete this incrementally instead?

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-05-27T06:08:19Z

@DylanDylann this PR adds delegateAccountIDParam to 3 builder functions (buildOptimisticIOUReportAction, buildOptimisticReportPreview, buildOptimisticMoneyRequestEntities) with a fallback to the existing delegateEmail so nothing breaks. The optional params in action helpers are temporary — each follow-up PR (10–15) will migrate callers and make them required, then remove the fallback entirely.

PR 8 (merged) did the same for buildOptimisticModifiedExpenseReportAction.

DylanDylann · 2026-05-28T08:24:27Z

@codex review

chatgpt-codex-connector · 2026-05-28T08:28:43Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann · 2026-05-28T08:37:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-05-28.at.16.18.19.mov

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-06-01T15:30:56Z

@madmax330 I think you forgot to merge? 😅

OSBotify · 2026-06-01T17:06:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-01T17:35:12Z

🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-01T17:47:57Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90901.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-02575491216-5179020-95439a9dc63562eff597ca6ed30248c52302104b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0257549-5179020-911e474ee476de08589c13b93907874d54d32cfc/index.html

Web 🕸️
https://90901.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-02T06:30:53Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.91-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-02T06:33:27Z

🤖 No help site changes required.

I reviewed the changes in this PR against the help site files under App/docs/articles and determined no documentation updates are needed, so I did not create a draft PR.

Why: This is an internal code refactor, not a user-facing change.

The linked issue Expensify/App#66425 is part of the effort to deprecate Onyx.connect() — specifically removing it for ONYXKEYS.ACCOUNT in src/libs/ReportUtils.ts.
The PR threads a delegateAccountIDParam through the IOU / ReportPreview builders and action helpers so the delegate account ID is passed explicitly rather than read from a module-level Onyx.connect value.
The delegate ("on behalf of") indicator behavior is unchanged — the refactor preserves existing behavior via a fallback to the previous module-level lookup for callers not yet migrated.
No src/languages/* copy, UI labels, feature names, tabs, or settings were added or modified. All changes are TypeScript function signatures, parameter threading, and a unit test.

Help site articles document end-user product behavior, and nothing about the product experience changed here, so there is nothing to update.

@Krishna2323, if you believe a user-facing behavior did change and warrants a docs update, reply with the specific behavior and I'll re-evaluate.

OSBotify · 2026-06-02T21:04:14Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.94-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-02T21:09:42Z

🤖 Help site review: no documentation changes required.

This PR is an internal refactor — part of the Onyx.connect() deprecation effort. It threads a delegateAccountID value explicitly through the IOU and ReportPreview builders and their helper functions instead of reading it from a module-level Onyx.connect subscription.

Why no docs are needed:

The delegate/copilot "on behalf of" indicator is an existing feature whose user-facing behavior is unchanged — this PR only changes how the delegate account ID flows internally.
No user-facing copy was added or modified (no changes to src/languages/*).
No UI components, feature names, tab names, settings labels, or buttons changed.
All changed files are internal TypeScript logic plus one test file (tests/actions/ReportTest.ts).

Since no behavior visible to end users changed, the Copilot help articles under App/docs/articles already reflect the current behavior and need no updates. No draft PR was created.

@Krishna2323, if you believe a user-facing behavior here is undocumented or changed, reply with the specifics and I'll re-evaluate and open a docs PR.

OSBotify · 2026-06-02T23:50:30Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.94-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned Krishna2323 May 16, 2026

Krishna2323 changed the title ~~Add delegateAccountIDParam to IOU + ReportPreview builders and thread through action helpers~~ Part 9 - Add delegateAccountIDParam to IOU + ReportPreview builders and thread through action helpers May 16, 2026

Krishna2323 marked this pull request as ready for review May 17, 2026 00:23

Krishna2323 requested review from a team as code owners May 17, 2026 00:23

melvin-bot Bot requested review from DylanDylann and flaviadefaria May 17, 2026 00:23

melvin-bot Bot removed request for a team May 17, 2026 00:23

Krishna2323 mentioned this pull request May 17, 2026

Remove Onyx.connect() for the key: ONYXKEYS.ACCOUNT in src/libs/ReportUtils.ts #66425

Open

Krishna2323 added 2 commits May 19, 2026 22:37

Add delegateAccountIDParam to IOU + ReportPreview builders and thread…

c6854e1

… through action helpers Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Add TODO comments with PR numbers to optional delegateAccountID type …

1f90783

…declarations Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 force-pushed the krishna2323/issue/66425-part-9 branch from c8ed60b to 1f90783 Compare May 19, 2026 17:08

Krishna2323 added 2 commits May 21, 2026 04:35

Merge branch 'main' into krishna2323/issue/66425-part-9

8749e51

Fix merge conflict in ReportTest.ts delegateAccountID tests

cd09671

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/66425-part-9

b087992

DylanDylann reviewed May 27, 2026

View reviewed changes

Comment thread src/libs/actions/Report/index.ts Outdated

Krishna2323 added 2 commits May 27, 2026 11:12

Merge upstream/main and resolve conflicts

f02a919

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Pass delegateAccountIDParam explicitly.

8a33671

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'main' into krishna2323/issue/66425-part-9

ce7daab

DylanDylann reviewed May 28, 2026

View reviewed changes

Comment thread .gitignore Outdated

Krishna2323 added 2 commits May 28, 2026 15:27

Merge branch 'Expensify:main' into krishna2323/issue/66425-part-9

6d4fa70

Remove .cursor/ from .gitignore

04bb2d0

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

DylanDylann approved these changes May 29, 2026

View reviewed changes

melvin-bot Bot requested a review from madmax330 May 29, 2026 13:48

madmax330 approved these changes May 29, 2026

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/66425-part-9

4fe7705

madmax330 merged commit 0257549 into Expensify:main Jun 1, 2026
30 checks passed

OSBotify mentioned this pull request Jun 2, 2026

Deploy Checklist: New Expensify 2026-06-02 #92309

Closed

75 tasks

Uh oh!

Conversation

Krishna2323 commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 16, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Krishna2323 commented May 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 17, 2026

Uh oh!

melvin-bot Bot commented May 17, 2026

Uh oh!

Krishna2323 commented May 21, 2026

Uh oh!

Krishna2323 commented May 25, 2026

Uh oh!

DylanDylann commented May 27, 2026

Uh oh!

DylanDylann commented May 27, 2026

Uh oh!

Uh oh!

Krishna2323 commented May 27, 2026

Uh oh!

Uh oh!

DylanDylann commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 28, 2026

Uh oh!

DylanDylann commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Jun 1, 2026

Uh oh!

Uh oh!

OSBotify commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

OSBotify commented Jun 2, 2026

Uh oh!

MelvinBot commented Jun 2, 2026

Uh oh!

OSBotify commented Jun 2, 2026

Uh oh!

MelvinBot commented Jun 2, 2026

Uh oh!

OSBotify commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Krishna2323 commented May 16, 2026 •

edited

Loading

codecov Bot commented May 16, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented May 28, 2026 •

edited

Loading