-
Notifications
You must be signed in to change notification settings - Fork 4k
Docs updates for E/A#87928 Unified private personal details form with magic code #90803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,8 +18,9 @@ The name on your Expensify Card is pulled from the legal name in your profile. T | |
| 1. Choose **Account** in the navigation tabs (on the left on web, on the bottom on mobile). | ||
| 2. Select **Profile**. | ||
| 3. Under **Private**, select **Legal name**. | ||
| 4. Update your **Legal first name** and **Legal last name**. | ||
| 4. Update your **Legal first name** and **Legal last name** on the personal details form. | ||
| 5. Click **Save**. | ||
| 6. Enter the magic code sent to your primary contact method to confirm the update. | ||
|
|
||
| Your updated legal name will apply to your Expensify Card. To get a new physical card with the updated name embossed on it, [request a replacement card](/articles/new-expensify/expensify-card/How-to-Request-a-New-Expensify-Card). | ||
|
|
||
|
|
@@ -32,7 +33,8 @@ The phone number linked to your Expensify Card is used for 3D Secure (Verified b | |
| 1. Choose **Account** in the navigation tabs (on the left on web, on the bottom on mobile). | ||
| 2. Select **Profile**. | ||
| 3. Under **Private**, select **Phone number**. | ||
| 4. Enter your updated phone number and click **Save**. | ||
| 4. Update your phone number on the personal details form and click **Save**. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Naming and style: Same as above -- "on the personal details form" is not a verified UI label. Per HELPSITE_NAMING_CONVENTIONS.md, reference exact UI text. If the UI does not display this phrase, remove it or replace it with the actual label shown in the product. |
||
| 5. Enter the magic code sent to your primary contact method to confirm the update. | ||
|
|
||
| After updating, your new phone number will be used for future 3D Secure SMS verification codes. | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,17 +116,19 @@ High contrast mode works with any base theme (light, dark, or device settings). | |
|
|
||
| ## Personal Information | ||
|
|
||
| To update legal details like name, date of birth, and address: | ||
| To update legal details like name, date of birth, phone number, and address: | ||
| 1. Go to **Account > Profile**. | ||
| 2. Scroll to the **Private Details** section. | ||
| 3. Update the **Legal Name**, **Date of Birth**, or **Address** fields. | ||
| 2. Under **Private**, select any field (**Legal name**, **Date of birth**, **Phone number**, or **Address**). | ||
| 3. Update the fields you want to change on the unified personal details form. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Naming and style: "unified personal details form" is not an exact UI label. Per HELPSITE_NAMING_CONVENTIONS.md, do not invent or generalize UI element names. Use the exact text shown in the product. Consider simplifying to something like: "Update the relevant fields." or reference the actual UI label if one exists. |
||
| 4. Click **Save**. | ||
| 5. If any field was changed, enter the magic code sent to your primary contact method to confirm the update. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Readability / structure: "If any field was changed" introduces unnecessary conditionality. The user just performed the update in the preceding steps, so this step will always apply. Per HELPSITE_NAMING_CONVENTIONS.md (Deterministic Writing Rule), be literal and avoid hedging. Consider rephrasing to: "Enter the magic code sent to your primary contact method to confirm the update." |
||
|
|
||
| ## Display or Legal Name | ||
|
|
||
| To edit your display or legal name: | ||
| 1. Go to **Account > Profile**. | ||
| 2. For display name: Click **Display Name**, enter your preferred name, and click **Save**. | ||
| 3. For legal name: Scroll to **Private Details**, click **Legal Name**, update it, and click **Save**. | ||
| 3. For legal name: Under **Private**, select **Legal name**, update it on the personal details form, click **Save**, and enter the magic code to confirm. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Readability / structure: This step chains too many actions into a single numbered step (select, update, save, enter magic code). Per HELP_AUTHORING_GUIDELINES.md Section 5, steps must be sequential, clear, and action-oriented. Break this into separate numbered steps, similar to how the "Personal Information" section above handles it. Also, "on the personal details form" is not a verified UI label (same naming concern flagged above). |
||
|
|
||
| --- | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.