Fix Intacct export action links - #90767
neil-marcellini merged 3 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
08c2070 to
ca06208
Compare
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@KJ21-ENG Add vids for all platforms and fix the QA steps. QA steps should be steps that user would be in app to test this PR (non-technical). |
ca06208 to
4235f95
Compare
|
Do not force push @KJ21-ENG. use merge commits. |
Apologies, i will keep note of this in future. |
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks good, thanks
|
@KJ21-ENG please merge main to fix the failing test that is not related |
…intacct-export-links
|
Kind ping here. Thanks |
|
@parasharrajat @trjExpensify @neil-marcellini |
|
@neil-marcellini will need to push the button. |
neil-marcellini
left a comment
There was a problem hiding this comment.
Sorry, this was grayed out in my dashboard for some reason
|
🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@KJ21-ENG in the feature please re-request a review from me in GH instead of tagging me and it will show up in my dashboard. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.80-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a bug fix that corrects how export action links render in the report history for Sage Intacct/Intacct/QBD integrations. No user-facing text was added or changed, and no new features or workflows were introduced. The existing help site articles on these integrations don't document report action link behavior, so no updates are needed. |
|
@KJ21-ENG @parasharrajat @trjExpensify
|
|
@neil-marcellini @KJ21-ENG @parasharrajat can you please make sure to handle the QA or ask someone who can test this? |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀
|
|
I've got a customer in this issue that can QA it. We'll ask. |


Explanation of Change
Prevents the export action renderer from assigning QBO's default expenses URL when Intacct, Sage Intacct, or QBD export actions contain multiple company card identifiers instead of URLs. These integrations store IDs in
nonReimbursableUrls, so the company card export fragment should render as plain text.Fixed Issues
$ #90386
PROPOSAL: #90386 (comment)
Tests
EXPORTINTEGRATIONreport action on local dev.originalMessage.labelisIntacctand whoseoriginalMessage.nonReimbursableUrlscontains multiple ID values, for example["SI-123", "SI-456"].exported to Intacct and successfully created a record for company card expenses.company card expensesis plain text and does not link to QBO/Intuit.Automated checks run locally:
nice -n 15 npx prettier --check src/libs/ReportActionsUtils.ts tests/unit/ReportActionsUtilsTest.tsnice -n 15 ./scripts/lint.sh src/libs/ReportActionsUtils.ts tests/unit/ReportActionsUtilsTest.tsnice -n 15 npm run test -- tests/unit/ReportActionsUtilsTest.ts --runInBandnice -n 15 env GOMAXPROCS=2 npm run typecheck-tsgo- fails only on unrelated existing GPS/map typing errors insrc/components/MapView/utils.tsandsrc/libs/migrations/ConvertGpsPointsTo2DArray.ts.Offline tests
This is a render-only change for already-synced report action data. After loading the report action once, turn the network offline and verify the same Intacct company card export text remains plain text with no QBO/Intuit link.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native_1779106573082965.mp4
Android: mWeb Chrome
mweb_1779063267491015.mp4
iOS: Native
ios_native_1779100766939955.mp4
iOS: mWeb Safari
mweb_ios_1779064134624515.mp4
MacOS: Chrome / Safari
1778854543844680.mp4