Skip to content

Fix Intacct export action links - #90767

Merged
neil-marcellini merged 3 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/fix-90386-intacct-export-links
May 22, 2026
Merged

neil-marcellini merged 3 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/fix-90386-intacct-export-links

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented May 15, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Prevents the export action renderer from assigning QBO's default expenses URL when Intacct, Sage Intacct, or QBD export actions contain multiple company card identifiers instead of URLs. These integrations store IDs in nonReimbursableUrls, so the company card export fragment should render as plain text.

Fixed Issues

$ #90386
PROPOSAL: #90386 (comment)

Tests

  1. Open a report with an EXPORTINTEGRATION report action on local dev.
  2. Use an action whose originalMessage.label is Intacct and whose originalMessage.nonReimbursableUrls contains multiple ID values, for example ["SI-123", "SI-456"].
  3. Verify the report history shows exported to Intacct and successfully created a record for company card expenses.
  4. Verify company card expenses is plain text and does not link to QBO/Intuit.
  5. Verify the URL-based multi-record case still renders a link by using a Xero export action with multiple company card records.
  6. Verify that no errors appear in the JS console.

Automated checks run locally:

  1. nice -n 15 npx prettier --check src/libs/ReportActionsUtils.ts tests/unit/ReportActionsUtilsTest.ts
  2. nice -n 15 ./scripts/lint.sh src/libs/ReportActionsUtils.ts tests/unit/ReportActionsUtilsTest.ts
  3. nice -n 15 npm run test -- tests/unit/ReportActionsUtilsTest.ts --runInBand
  4. nice -n 15 env GOMAXPROCS=2 npm run typecheck-tsgo - fails only on unrelated existing GPS/map typing errors in src/components/MapView/utils.ts and src/libs/migrations/ConvertGpsPointsTo2DArray.ts.

Offline tests

This is a render-only change for already-synced report action data. After loading the report action once, turn the network offline and verify the same Intacct company card export text remains plain text with no QBO/Intuit link.

QA Steps

  1. Open the app and sign in with an account that has a workspace connected to Sage Intacct.
  2. Open the workspace expense reports.
  3. Open a report with at least two company card expenses exported to Sage Intacct.
  4. In the report history, find the Sage Intacct export message.
  5. Verify the company card expenses text is plain text and does not open a QuickBooks or Intuit page when selected.
  6. Open a report with company card expenses exported to QuickBooks Online.
  7. Verify the company card expenses link opens the QuickBooks Online expenses page.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_native_1779106573082965.mp4
Android: mWeb Chrome
mweb_1779063267491015.mp4
iOS: Native
ios_native_1779100766939955.mp4
iOS: mWeb Safari
mweb_ios_1779064134624515.mp4
MacOS: Chrome / Safari
1778854543844680.mp4

@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/ReportActionsUtils.ts 77.31% <100.00%> (+0.60%) ⬆️
... and 10 files with indirect coverage changes

@KJ21-ENG
KJ21-ENG force-pushed the KJ21-ENG/fix-90386-intacct-export-links branch 2 times, most recently from 08c2070 to ca06208 Compare May 15, 2026 23:30
@KJ21-ENG
KJ21-ENG marked this pull request as ready for review May 15, 2026 23:36
@KJ21-ENG
KJ21-ENG requested review from a team as code owners May 15, 2026 23:36
@melvin-bot

melvin-bot Bot commented May 15, 2026

Copy link
Copy Markdown

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from a team and neil-marcellini and removed request for a team May 15, 2026 23:36
@melvin-bot

melvin-bot Bot commented May 15, 2026

Copy link
Copy Markdown

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team May 15, 2026 23:36
Comment thread src/libs/ReportActionsUtils.ts Outdated
@parasharrajat

parasharrajat commented May 17, 2026

Copy link
Copy Markdown
Member

Screenshots

🔲 iOS / native

App crashing issues - unrelated

🔲 iOS / Safari

image

🔲 MacOS / Chrome

image

🔲 Android / native

App crashing issues - unrelated

@parasharrajat

Copy link
Copy Markdown
Member

@KJ21-ENG Add vids for all platforms and fix the QA steps. QA steps should be steps that user would be in app to test this PR (non-technical).

@KJ21-ENG
KJ21-ENG force-pushed the KJ21-ENG/fix-90386-intacct-export-links branch from ca06208 to 4235f95 Compare May 17, 2026 18:44
@parasharrajat

Copy link
Copy Markdown
Member

Do not force push @KJ21-ENG. use merge commits.

Comment thread src/libs/ReportActionsUtils.ts
@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

Do not force push @KJ21-ENG. use merge commits.

Apologies, i will keep note of this in future.

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

@neil-marcellini neil-marcellini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@neil-marcellini

Copy link
Copy Markdown
Contributor

@KJ21-ENG please merge main to fix the failing test that is not related

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! 👍

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

Kind ping here. Thanks

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

@parasharrajat @trjExpensify @neil-marcellini
Kind ping here. Thanks

@trjExpensify

Copy link
Copy Markdown
Contributor

@neil-marcellini will need to push the button.

@neil-marcellini neil-marcellini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this was grayed out in my dashboard for some reason

@neil-marcellini
neil-marcellini merged commit 660202b into Expensify:main May 22, 2026
38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@neil-marcellini

Copy link
Copy Markdown
Contributor

@KJ21-ENG in the feature please re-request a review from me in GH instead of tagging me and it will show up in my dashboard.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.80-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR.

This is a bug fix that corrects how export action links render in the report history for Sage Intacct/Intacct/QBD integrations. No user-facing text was added or changed, and no new features or workflows were introduced. The existing help site articles on these integrations don't document report action link behavior, so no updates are needed.

@kavimuru

Copy link
Copy Markdown

@KJ21-ENG @parasharrajat @trjExpensify
I think applause can't test this step, could this be verified internally?

Open a report with at least two company card expenses exported to Sage Intacct.

@mountiny

Copy link
Copy Markdown
Contributor

@neil-marcellini @KJ21-ENG @parasharrajat can you please make sure to handle the QA or ask someone who can test this?

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@johncschuster

Copy link
Copy Markdown
Contributor

I've got a customer in this issue that can QA it. We'll ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants