Skip to content

auto-sign in with sign in link in separate browser - #90488

Merged
blimpich merged 21 commits into
Expensify:mainfrom
mukhrr:fix/89545
Jun 15, 2026
Merged

blimpich merged 21 commits into
Expensify:mainfrom
mukhrr:fix/89545

Conversation

@mukhrr

@mukhrr mukhrr commented May 13, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #89545
PROPOSAL: #89545 (comment)

Tests

  1. Log in with existing account and request magic code
  2. Navigate to email and locate the magic link - change to staging if needed
  3. Open an new INCOGNITO window and navigate to the staging link
  4. Verify the "Here's your magic code" page is displayed
  5. Verify there's a link to "Just sign In here"
  6. Click the link
  • Verify you are in Home page

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native web specific fix
Android: mWeb Chrome
android_web.mp4
iOS: Native web specific fix
iOS: mWeb Safari
ios_web.mp4
MacOS: Chrome / Safari
web.mp4

@mukhrr
mukhrr requested review from a team as code owners May 13, 2026 12:15
@melvin-bot
melvin-bot Bot requested review from DylanDylann and trjExpensify and removed request for a team May 13, 2026 12:15
@melvin-bot

melvin-bot Bot commented May 13, 2026

Copy link
Copy Markdown

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team May 13, 2026 12:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b9d213285

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/ValidateLoginPage/index.website.tsx Outdated
@mukhrr
mukhrr marked this pull request as draft May 13, 2026 13:12

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ccdd6e18a5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/ValidateLoginPage/index.web.tsx Outdated
@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...s/Navigation/helpers/getStateToResetAfterLogout.ts 100.00% <100.00%> (ø)
src/pages/ValidateLoginPage/index.web.tsx 100.00% <100.00%> (+2.63%) ⬆️
src/libs/Navigation/AppNavigator/AppNavigator.tsx 0.00% <0.00%> (ø)
src/libs/Navigation/NavigationRoot.tsx 76.00% <66.66%> (-2.00%) ⬇️
... and 107 files with indirect coverage changes

trjExpensify
trjExpensify previously approved these changes May 13, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we talked about this one on the parent issue. 👍

@DylanDylann

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 859c304e5a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/ValidateLoginPage/index.web.tsx Outdated
@DylanDylann

Copy link
Copy Markdown
Contributor

@mukhrr Ohh wait. Could you reproduce the bug on main?

@mukhrr

mukhrr commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

@DylanDylann yes

}, []);

useEffect(() => {
if (!!login || !cachedAccountID || !is2FARequired) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove this condition?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition wasn't removed, it was split across two effects to satisfy Codex's earlier "don't reschedule exitTo" feedback #90488 (comment)


// The user clicked the option to sign in the current tab
useEffect(() => {
if (exitTo || login) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the login condition here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

login being set means this browser initiated the login → there's an original tab, handled by the existing isUserClickedSignIn goBack flow + JustSignedInModal. The HOME redirect must only fire when login is empty (fresh/incognito, no original tab). Without the login guard we'd hijack the normal "head back to your original tab" flow.

@DylanDylann

Copy link
Copy Markdown
Contributor

BUG 1: The white screen is displayed between two loading indicators

BUG 2: After signing out, the app returns to the magic code screen

Screen.Recording.2026-05-18.at.14.56.04.mov

@mukhrr

mukhrr commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

BUG 1: The white screen is displayed between two loading indicators

Fixed bug 1. working on the 2nd one which is a bit tricky to fix

BUG 2: After signing out, the app returns to the magic code screen

@mkhutornyi

mkhutornyi commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android.mov
Android: mWeb Chrome
iOS: HybridApp
ios.mov
iOS: mWeb Safari
msafari.mov
MacOS: Chrome / Safari
web.mov

@mkhutornyi

Copy link
Copy Markdown
Contributor

btw, just fyi, separate-session 2FA has bug on both Staging and NewDot.

  1. Go to the sign-in page, enter the 2FA account's email → this emails the magic-code link https://new.expensify.com/v//.
  2. Open a fresh incognito window.
  3. Paste/open the /v/... link there.
  4. Click "Just sign in here".
  5. Observe: blank page (spinner never resolves into anything, no 2FA prompt).

Expected: Two-factor authentication required Page image

Actual: Blank page:

REC-20260602090546.mp4

I think the expected behavior is to show enter 2FA code page instead of 2FA required page as link already expired and never able to proceed on first-trying-to-sign-in browser.
Let's not block on this as already broken on production.

msafari.mov

Expected:

Screenshot 2026-06-14 at 12 24 11 PM

This PR:

Screenshot 2026-06-14 at 12 25 16 PM

@mkhutornyi

Copy link
Copy Markdown
Contributor

I tested as many cases as possible but still be on a look out for any blockers.

@melvin-bot
melvin-bot Bot requested a review from blimpich June 14, 2026 11:30
@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 MelvinBot — regression re-review

Verdict: No new blocking correctness bugs. Prior review comments look addressed (the getStateToResetAfterLogout justification was reworded correctly, and the separate-session 2FA + Back-button regressions are fixed). Below are the possible regressions worth confirming in QA, ordered by blast radius.

1. AppNavigator Suspense fallback — highest blast radius (ALL platforms)

AppNavigator.tsx changes the fallback from null to a full-screen LoadingIndicator (absoluteFillObject + fullScreenLoading: componentBG @ opacity: 0.8, zIndex: 10). This now renders on every AuthScreens/PublicScreens lazy-chunk resolution — not just the sign-in swap. On native the chunk is bundled (resolves fast), and the web prefetch usually masks it, but a slow cold web load or sign-out could now show a loader flash where it was previously blank. Make sure B1 (no flash on cold start) and B4 (no flash on logout → PublicScreens) genuinely pass on throttled web.

2. isUserClickedSignIn redirect: goBack() → focus-effect navigate(HOME, {forceReplace})

The redirect moved from a mount-only goBack() to a useFocusEffect that fires on every focus while isUserClickedSignIn is true. Correct for the fresh-window target (nowhere to go back to), but note the behavior change:

  • After a separate-session sign-in, login is never cached and autoAuthState stays JUST_SIGNED_IN, so isUserClickedSignIn stays true. The user can therefore no longer revisit /v/... to view the code — any focus bounces them to HOME. Acceptable, but a real behavior change from the old goBack.
  • Confirm A1.2 (Back ≠ /v/) doesn't produce a navigate loop if forceReplace is downgraded to a push.

3. Signed-in "view the code" path is sensitive to autoAuthState

isUserClickedSignIn is !login && isSignedIn && (SIGNING_IN || JUST_SIGNED_IN). A2.2 passes because autoAuthState is NOT_STARTED. But a signed-in user with no cached login who opens /v/... while their session's autoAuthState is still JUST_SIGNED_IN (lingering from a recent magic-link sign-in) would be redirected HOME instead of seeing ValidateCodeModal. Narrow edge — flagging for awareness, not blocking.

4. Permanent spinner is still reachable by design

When isCompletingDirectSignIn is true but authToken never lands (stuck case), the loader stays up indefinitely and only a 30s Log.alert fires — observability only, no recovery UX. This matches the pre-existing production behavior the team chose not to block on, but it is a permanent spinner with no user-facing timeout/error. Worth a product confirm.

Things I checked that are NOT regressions
  • 2FA separate-session: dropping !!login from the 2FA modal guard correctly surfaces the 2FA prompt for fresh sessions; isCompletingDirectSignIn's !is2FARequired guard prevents an infinite loader. During the SIGNING_IN phase the existing === SIGNING_IN loader branch still shows (no blank gap).
  • NavigationRoot try/catch fallback: Log is imported; on a rejected reset it falls back to {index:0, routes:[{name: HOME}]} — no blank screen. ✅
  • getStateToResetAfterLogout: preserves the old logout behavior (clear params only for REPORTS_SPLIT_NAVIGATOR, preserve TRANSITION_BETWEEN_APPS params) and adds VALIDATE_LOGIN → HOME. Unit tests cover all branches.
  • Static review only — I couldn't execute the Jest suite here, so rely on CI for the green check.

This is an automated re-review from MelvinBot — a second set of eyes, not a substitute for human review.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e18daffab5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/ValidateLoginPage/index.web.tsx
@mukhrr

mukhrr commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

I think the expected behavior is to show enter 2FA code page instead of 2FA required page as link already expired and never able to proceed on first-trying-to-sign-in browser.

This makes sense to me. Let's just confirm it cc @trjExpensify

@trjExpensify

Copy link
Copy Markdown
Contributor

Yes, I would think if the user clicks "Just sign in here" and has 2FA enabled, we would then show them the 2FA entry screen prior to navigating into the product. CC: @NikkiWines do you agree with that?

@NikkiWines

Copy link
Copy Markdown
Contributor

Yep, that makes sense to me 👍

@blimpich
blimpich merged commit 1620216 into Expensify:main Jun 15, 2026
35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mukhrr

mukhrr commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Just sign in here" and has 2FA enabled, we would then show them the 2FA entry screen prior to navigating into the product

Oh @blimpich i had not pushed this yet) can I still push here?

@mukhrr

mukhrr commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Or ideally can we a separate issue for that ? cc @trjExpensify

@trjExpensify

Copy link
Copy Markdown
Contributor

This PR is now merged, so you can't. Please prepare another PR so we can follow-up with that. 👍

@mukhrr

mukhrr commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

This PR is now merged, so you can't. Please prepare another PR so we can follow-up with that. 👍

Here is it is #93656! cc @mkhutornyi

@blimpich

Copy link
Copy Markdown
Contributor

Ah that's my bad, I misunderstood and thought the behavior had already been implemented and you were just asking for confirmation that it was indeed the correct behavior 🙁

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.9-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no changes required

I reviewed the changes in this PR against the help site articles under docs/articles and concluded no help site updates are needed.

Why

This PR is a bug fix for issue #89545 — "Blank page opens when login via magic link different session." The changes are entirely internal navigation/loading behavior:

This restores the already-expected behavior (the user should log in) rather than introducing or changing any user-facing feature, setting, label, or workflow. The existing Login Troubleshooting article documents login problems at the appropriate level and doesn't describe this blank-page bug as expected behavior, so nothing there needs to change.

Because no documentation changes are required, I did not open a draft help site PR.

@mukhrr, please confirm you agree that no help site changes are needed here. If you believe a doc update is warranted, let me know what behavior should be documented and I'll create the draft PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93753 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93758 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.9-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants