Skip to content

Fix held expenses auto-approved without hold modal in selection mode #87651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 4 commits into from
Apr 10, 2026
Merged

Fix held expenses auto-approved without hold modal in selection mode #87651

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90a84dd
Fix held expenses auto-approved without hold modal in selection mode
Krishna2323 Apr 10, 2026
3b56852
Defer hold menu opening in selection mode approve/pay to fix modal mo…
Krishna2323 Apr 10, 2026
0c4f625
fix: pass reactive transactions to hasHeldExpenses to prevent stale h…
Krishna2323 Apr 10, 2026
ef05e9d
Revert InteractionManager workaround, keep reactive transactions fix
Krishna2323 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hooks/useSelectionModeReportActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ function useSelectionModeReportActions({
const shouldBlockSubmit = isBlockSubmitDueToStrictPolicyRules || isBlockSubmitDueToPreventSelfApproval;

const canAllowSettlement = hasUpdatedTotal(report, policy);
const isAnyTransactionOnHold = hasHeldExpensesReportUtils(report?.reportID);
const isAnyTransactionOnHold = hasHeldExpensesReportUtils(report?.reportID, transactions);
const isInvoiceReport = isInvoiceReportUtil(report);

const hasOnlyPendingTransactions = !!transactions && transactions.length > 0 && transactions.every((t) => isExpensifyCardTransaction(t) && isPending(t));
Expand Down Expand Up @@ -556,7 +556,7 @@ function useSelectionModeReportActions({
canAllowSettlement,
isAnyTransactionOnHold,
isInvoiceReport,
hasOnlyHeldExpenses: hasOnlyHeldExpensesReportUtils(report?.reportID),
hasOnlyHeldExpenses: hasOnlyHeldExpensesReportUtils(report?.reportID, transactions),
nonHeldAmount,
fullAmount,
hasValidNonHeldAmount,
Expand Down
Loading