fix network state detection - #84760

Merged

mjasikowski merged 92 commits into

Expensify:mainfrom

callstack-internal:fix-network-state-detection

Apr 16, 2026

Commits on Mar 10, 2026

Replace RecheckConnection with three-layer network state detection

adhorodyski
and
claude
committed
bec4576
Add network state detection architecture documentation

adhorodyski
and
claude
committed
c4da67a
Skip recovery probe when shouldForceOffline is active

adhorodyski
and
claude
committed
55f5611
Move NetInfo subscription to module-level Onyx connection

adhorodyski
and
claude
committed
8b5dade
Fix app staying offline after radio reconnects on web

adhorodyski
and
claude
committed
5bae3f4
Rename noRadioActive to hasRadio for clarity

adhorodyski
and
claude
committed
19bdd69
Remove RecoveryProbe, use NetInfo built-in reachability polling

adhorodyski
and
claude
committed
8e86328
Merge remote-tracking branch 'exfy/main' into fix-network-state-detection
adhorodyski
committed
437ef5b
Break FailureTracker→NetworkState cycle, reset counters on recovery

adhorodyski
and
claude
committed
06c34eb
Remove unused hardStopReason from Network type

adhorodyski
and
claude
committed
7fa78e3
Reconnect after re-authentication, add FailureTracker tests

adhorodyski
and
claude
committed
87182a5

Commits on Mar 11, 2026

Merge remote-tracking branch 'exfy/main' into fix-network-state-detection
adhorodyski
committed
7bc1627
Fix docs: useNativeReachability is false, not true

adhorodyski
and
claude
committed
840fe1a
Merge reset() and resetCounters() into single reset()

adhorodyski
and
claude
committed
62d5e81
Fix CI failures: migrate tests to NetworkState and fix lint/type errors

adhorodyski
and
claude
committed
2c051d3
Merge branch 'Expensify:main' into fix-network-state-detection
adhorodyski
authored
087c984

Commits on Mar 13, 2026

Fix CI failures: resolve SQ flush timing and promise resolution bugs

adhorodyski
and
claude
committed
1241e66
Fix CI: use microtask deferral instead of setTimeout in unpause()

adhorodyski
and
claude
committed
3bebb5a

Commits on Mar 18, 2026

Merge remote-tracking branch 'exfy/main' into fix-network-state-detection
adhorodyski
committed
a687e9d
add missing eslint-disable justifications
adhorodyski
committed
c7867d1
Remove microtask flush deferral — root cause fixed in PersistedRequests

adhorodyski
and
claude
committed
8025769
Guard initAppForegroundListener against double-registration

adhorodyski
and
claude
committed
800732f
Fix flaky APITest by awaiting Onyx merge from setHasRadio

adhorodyski
and
claude
committed
0598e72

Commits on Mar 19, 2026

Commits on Mar 20, 2026

Make isOffline synchronous via NetworkState module-level state

adhorodyski
and
claude
committed
7f67d35
Merge remote-tracking branch 'exfy/main' into fix-network-state-detection
adhorodyski
committed
036abe4
Split SequentialQueue process() early returns for paused and offline

adhorodyski
and
claude
committed
ca68a32
Split SequentialQueue flush() early returns for paused and offline

adhorodyski
and
claude
committed
12dd164
Fix FailureTracking: any server response should reset failure counter

adhorodyski
and
claude
committed
d51258e
Document thundering herd protection and fix stale file references

adhorodyski
and
claude
committed
8eb451c
Fix lastOfflineAt to only set on transition to offline

adhorodyski
and
claude
committed
684790a
Skip unnecessary broadcasts in FailureTracker.recordSuccess()

adhorodyski
and
claude
committed
82d9892
Document per-tab offline detection behavior

adhorodyski
and
claude
committed
777ea0d
Restore isOffline guard in SequentialQueue.push()

adhorodyski
and
claude
committed
bb5e511
Merge remote-tracking branch 'exfy/main' into fix-network-state-detection
adhorodyski
committed
496d75e
Track real NetInfo state even when shouldForceOffline is active

adhorodyski
and
claude
committed
3357541
Skip reconnect when signed out to avoid unnecessary API calls

adhorodyski
and
claude
committed
e14eb73
Fix Prettier formatting in useNetwork.ts

adhorodyski
and
claude
committed
9064555
Rename isOffline to getIsOffline in NetworkState to fix no-shadow ESLint errors

adhorodyski
and
claude
committed
d3d9cb3

Commits on Mar 23, 2026

Remove Log import from FailureTracker to break circular dependency

adhorodyski
and
claude
committed
2bbaa5e
Merge branch 'Expensify:main' into fix-network-state-detection
adhorodyski
authored
db5259f
Remove unused onReachabilityRestored export from NetworkState

adhorodyski
and
claude
committed
6184cf3
Merge remote-tracking branch 'origin/fix-network-state-detection' into fix-network-state-detection
adhorodyski
committed
7caa761
Update NETWORK_STATE_DETECTION.md to match current architecture

adhorodyski
and
claude
committed
797912d
Revert MAX_RETRY_WAIT_TIME_MS back to 10s

adhorodyski
and
claude
committed
23c7e9a
Add unit tests for NetworkState hard stop state machine

adhorodyski
and
claude
committed
cf98821
Initialize NetInfo subscription before session is available

adhorodyski
and
claude
committed
5f55e52
Only treat false→true as genuine reachability recovery

adhorodyski
and
claude
committed
60be4bd
Notify reconnect listeners when sustained failures clear

adhorodyski
and
claude
committed
3319af6

Commits on Mar 24, 2026

Fix stale offline flags on sign-out and simulation toggle

adhorodyski
and
claude
committed
6bd69cf
Fix circular dependency breaking memoize and remove stale test mock

adhorodyski
and
claude
committed
5f14326
Consolidate offline→online flush in Reconnect.ts

adhorodyski
and
claude
committed
2f8a936
Merge branch 'Expensify:main' into fix-network-state-detection
adhorodyski
authored
8ea4032
Fix docs to match implementation: 4 triggers, SQ/Reconnect roles, NetInfo defaults

adhorodyski
and
claude
committed
1df2e1a

Commits on Mar 25, 2026

Merge branch 'Expensify:main' into fix-network-state-detection
adhorodyski
authored
6d6d1b0

Commits on Mar 26, 2026

Merge branch 'Expensify:main' into fix-network-state-detection
adhorodyski
authored
ff8b148

Commits on Mar 27, 2026

Commits on Mar 30, 2026

Merge remote-tracking branch 'exfy/main' into fix-network-state-detection
adhorodyski
committed
881f763

Commits on Mar 31, 2026

Merge remote-tracking branch 'exfy/main' into fix-network-state-detection
adhorodyski
committed
8f83bf8

Commits on Apr 1, 2026

Commits on Apr 3, 2026

Merge branch 'exfy/main' into fix-network-state-detection

adhorodyski
and
claude
committed
1f3ce14
Remove unused DEFAULT_NETWORK_DATA

adhorodyski
and
claude
committed
5441316
Fix ONYXKEYS rename in SidebarFilterTest

adhorodyski
and
claude
committed
e48d53f

Commits on Apr 7, 2026

Merge branch 'exfy/main' into fix-network-state-detection

adhorodyski
and
claude
committed
45fe7e7
Merge branch 'exfy/main' into fix-network-state-detection

adhorodyski
and
claude
committed
4d95769

Commits on Apr 8, 2026

Commits on Apr 10, 2026

Commits on Apr 13, 2026

Fix shouldFailAllRequests not clearing sustained failure offline state

adhorodyski
and
claude
committed
180d61c
Merge branch 'Expensify:main' into fix-network-state-detection
adhorodyski
authored
7d88b1a
Add internetUnreachable hard stop for idle offline detection

adhorodyski
and
claude
committed
21dd515

Commits on Apr 14, 2026

Merge exfy/main into fix-network-state-detection

adhorodyski
and
claude
committed
af7d494

Commits on Apr 15, 2026

Remove unused 'macrotask' from cspell dictionary

adhorodyski
and
claude
committed
2a791e2
Fix internetUnreachable not firing when prevIsInternetReachable is null

adhorodyski
and
claude
committed
dbbdf23
Merge exfy/main into fix-network-state-detection

adhorodyski
and
claude
committed
0eacad5
Merge exfy/main into fix-network-state-detection

adhorodyski
and
claude
committed
acd6d9b
Add tests for foreground recovery, reachability confirmation, and stale failure window

adhorodyski
and
claude
committed
5328d3f
Fix namespace import lint error in ReconnectTest

adhorodyski
and
claude
committed
3ec4333

Commits on Apr 16, 2026

Merge branch 'Expensify:main' into fix-network-state-detection
adhorodyski
authored
e8db0bc