Skip to content

[NO QA]Fix zombie SPAN_NAVIGATE_TO_INBOX_TAB spans on Inbox tab re-visits #83187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JS00001 merged 1 commit into from
Feb 23, 2026
Merged

[NO QA]Fix zombie SPAN_NAVIGATE_TO_INBOX_TAB spans on Inbox tab re-visits #83187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/pages/inbox/sidebar/SidebarLinksData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,20 @@ function SidebarLinksData({insets}: SidebarLinksDataProps) {
currentReportIDRef.current = currentReportID;
const isActiveReport = useCallback((reportID: string): boolean => currentReportIDRef.current === reportID, []);

// IMPORTANT: Always end the telemetry navigation span for the Inbox tab when the screen gains focus.
// This must handle both the initial mount and all subsequent Inbox tab visits,
// as onLayout does not fire when navigating back to an already-mounted screen.
// Guards against ending the span before the first layout has completed.
const hasHadFirstLayout = useRef(false);
const onLayout = useCallback(() => {
hasHadFirstLayout.current = true;
endSpan(CONST.TELEMETRY.SPAN_NAVIGATE_TO_INBOX_TAB);
}, []);

// On re-visits, react-freeze serves the cached layout — onLayout never fires.
// useFocusEffect fires on unfreeze, which is when the screen becomes visible.
useFocusEffect(
useCallback(() => {
if (!hasHadFirstLayout.current) {
return;
}
endSpan(CONST.TELEMETRY.SPAN_NAVIGATE_TO_INBOX_TAB);
}, []),
);
Expand All @@ -45,6 +54,7 @@ function SidebarLinksData({insets}: SidebarLinksDataProps) {
collapsable={false}
accessibilityLabel={translate('sidebarScreen.listOfChats')}
style={[styles.flex1, styles.h100]}
onLayout={onLayout}
>
<SidebarLinks
// Forwarded props:
Expand Down
Loading