Skip to content

Add keyboard navigation support for autocomplete result rows - #82500

Merged
arosiclair merged 5 commits into
Expensify:mainfrom
MobileMage:fix/79621-keyboard-navigation-waypoints
Feb 27, 2026
Merged

Add keyboard navigation support for autocomplete result rows#82500
arosiclair merged 5 commits into
Expensify:mainfrom
MobileMage:fix/79621-keyboard-navigation-waypoints

Conversation

@MobileMage

@MobileMage MobileMage commented Feb 14, 2026 •
edited by arosiclair
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

The react-native-google-places-autocomplete library's row Pressable elements were not keyboard-focusable (missing tabIndex). When a user tabbed from the text input in the Track Distance waypoint flow, focus would leave the autocomplete container entirely. This triggered the onBlur handler in AddressSearch, which checks if the blur target is still inside the container via isCurrentTargetInsideContainer. Since the rows couldn't receive focus, the check returned false, hiding the suggestion list before any selection could occur.

This patch adds tabIndex={0}, accessible, and an onKeyDown handler (for Enter and Space) to the row Pressable in the library. This makes the rows keyboard-focusable, so when tabbing from the input, focus moves to a row inside the container, isCurrentTargetInsideContainer returns true, and the list stays visible for selection.

Fixed Issues

$ #79621
PROPOSAL: #79621 (comment)

Tests

  1. Navigate to the app on Web and click the FAB (+) button
  2. Tab to "Track distance" and press Enter
  3. Tab to the Start waypoint field and press Enter
  4. Type a location or wait for recent destinations to appear
  5. Press Tab to move focus to a suggestion row
  6. Verify the suggestion list remains visible and the row receives focus
  7. Press Enter or Space on the focused row
  8. Verify the waypoint is selected and you return to the Track Distance form with the address filled in
  9. Repeat for the Stop waypoint
  • Verify that no errors appear in the JS console

Offline tests

N/A - This change only affects keyboard focus behavior on autocomplete UI elements. The underlying network requests and offline handling are unchanged.

QA Steps

  1. Navigate to the app and click the FAB (+) button
  2. Tab to "Track distance" and press Enter
  3. Tab to the Start waypoint field and press Enter
  4. Type a location and wait for suggestions to appear
  5. Press Tab to move focus to a suggestion row
  6. Verify the suggestion list stays visible and the row is visually focused
  7. Press Enter or Space to select the suggestion
  8. Verify the waypoint is selected on the first attempt (no need to retry)
  9. Repeat for additional waypoints
  10. Verify entering a new waypoint and selecting via Tab + Enter works without errors on the first attempt
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
79621.mp4

@MobileMage
Add keyboard navigation support for autocomplete result rows
e279761 
The row Pressable elements in react-native-google-places-autocomplete
lacked tabIndex, making them unreachable via Tab key. When tabbing from
the text input, focus left the container, triggering onBlur which hid
the list before selection could occur. This patch adds tabIndex={0},
accessible, and an onKeyDown handler (Enter/Space) to make rows
keyboard-focusable and selectable.

Fixes Expensify#79621
@github-actions

github-actions Bot commented Feb 14, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@MobileMage
MobileMage marked this pull request as ready for review February 17, 2026 14:47
@MobileMage
MobileMage requested a review from a team as a code owner February 17, 2026 14:47
@melvin-bot
melvin-bot Bot requested review from brunovjk and removed request for a team February 17, 2026 14:47
@melvin-bot

melvin-bot Bot commented Feb 17, 2026

Copy link
Copy Markdown

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@brunovjk

brunovjk commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

@MobileMage I can still reproduce it:

Screen.Recording.2026-02-19.at.13.17.36.mov

Am I doing something wrong? can you reproduce it? Thank you.

@arosiclair

arosiclair commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

@MobileMage what is the status here? You've been very unresponsive on this issue. Let's finish this ASAP or you will unassigned

@MobileMage

MobileMage commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

The fix works when you use space in step 7 but not when you use enter.
I'm investigating to see if we can have both

@MobileMage

MobileMage commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Fixed now, take a look @brunovjk

Kapture.2026-02-24.at.19.18.42.mp4

@brunovjk

brunovjk commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-26.at.13.07.58.mov

brunovjk
brunovjk approved these changes Feb 26, 2026
View reviewed changes

@brunovjk brunovjk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good. @MobileMage @arosiclair should we include in the testing steps that this PR is only for Web Chrome/Safari? Thank you.

@melvin-bot
melvin-bot Bot requested a review from arosiclair February 26, 2026 16:10
@arosiclair

arosiclair commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Now it looks good. @MobileMage @arosiclair should we include in the testing steps that this PR is only for Web Chrome/Safari? Thank you.

Updated it

@arosiclair
arosiclair merged commit 5a125d4 into Expensify:main Feb 27, 2026
22 checks passed
@github-actions

github-actions Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82500.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5a125d4-2fc613e-16666bff18a8031571598e4c07e49a12231ca55d/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5a125d4-2fc613e-175cb6501979bf11721d985388ee013aafd88d04/index.html
Android iOS
Web 🕸️
https://82500.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify

OSBotify commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Feb 27, 2026
Closed
@OSBotify

OSBotify commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.27-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify OSBotify mentioned this pull request Feb 27, 2026
Closed
1 of 7 tasks
@lanitochka17 lanitochka17 mentioned this pull request Mar 2, 2026
Closed
1 of 7 tasks
@OSBotify

OSBotify commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@brunovjk brunovjk mentioned this pull request Mar 8, 2026
Closed
1 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arosiclair arosiclair arosiclair approved these changes
+1 more reviewer
@brunovjk brunovjk brunovjk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@MobileMage MobileMage

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MobileMage @brunovjk @arosiclair @OSBotify