Remove console and record troubleshoot data features - #82350
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…n config Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…nCompleteRecording Co-authored-by: Cursor <cursoragent@cursor.com>
|
@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…tive handlers, add sentryLabel, remove unused waitForNavigate Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddbdf9e92c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
Codecov Report❌ Patch coverage is
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
If requires C+ testing, I can help |
Delete the entire RecordTroubleshootDataToolMenu/ directory (15 files) and remove its import/usage from TroubleshootPage and TestToolsModalPage. Both pages still render TestToolMenu and other debug tools. Co-authored-by: Cursor <cursoragent@cursor.com>
Delete Troubleshoot.ts (recording orchestration) and ProfilingTool.ts (profiling toggle), which were exclusively consumed by the removed RecordTroubleshootDataToolMenu component. Remove shouldShowProfileTool from TestTool.ts along with its now-unused Browser imports. Remove three Onyx keys: APP_PROFILING_IN_PROGRESS, SHOULD_RECORD_TROUBLESHOOT_DATA, and TROUBLESHOOT_RECORDING_START_TIME. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…er dependencies These three packages were exclusively used by the removed RecordTroubleshootDataToolMenu and Troubleshoot action modules. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
I'll leave it up to @Julesssss and @rlinoz if they want C+ testing or not. Given that this is just removing a bunch of code, I'm not sure it's needed here. |
Delete the upload_dsyms and upload_dsyms_hybrid fastlane lanes that uploaded dSYM files to Firebase Crashlytics. Sentry handles debug symbol uploads via its own Xcode build phase and Gradle plugin. Also remove the "Upload DSYMs to Firebase for HybridApp" step from deploy.yml that called the now-deleted lane. Co-authored-by: Cursor <cursoragent@cursor.com>
…ipts
The release profiler was only used by the now-removed Record Troubleshoot
Data feature. This removes:
- react-native-release-profiler dependency
- scripts/release-profile.ts (local symbolication helper)
- scripts/symbolicate-profile.ts (remote artifact download + symbolication)
- npm scripts: symbolicate-release:{ios,android,web}, symbolicate-profile
Co-authored-by: Cursor <cursoragent@cursor.com>
rlinoz
left a comment
There was a problem hiding this comment.
Always good to remove so many lines 😌
I just have 1 question.
JmillsExpensify
left a comment
There was a problem hiding this comment.
No issues removing these from the product.
- Revert "Remove Firebase Crashlytics dSYM upload lanes and deploy step" since Crashlytics hasn't been fully removed yet - Remove SEARCH_CONTEXT_SHARE_LOG constant and its case in useSearchSelector (ShareLogList was deleted in this PR) Co-authored-by: Cursor <cursoragent@cursor.com>
|
all yours @Julesssss |
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # src/pages/settings/AboutPage/ShareLogList/BaseShareLogList.tsx
|
resolved conflicts |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
r## Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.21-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀
|
Explanation of Change
Removing the console page and record troubleshoot data feature as they're no longer used or needed. Slack threads:
Also created https://github.com/Expensify/Mobile-Expensify/pull/13850 for removing react-native-release-profiler.
Fixed Issues
related to https://github.com/Expensify/Expensify/issues/594140
Tests
Settings->Troubleshoot.Consoleoption.Record Troubleshoot Dataoption.Offline tests
None.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari