Skip to content

Remove console and record troubleshoot data features - #82350

Merged
Julesssss merged 24 commits into
mainfrom
Rory-RemoveConsolePage
Feb 17, 2026
Merged

Julesssss merged 24 commits into
mainfrom
Rory-RemoveConsolePage

Conversation

@roryabraham

@roryabraham roryabraham commented Feb 13, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Removing the console page and record troubleshoot data feature as they're no longer used or needed. Slack threads:

Also created https://github.com/Expensify/Mobile-Expensify/pull/13850 for removing react-native-release-profiler.

Fixed Issues

related to https://github.com/Expensify/Expensify/issues/594140

Tests

  1. Go to Settings -> Troubleshoot.
  2. Verify you don't see a Console option.
  3. Verify you don't see a Record Troubleshoot Data option.
  • Verify that no errors appear in the JS console

Offline tests

None.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari image

roryabraham and others added 10 commits February 12, 2026 18:18
…n config

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…nCompleteRecording

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham
roryabraham requested a review from rlinoz February 13, 2026 04:34
@roryabraham roryabraham self-assigned this Feb 13, 2026
@roryabraham
roryabraham requested review from a team as code owners February 13, 2026 04:34
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and Julesssss and removed request for a team February 13, 2026 04:34
@melvin-bot

melvin-bot Bot commented Feb 13, 2026

Copy link
Copy Markdown

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham and others added 2 commits February 12, 2026 20:39
…tive handlers, add sentryLabel, remove unused waitForNavigate

Co-authored-by: Cursor <cursoragent@cursor.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ddbdf9e92c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@roryabraham

Copy link
Copy Markdown
Contributor Author

@codex review

@codecov

codecov Bot commented Feb 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/pages/settings/Troubleshoot/TroubleshootPage.tsx 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/CONST/index.ts 87.39% <ø> (ø)
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/ROUTES.ts 12.86% <ø> (+0.12%) ⬆️
src/SCREENS.ts 100.00% <ø> (ø)
src/components/TestToolsModalPage.tsx 0.00% <ø> (ø)
src/hooks/useSearchSelector.base.ts 21.31% <ø> (ø)
src/libs/Log.ts 77.27% <100.00%> (-0.91%) ⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx 7.53% <ø> (-0.10%) ⬇️
src/libs/Navigation/AppNavigator/PublicScreens.tsx 100.00% <ø> (ø)
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts 100.00% <ø> (ø)
... and 3 more

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@situchan

Copy link
Copy Markdown
Contributor

If requires C+ testing, I can help

roryabraham and others added 4 commits February 12, 2026 23:58
Delete the entire RecordTroubleshootDataToolMenu/ directory (15 files) and
remove its import/usage from TroubleshootPage and TestToolsModalPage. Both
pages still render TestToolMenu and other debug tools.

Co-authored-by: Cursor <cursoragent@cursor.com>
Delete Troubleshoot.ts (recording orchestration) and ProfilingTool.ts
(profiling toggle), which were exclusively consumed by the removed
RecordTroubleshootDataToolMenu component. Remove shouldShowProfileTool
from TestTool.ts along with its now-unused Browser imports. Remove three
Onyx keys: APP_PROFILING_IN_PROGRESS, SHOULD_RECORD_TROUBLESHOOT_DATA,
and TROUBLESHOOT_RECORDING_START_TIME.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…er dependencies

These three packages were exclusively used by the removed
RecordTroubleshootDataToolMenu and Troubleshoot action modules.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham roryabraham changed the title Remove console and record troubleshoot data features [WIP] Remove console and record troubleshoot data features Feb 13, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@roryabraham roryabraham changed the title [WIP] Remove console and record troubleshoot data features Remove console and record troubleshoot data features Feb 13, 2026
@roryabraham

Copy link
Copy Markdown
Contributor Author

I'll leave it up to @Julesssss and @rlinoz if they want C+ testing or not. Given that this is just removing a bunch of code, I'm not sure it's needed here.

Comment thread contributingGuides/PERFORMANCE.md
roryabraham and others added 2 commits February 13, 2026 01:34
Delete the upload_dsyms and upload_dsyms_hybrid fastlane lanes that
uploaded dSYM files to Firebase Crashlytics. Sentry handles debug
symbol uploads via its own Xcode build phase and Gradle plugin.

Also remove the "Upload DSYMs to Firebase for HybridApp" step from
deploy.yml that called the now-deleted lane.

Co-authored-by: Cursor <cursoragent@cursor.com>
…ipts

The release profiler was only used by the now-removed Record Troubleshoot
Data feature. This removes:
- react-native-release-profiler dependency
- scripts/release-profile.ts (local symbolication helper)
- scripts/symbolicate-profile.ts (remote artifact download + symbolication)
- npm scripts: symbolicate-release:{ios,android,web}, symbolicate-profile

Co-authored-by: Cursor <cursoragent@cursor.com>

@rlinoz rlinoz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to remove so many lines 😌

I just have 1 question.

Comment thread .github/workflows/deploy.yml
Comment thread fastlane/Fastfile
Comment thread fastlane/Fastfile
Comment thread src/pages/settings/AboutPage/ShareLogList/BaseShareLogList.tsx

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues removing these from the product.

roryabraham and others added 2 commits February 13, 2026 11:15
- Revert "Remove Firebase Crashlytics dSYM upload lanes and deploy step"
  since Crashlytics hasn't been fully removed yet
- Remove SEARCH_CONTEXT_SHARE_LOG constant and its case in
  useSearchSelector (ShareLogList was deleted in this PR)

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham
roryabraham requested a review from rlinoz February 13, 2026 19:22
rlinoz
rlinoz previously approved these changes Feb 16, 2026
@rlinoz

rlinoz commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

all yours @Julesssss

Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	src/pages/settings/AboutPage/ShareLogList/BaseShareLogList.tsx
@roryabraham

Copy link
Copy Markdown
Contributor Author

resolved conflicts

@codecov

codecov Bot commented Feb 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 87.39% <ø> (ø)
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/ROUTES.ts 12.86% <ø> (+0.12%) ⬆️
src/SCREENS.ts 100.00% <ø> (ø)
src/components/TestToolsModalPage.tsx 0.00% <ø> (ø)
src/hooks/useSearchSelector.base.ts 21.31% <ø> (ø)
src/libs/Log.ts 77.27% <100.00%> (-0.91%) ⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx 7.53% <ø> (-0.10%) ⬇️
src/libs/Navigation/AppNavigator/PublicScreens.tsx 100.00% <ø> (ø)
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts 100.00% <ø> (ø)
... and 3 more
... and 14 files with indirect coverage changes

@rlinoz

rlinoz commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

r## Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Julesssss
Julesssss merged commit 6215336 into main Feb 17, 2026
43 of 44 checks passed
@Julesssss
Julesssss deleted the Rory-RemoveConsolePage branch February 17, 2026 19:40
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Feb 17, 2026
93 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.21-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants