Skip to content

fix: Amount over MYR 100,000,000.00/person limit appears and disappears after splitting expense #82226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 2 commits into from
Feb 17, 2026
Merged

fix: Amount over MYR 100,000,000.00/person limit appears and disappears after splitting expense #82226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1c0b99
fix: Amount over MYR 100,000,000.00/person limit appears and disappea…
nkdengineer Feb 12, 2026
e6736e0
fix isMaxExpenseAmountRuleEnabled with amount is 0
nkdengineer Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/libs/Violations/ViolationsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ function filterReceiptViolations(violations: TransactionViolation[]): Transactio
return violations;
}

function isMaxExpenseAmountRuleEnabled(maxAmount: number | undefined) {
return typeof maxAmount === 'number' && maxAmount !== CONST.DISABLED_MAX_EXPENSE_VALUE;
}

/**
* Calculates tag out of policy and missing tag violations for the given transaction
*/
Expand Down Expand Up @@ -422,13 +426,15 @@ const ViolationsUtils = {
!isInvoiceTransaction &&
typeof categoryMaxAmountNoReceipt !== 'number' &&
typeof maxAmountNoReceipt === 'number' &&
isMaxExpenseAmountRuleEnabled(maxAmountNoReceipt) &&
expenseAmount > maxAmountNoReceipt &&
!TransactionUtils.hasReceipt(updatedTransaction) &&
isControlPolicy;
const shouldShowCategoryReceiptRequiredViolation =
canCalculateAmountViolations &&
!isInvoiceTransaction &&
typeof categoryMaxAmountNoReceipt === 'number' &&
isMaxExpenseAmountRuleEnabled(categoryMaxAmountNoReceipt) &&
expenseAmount > categoryMaxAmountNoReceipt &&
!TransactionUtils.hasReceipt(updatedTransaction) &&
isControlPolicy;
Expand All @@ -440,6 +446,7 @@ const ViolationsUtils = {
isEligibleForItemizedReceiptViolation &&
typeof categoryMaxAmountNoItemizedReceipt !== 'number' &&
typeof maxAmountNoItemizedReceipt === 'number' &&
isMaxExpenseAmountRuleEnabled(maxAmountNoItemizedReceipt) &&
expenseAmount > maxAmountNoItemizedReceipt;

// Check for itemized receipt requirement - category level override
Expand All @@ -453,6 +460,7 @@ const ViolationsUtils = {
!isInvoiceTransaction &&
typeof categoryOverLimit !== 'number' &&
typeof overLimitAmount === 'number' &&
isMaxExpenseAmountRuleEnabled(overLimitAmount) &&
expenseAmount > overLimitAmount &&
isControlPolicy;
const shouldCategoryShowOverLimitViolation =
Expand Down
Loading