Force charts to fallback to currency code if symbol is not supported by font by mateuuszzzzz · Pull Request #81550 · Expensify/App

mateuuszzzzz · 2026-02-05T15:11:07Z

Explanation of Change

Currency symbol fallback (original fix)

Added YAxisUnit type that supports objects with {value, fallback}
When the chart font cannot render the currency symbol (detected via font.getGlyphIDs()), it
falls back to the 3-letter currency code (e.g., "₹" → "INR")
This is a temporary solution until we properly support rendering all currency symbols in the
chart font in the future

Other changes:

Made currency display reactive to locale changes

Previously, getCurrencyDisplayInfoForCharts read locale directly from
IntlStore.getCurrentLocale(), which was not reactive
Now we use preferredLocale from useLocalize() hook, so charts will re-render when user changes
language settings
Currency symbol and position (left/right) are now correctly updated based on the app's
preferred locale

Small refactor

Moved currency display logic from CurrencyUtils.ts directly into SearchChartView.tsx
The helper function getCurrencyDisplayInfoForCharts was only used in one place, so extracting
it to a shared utility was overkill
Manual memoization was removed in some places. Since the initial version of the charts code was created before we had clear guidelines for writing code with the React compiler, there are still areas with manual memoization. It’s a good idea to remove it gradually as we continue making further improvements.

Fixed Issues

$ #81112
PROPOSAL:

Tests

Test unsupported currency symbol (INR)
- Create expenses with Indian Rupee (INR) currency
- Open search chart view
- Verify Y-axis labels display "INR" instead of ₹
- Tap on a bar and verify tooltip also displays "INR"
Test supported currency symbol (USD)
- Create expenses with US Dollar (USD) currency
- Open search chart view
- Verify Y-axis labels display "$"
- Tap on a bar and verify tooltip also displays "$"
Test Y-axis and tooltip consistency
- For both INR and USD, verify the currency unit shown in tooltip matches the Y-axis

Offline tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-02-05T15:21:39Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Charts/BarChart/BarChartContent.tsx	`5.40% <ø> (ø)`
...c/components/Charts/LineChart/LineChartContent.tsx	`9.09% <ø> (ø)`
src/libs/CurrencyUtils.ts	`94.91% <ø> (+11.33%)`	⬆️
...rc/components/Charts/hooks/useChartLabelFormats.ts	`77.77% <76.47%> (+77.77%)`	⬆️
src/components/Search/SearchBarChart.tsx	`12.50% <0.00%> (ø)`
src/components/Search/SearchLineChart.tsx	`12.50% <0.00%> (ø)`
src/components/Charts/hooks/useTooltipData.ts	`0.00% <0.00%> (ø)`
src/components/Search/SearchChartView.tsx	`6.38% <0.00%> (-0.44%)`	⬇️
... and 7 files with indirect coverage changes

mateuuszzzzz · 2026-02-09T09:37:55Z

Let's merge #81543 first

…n-charts

mhawryluk

Awesome! 📈

melvin-bot · 2026-02-12T11:50:21Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2026-02-12T14:20:35Z

Switching in @ShridharGoel to review as the C+ on this project.

trjExpensify

Insights project PR 👍

ShridharGoel

Can we add tests covering these?

unsupported symbol fallback to currency code
supported symbol keeps symbol
locale change updates unit/position in chart labels

…n locale changes

mateuuszzzzz · 2026-02-16T12:30:02Z

@ShridharGoel I think you can re-review

ShridharGoel · 2026-02-16T14:11:20Z

+
+        mockNumberFormat = (n: number) => n.toLocaleString('de-DE');
+        rerender({unit: {value: '€', fallback: 'EUR'}, position: 'right'});
+        expect(result.current.formatYAxisLabel(1000)).toBe('1.000€');


But in the chart, it displays as €1,000. Is that expected?

Yes, in European countries it is common to have currency symbol on the right so if you switch to e.g. German language in the app you will see it.

ShridharGoel · 2026-02-16T16:59:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-02-17T08:36:07Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #81112 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

github-actions · 2026-02-17T19:24:58Z

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-17T19:28:52Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81550.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f29220e-37c0003-7b65f0ec853b18f5263979f408228f362d525ac3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f29220e-37c0003-a04123623cdba0674251c95ca141dd9e93b61678/index.html

Web 🕸️
https://81550.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-17T19:30:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-18T00:06:16Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.21-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-18T22:01:50Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned mateuuszzzzz Feb 5, 2026

Fallback to currency code if symbol is not supported by font

59e9ed4

mateuuszzzzz force-pushed the do-not-render-unsupported-currency-symbols-in-charts branch from a66bcff to 59e9ed4 Compare February 9, 2026 07:27

mateuuszzzzz added 3 commits February 9, 2026 09:22

Use preferredLocale for reactive chart currency formatting

048b881

Remove unused export from useChartLabelFormats

580b13a

Remove redundant comment

029ff90

mateuuszzzzz added 4 commits February 12, 2026 08:57

Merge branch 'main' into do-not-render-unsupported-currency-symbols-i…

093f5b6

…n-charts

Merge branch 'main' into do-not-render-unsupported-currency-symbols-i…

b8fccc6

…n-charts

Simplify YAxisUnit type

660095b

Remove redundant comment

d524e6a

mhawryluk approved these changes Feb 12, 2026

View reviewed changes

Comment thread src/components/Charts/hooks/useChartLabelFormats.ts Outdated

Comment thread src/components/Search/SearchChartView.tsx Outdated

Address review comments and removed redundant manual memoizaiton

3cd2404

mateuuszzzzz marked this pull request as ready for review February 12, 2026 11:50

mateuuszzzzz requested review from a team as code owners February 12, 2026 11:50

melvin-bot Bot requested review from jjcoffee and trjExpensify and removed request for a team February 12, 2026 11:50

melvin-bot Bot removed the request for review from a team February 12, 2026 11:50

trjExpensify requested review from ShridharGoel and removed request for jjcoffee February 12, 2026 14:20

trjExpensify previously approved these changes Feb 12, 2026

View reviewed changes

ShridharGoel suggested changes Feb 15, 2026

View reviewed changes

Comment thread src/components/Charts/hooks/useTooltipData.ts

Add tests covering unsupported symbols handling and unit/position whe…

0ffb94b

…n locale changes

mateuuszzzzz dismissed trjExpensify’s stale review via 0ffb94b February 16, 2026 11:53

Improve useChartLabelFormats tests

224a993

ShridharGoel reviewed Feb 16, 2026

View reviewed changes

Resolve conflicts

d4b3579

ShridharGoel approved these changes Feb 17, 2026

View reviewed changes

melvin-bot Bot requested a review from blimpich February 17, 2026 08:36

blimpich approved these changes Feb 17, 2026

View reviewed changes

blimpich merged commit f29220e into Expensify:main Feb 17, 2026
30 checks passed

OSBotify mentioned this pull request Feb 17, 2026

Deploy Checklist: New Expensify 2026-02-17 #82716

Closed

93 tasks done

jponikarchuk mentioned this pull request Feb 18, 2026

Expense - Emoji & distance unit rupee is not displayed correctly in line view chart #82851

Closed

1 of 7 tasks

Conversation

mateuuszzzzz commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Feb 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mateuuszzzzz commented Feb 9, 2026

Uh oh!

mhawryluk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented Feb 12, 2026

Uh oh!

trjExpensify commented Feb 12, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ShridharGoel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mateuuszzzzz commented Feb 16, 2026

Uh oh!

ShridharGoel Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

mateuuszzzzz Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Feb 17, 2026

Uh oh!

github-actions Bot commented Feb 17, 2026

Uh oh!

OSBotify commented Feb 17, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mateuuszzzzz commented Feb 5, 2026 •

edited

Loading

codecov Bot commented Feb 5, 2026 •

edited by github-actions Bot

Loading

ShridharGoel commented Feb 16, 2026 •

edited

Loading