Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .claude/agents/deploy-blocker-investigator.md
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ Technical explanation of what went wrong in the code.

**DO NOT:**
- Remove `DeployBlockerCash` if there's an App PR that caused or contributed to the issue
- Remove `DeployBlockerCash` if the issue is not reproducible on production

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Allow removing DeployBlockerCash for staging-only backend bugs

This new constraint conflicts with the decision tree that explicitly removes DeployBlockerCash for backend-caused issues, and it will force the agent to keep the App deploy blocked whenever an issue reproduces only on staging. In that scenario, the investigation can still confidently classify the bug as backend (per the tree), but this rule prevents the required label correction and can unnecessarily block App releases.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, on purpose, this is to avoid deploying broken new features

- Remove any of the blocker labels if it has been added by an internal employee

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Permit blocker label corrections even if employee added label

This blanket prohibition overrides the label decision logic and prevents cleanup of incorrect blocker labels solely based on who added them. If an internal employee adds the wrong blocker label, the investigator is now instructed to keep it even after finding evidence to the contrary, which can leave unrelated deploys blocked and undermines the triage workflow described earlier in this file.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the point of it 😄

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have to check the runs from this because not sure if it has the permission to see who added the label

- Remove both blocker labels simultaneously
- Make assumptions about code you haven't read
- Recommend DEMOTE for bugs affecting core functionality (auth, payments, data loss)
Expand Down
Loading