Repository navigation
Add additional contraints for Claude when removing blocker labels #81538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -207,6 +207,8 @@ Technical explanation of what went wrong in the code. | |
|
|
||
| **DO NOT:** | ||
| - Remove `DeployBlockerCash` if there's an App PR that caused or contributed to the issue | ||
| - Remove `DeployBlockerCash` if the issue is not reproducible on production | ||
| - Remove any of the blocker labels if it has been added by an internal employee | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This blanket prohibition overrides the label decision logic and prevents cleanup of incorrect blocker labels solely based on who added them. If an internal employee adds the wrong blocker label, the investigator is now instructed to keep it even after finding evidence to the contrary, which can leave unrelated deploys blocked and undermines the triage workflow described earlier in this file. Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's the point of it 😄
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might have to check the runs from this because not sure if it has the permission to see who added the label |
||
| - Remove both blocker labels simultaneously | ||
| - Make assumptions about code you haven't read | ||
| - Recommend DEMOTE for bugs affecting core functionality (auth, payments, data loss) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new constraint conflicts with the decision tree that explicitly removes
DeployBlockerCashfor backend-caused issues, and it will force the agent to keep the App deploy blocked whenever an issue reproduces only on staging. In that scenario, the investigation can still confidently classify the bug as backend (per the tree), but this rule prevents the required label correction and can unnecessarily block App releases.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, on purpose, this is to avoid deploying broken new features