Skip to content

Fix npm files - #815

Merged
alex-mechler merged 1 commit into
masterfrom
amechler-fix-package
Nov 20, 2020
Merged

alex-mechler merged 1 commit into
masterfrom
amechler-fix-package

Conversation

@alex-mechler

@alex-mechler alex-mechler commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

cc @tgolen

Fixed Issues

Fixes whitescreens

Fixes https://github.com/Expensify/Expensify/issues/146492
Fixes https://github.com/Expensify/Expensify/issues/146434

Tests

  1. Open a chat with an account you have not chatted with
  2. Verify you dont get a whitescreen

Screenshots

n/a

@alex-mechler
alex-mechler requested a review from a team as a code owner November 20, 2020 00:40
@alex-mechler alex-mechler self-assigned this Nov 20, 2020
@botify
botify requested review from tylerkaraszewski and removed request for a team November 20, 2020 00:41
@thienlnam
thienlnam self-requested a review November 20, 2020 00:41
Comment thread package-lock.json
"integrity": "sha1-RvGKMgQyCYol6p+on1FD3SVNMy0="
},
"react-native-onyx": {
"version": "git+ssh://git@github.com/Expensify/react-native-onyx.git#0cc1d0e18cf15d0d6fd3d3e05a18fcbd917abefd",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the offending lines, i think a bad merge rolled these back to a week ago

@thienlnam thienlnam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! tests well, I am able to talk to new people now

@alex-mechler

Copy link
Copy Markdown
Contributor Author

Self merging

@alex-mechler
alex-mechler merged commit 5221a42 into master Nov 20, 2020
@alex-mechler
alex-mechler deleted the amechler-fix-package branch November 20, 2020 00:59
mountiny pushed a commit that referenced this pull request Aug 21, 2026
Bumps react-native-onyx from 3.0.95 to 3.0.98, pulling in:
- Expensify/react-native-onyx#815 (cross-tab sync for collection-root subscribers)
- Expensify/react-native-onyx#816 (classify SQLite disk-pressure errors)
- Expensify/react-native-onyx#817 (prevent Onyx.merge clobbering concurrent Onyx.update)

Adds patches/react-native-onyx+3.0.98.patch carrying only Expensify/react-native-onyx#820
(batch collection member removals), which fixes an edge case in #815. The patch was
generated by building the 3.0.98 tag (verified byte-identical to the registry dist)
plus #820's lib changes, so it contains nothing from 3.0.99/3.0.100/main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants