Repository navigation
[No QA] Remove dead code associated with AuthenticateWithAccountID - #8149
Merged
Merged
Conversation
bondydaa
approved these changes
Mar 15, 2022
bondydaa
left a comment
bondydaa
left a comment
Contributor
There was a problem hiding this comment.
yep looks like these were the only instances in App
Expensidev/App (main) $ ack -i continueSessionFromECom
src/libs/actions/Session/index.js
352:function continueSessionFromECom(accountID, validateCode, twoFactorAuthCode) {
540: continueSessionFromECom,
Expensidev/App (main) $
adding @cead22 as a reviewer too since I believe he was the one who led the charge on adding this initially to make sure I'm not missing something.
I think to follow up this PR we should also create an auth PR to log if/when the flows for using a validateCode are hit so we can track to see how many users end up hitting it and eventually deprecate and remove that code.
Contributor
|
This makes sense because we ended up using short lived auth tokens for the transitions between old dot and new dot |
cead22
approved these changes
Mar 16, 2022
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
31 tasks done
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This code appears to be unused.
Fixed Issues
❌
No QA