[No QA] feat: add AI reviewer rule for catching invalid usage of loading components by mateuuszzzzz · Pull Request #81479 · Expensify/App

mateuuszzzzz · 2026-02-05T06:19:10Z

Explanation of Change

This PR adds an AI reviewer rule [UI-1] to support the ongoing migration by preventing new violations, and to serve as a permanent guard once the migration is complete.

The rule flags:
- FullscreenLoadingIndicator used alongside visible navigation (like
HeaderWithBackButton) - should use ActivityIndicator instead
- FullscreenLoadingIndicator without shouldUseGoBackButton prop when no
navigation is visible (users get trapped if loading hangs)
- ActivityIndicator as the sole screen content without any navigation (should
use FullscreenLoadingIndicator with shouldUseGoBackButton)

Why this matters:
If loading hangs indefinitely, users need an escape route. The
shouldUseGoBackButton prop shows an emergency "Go Back" button after 10 seconds
timeout. This rule ensures engineers use the correct component based on whether
navigation is already visible.

Fixed Issues

$ #79729
PROPOSAL:

Tests

Rule extraction:
- Run: .github/scripts/extractAllowedRules.sh
- Verify UI-1 appears in output - if missing, the rule cannot be used by the
  reviewer

Test 1: Verify violation is flagged

Find any existing page that uses ScreenWrapper and HeaderWithBackButton
Add <FullscreenLoadingIndicator /> inside the same return statement (alongside
the header)
Commit and open a PR to main
Wait for Claude reviewer workflow to complete
Verify an inline comment appears referencing [UI-1]

Test 2: Verify valid patterns are NOT flagged

Replace FullscreenLoadingIndicator with ActivityIndicator (keeping the header
visible)
Push the change
Verify no [UI-1] violation appears

Test 3: Verify shouldUseGoBackButton pattern

Remove the header and use FullscreenLoadingIndicator with
shouldUseGoBackButton prop
Push and verify no violation is flagged

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

mountiny · 2026-02-05T06:28:08Z

@kacper-mikolajczak @adhorodyski could you give this one a look?

kacper-mikolajczak

Overal this looks LGTM! Curious how it is going to help with migration and usage later on 🤞

melvin-bot · 2026-02-05T14:31:49Z

@Krishna2323 @Julesssss One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bbdf164726

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-05T14:37:46Z


+### [UI-1] Use the correct loading indicator based on navigation context
+
+- **Search patterns**: `FullscreenLoadingIndicator`, `ActivityIndicator`


Include FullScreenLoadingIndicator in search patterns

This rule’s Search patterns only lists FullscreenLoadingIndicator, but the codebase also uses the FullScreenLoadingIndicator identifier extensively (e.g., many imports alias the same component this way). Because the reviewer instructions later require using each rule’s search patterns to grep large files, this omission will miss violations in files that use the FullScreen... spelling and create systematic false negatives for UI-1.

Useful? React with 👍 / 👎.

Yeah minor point but needs a capitol S

Same for a few place

Julesssss · 2026-02-05T21:55:28Z

+
+- **Condition**: Flag ONLY when ANY of these patterns is found:
+  - `FullscreenLoadingIndicator` and `HeaderWithBackButton` (or other navigation like close button) are **both under the same JSX tree** (not separated by conditionals)
+  - `FullscreenLoadingIndicator` without `shouldUseGoBackButton` prop when **no navigation component** is visible alongside it


no navigation component is visible alongside it

This seems a bit vauge and open to interpretation

Hmmmmm I was afraid that it might be not efficient to list all navigation components 🤔
I'm curious what do you think about it.

Also regarding this part " is visible alongside it", what about changing it to "in the same render branch"?

Actually I can try to experiment with different variants of this prompts

Happy with your suggestion here. It'll never be perfect 😅

Julesssss

Excited to try this. Do you have any test output you could share? It's hard to know how our friend Claude will perform, but it looks great overall.

Update: Could you create a draft PR that breaks these rules, with some additional cases that SHOULD NOT be flagged as false positives? I'll run the workflow against it

adamgrzybowski

Good comments from @Julesssss, but overall LGTM

mateuuszzzzz · 2026-02-11T08:02:27Z

Update: Could you create a draft PR that breaks these rules, with some additional cases that SHOULD NOT be flagged as false positives? I'll run the workflow against it

Sure! I'm gonna improve the prompt a bit and try to create a few draft PRs with different corner cases to see how it performs after changes

mateuuszzzzz · 2026-02-16T14:24:59Z

@Julesssss I ran reviewer on different PRs that somehow use different loading indicators and here are the results

PR #64 — Violations (should flag all)

File	Expected	Reviewer result
`AuthCallbackPage.tsx`	❌ UI-1: `ActivityIndicator` as sole content, no navigation	✅ Correctly flagged
`ValidateAccountPage.tsx`	❌ UI-1: `FullscreenLoadingIndicator` without `shouldUseGoBackButton`, no navigation	✅ Correctly flagged
`WorkspaceSubscriptionPage.tsx`	❌ UI-1: `FullscreenLoadingIndicator` + `HeaderWithBackButton` in same JSX tree	✅ Correctly flagged

PR #65 — Correct patterns (should NOT flag UI-1)

File	Expected	Reviewer result
`ValidateLoginPage.tsx`	✅ Correct: `FullscreenLoadingIndicator` with `shouldUseGoBackButton`	✅ Not flagged
`WorkspaceCategoriesPage.tsx`	✅ Correct: `ActivityIndicator` alongside `HeaderWithBackButton`	✅ Not flagged
`WorkspaceTagsPage.tsx`	✅ Correct: Separate returns, loader with `shouldUseGoBackButton`	✅ Not flagged

PR #66 — Edge cases (mixed)

File	Expected	Reviewer result
`AppLoadingPage.tsx`	✅ Exempt: visibility controlled by `FullScreenLoaderContext`	✅ Not flagged
`SubmitExpenseButton.tsx`	✅ Exempt: `ActivityIndicator` inside a `Button` (interactive element)	✅ Not flagged
`WorkspaceJoinPage.tsx`	❌ UI-1: Separate returns but missing `shouldUseGoBackButton`	✅ Correctly flagged
`WorkspaceOwnerChangePage.tsx`	❌ UI-1: `FullScreenLoadingIndicator` (capital S) + `HeaderWithBackButton` in same tree	✅ Correctly flagged

Julesssss · 2026-02-17T19:18:58Z

Thank you, the results look great. Lets move forward! I'll create an issue to recheck manually in a month or so, as. secondary check.

Julesssss

No comments about the specific rule data. LGTM

Julesssss · 2026-02-17T19:21:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2026-02-17T19:32:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-18T00:06:11Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.21-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-18T22:01:44Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Add reviewer rule for catching invalid usage of loading components

2562387

melvin-bot Bot assigned mateuuszzzzz Feb 5, 2026

mateuuszzzzz mentioned this pull request Feb 5, 2026

[Tracking] Ensure any error page is recoverable and logs necessary info for more debugging #69850

Open

mountiny requested review from adhorodyski and kacper-mikolajczak February 5, 2026 06:27

Clarify FLAG and DO NOT FLAG sections

e93f45e

mateuuszzzzz changed the title ~~feat: add AI reviewer rule for catching invalid usage of loading components~~ [No QA] feat: add AI reviewer rule for catching invalid usage of loading components Feb 5, 2026

kacper-mikolajczak approved these changes Feb 5, 2026

View reviewed changes

Comment thread .claude/agents/code-inline-reviewer.md Outdated

Adjust prompt

bbdf164

mateuuszzzzz marked this pull request as ready for review February 5, 2026 14:31

mateuuszzzzz requested a review from a team as a code owner February 5, 2026 14:31

melvin-bot Bot requested review from Julesssss and Krishna2323 and removed request for a team February 5, 2026 14:31

chatgpt-codex-connector Bot reviewed Feb 5, 2026

View reviewed changes

Julesssss reviewed Feb 5, 2026

View reviewed changes

adamgrzybowski approved these changes Feb 6, 2026

View reviewed changes

adhorodyski approved these changes Feb 13, 2026

View reviewed changes

mateuuszzzzz added 4 commits February 16, 2026 13:42

Merge branch 'main' into add-loading-indicator-reviewer-rule

8e4a68e

Address review

96ff209

Use skills

6e31905

Handle FullScreenLoaderContext edge case

2da8185

Julesssss approved these changes Feb 17, 2026

View reviewed changes

Julesssss merged commit 817f8d0 into Expensify:main Feb 17, 2026
12 of 13 checks passed

OSBotify mentioned this pull request Feb 17, 2026

Deploy Checklist: New Expensify 2026-02-17 #82716

Closed

93 tasks done


		### [UI-1] Use the correct loading indicator based on navigation context

		- Search patterns: `FullscreenLoadingIndicator`, `ActivityIndicator`

Conversation

mateuuszzzzz commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

mountiny commented Feb 5, 2026

Uh oh!

kacper-mikolajczak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented Feb 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Julesssss Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Julesssss Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Julesssss Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

adamgrzybowski Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

mateuuszzzzz Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

mateuuszzzzz Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Julesssss Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Julesssss left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamgrzybowski left a comment

Choose a reason for hiding this comment

Uh oh!

mateuuszzzzz commented Feb 11, 2026

Uh oh!

mateuuszzzzz commented Feb 16, 2026

PR #64 — Violations (should flag all)

PR #65 — Correct patterns (should NOT flag UI-1)

PR #66 — Edge cases (mixed)

Uh oh!

Julesssss commented Feb 17, 2026

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Feb 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Feb 17, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

mateuuszzzzz commented Feb 5, 2026 •

edited

Loading

Julesssss left a comment •

edited

Loading