[No QA] Fix flaky useSelectedTransactionsActions tests by roryabraham · Pull Request #81464 · Expensify/App

roryabraham · 2026-02-05T00:15:17Z

Explanation of Change

Fixed flaky tests in useSelectedTransactionsActions.test.ts. The tests were waiting for options.length > 0, which is satisfied immediately when the EXPORT option appears. However, SPLIT/MOVE/MERGE options depend on selectedTransactionsList which is derived from allTransactions loaded asynchronously via useOnyx. The fix moves the specific option assertion inside waitFor to ensure the test waits until Onyx data is fully loaded.

Ran the tests 35 times after the fix with 0 failures.

Fixed Issues

$ #81459

Tests

Ran the test 35 times locally after fixing - all passed

Offline tests

N/A - Test-only change

QA Steps

N/A - No QA needed for test-only changes

PR Author Checklist

Screenshots/Videos

Android: Native

N/A - Test-only change

Android: mWeb Chrome

N/A - Test-only change

iOS: Native

N/A - Test-only change

iOS: mWeb Safari

N/A - Test-only change

MacOS: Chrome / Safari

N/A - Test-only change

Tests were waiting for options.length > 0, which is satisfied by the EXPORT option that appears immediately. However, SPLIT/MOVE/MERGE options depend on selectedTransactionsList which requires Onyx data to be fully loaded. Fixed by waiting for the specific option inside waitFor instead of just checking options.length. Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham · 2026-02-05T00:17:44Z

@codex review

chatgpt-codex-connector · 2026-02-05T00:22:29Z

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-02-05T00:23:00Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-05T00:23:28Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2026-02-05T00:23:33Z

I think this is a test-only change we don't need C+ review here

robertjchen · 2026-02-05T00:24:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2026-02-05T20:50:34Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.13-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T21:50:59Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-10T07:06:54Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned roryabraham Feb 5, 2026

roryabraham changed the title ~~[WIP][No QA] Fix flaky useSelectedTransactionsActions tests~~ [No QA] Fix flaky useSelectedTransactionsActions tests Feb 5, 2026

roryabraham marked this pull request as ready for review February 5, 2026 00:22

roryabraham requested a review from a team as a code owner February 5, 2026 00:22

melvin-bot Bot requested a review from jayeshmangwani February 5, 2026 00:22

melvin-bot Bot removed the request for review from a team February 5, 2026 00:23

roryabraham requested a review from a team February 5, 2026 00:23

melvin-bot Bot requested review from sobitneupane and removed request for a team February 5, 2026 00:23

roryabraham removed request for jayeshmangwani and sobitneupane February 5, 2026 00:23

robertjchen approved these changes Feb 5, 2026

View reviewed changes

roryabraham merged commit b8c9afc into main Feb 5, 2026
30 checks passed

roryabraham deleted the Rory-FixFlakyUseSelectedTransactionsActions branch February 5, 2026 00:27

OSBotify mentioned this pull request Feb 5, 2026

Deploy Checklist: New Expensify 2026-02-05 #81590

Closed

Navigation Menu

[No QA] Fix flaky useSelectedTransactionsActions tests - #81464

[No QA] Fix flaky useSelectedTransactionsActions tests#81464
roryabraham merged 1 commit into
mainfrom
Rory-FixFlakyUseSelectedTransactionsActions

roryabraham commented Feb 5, 2026 •

edited

Loading

Uh oh!

roryabraham commented Feb 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Feb 5, 2026

Uh oh!

melvin-bot Bot commented Feb 5, 2026

Uh oh!

melvin-bot Bot commented Feb 5, 2026

Uh oh!

roryabraham commented Feb 5, 2026

Uh oh!

robertjchen commented Feb 5, 2026

Uh oh!

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

roryabraham commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

roryabraham commented Feb 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Feb 5, 2026

Uh oh!

melvin-bot Bot commented Feb 5, 2026

Uh oh!

melvin-bot Bot commented Feb 5, 2026

Uh oh!

roryabraham commented Feb 5, 2026

Uh oh!

robertjchen commented Feb 5, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

roryabraham commented Feb 5, 2026 •

edited

Loading