Don't use bank account flow for pay elsewhere by srikarparsi · Pull Request #81432 · Expensify/App

srikarparsi · 2026-02-04T18:07:53Z

Explanation of Change

When Mark as paid is selected, we shouldn't prompt the user to select a payment option as the payment has been done outside of Expensify.

Fixed Issues

$ #81349
PROPOSAL:

Tests

Same as QA tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Join as new user & create new workspace
Go to workspace chat
Create a manual expense >> Submit & approve the expense
Create one more expense
Go to Reports >> Expenses
Select the expense via checkbox which has Pay option
Select Pay >> Pay with business account
Validate the account & close the RHP
Select again Pay >> Pay with business account
Observe bank account flow opens
Close the RHP
Select again Pay dropdown >> Mark as Paid
Expense should be paid when selecting Mark as Paid option via Pay dropdown in Reports page

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

merge main

melvin-bot · 2026-02-04T19:10:42Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abzokhattab · 2026-02-04T19:10:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-04.at.21.02.09.mov

Android: mWeb Chrome

Screen.Recording.2026-02-04.at.20.57.26.mov

iOS: HybridApp

Screen.Recording.2026-02-04.at.20.48.25.mov

iOS: mWeb Safari

Screen.Recording.2026-02-04.at.20.50.46.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-04.at.20.38.21.mov

abzokhattab · 2026-02-04T19:33:30Z

@srikarparsi Should we add unit tests to cover that change?

abzokhattab · 2026-02-04T19:43:00Z

i dont think its in the scope of this issue but I noticed a minor UI issue: clicking Pay elsewhere causes the transaction to briefly disappear from the table before reappearing once the backend response is received

Untitled.mov

srikarparsi · 2026-02-04T20:02:35Z

@srikarparsi Should we add unit tests to cover that change?

Yes, we probably should - just added a test

abzokhattab

Awesome LGTM 🚀🚀

melvin-bot · 2026-02-04T20:05:54Z

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-02-04T20:12:51Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/PaymentUtils.ts	`44.70% <100.00%> (ø)`
... and 7 files with indirect coverage changes

merge main

jasperhuangg · 2026-02-04T21:05:53Z

gonna take myself off the review since it seems like you're in good hands here

melvin-bot · 2026-02-04T21:07:36Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-02-04T21:07:54Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

Don't use bank account flow for pay elsewhere (cherry picked from commit 19a188d) (cherry-picked to staging by Julesssss)

Julesssss · 2026-02-04T21:12:44Z

Check failing on main already, unrelated

github-actions · 2026-02-04T21:13:57Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81432.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-19a188d-67c2124852e067fe4ad7350a1911cc41dfdc73a6/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-19a188d-3c00d61b42778a23abdbba8b8148335f1991e7ed/index.html

Web 🕸️
https://81432.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-04T21:36:31Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.11-50 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-05T20:29:41Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-02-05T20:50:16Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.13-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T21:50:41Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-10T07:06:36Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Don't use bank account flow for pay elsewhere

eb2ffa5

srikarparsi requested a review from hungvu193 February 4, 2026 18:07

melvin-bot Bot assigned srikarparsi Feb 4, 2026

srikarparsi added 3 commits February 4, 2026 13:18

Merge branch 'main' into srikar-payElsewhere

e84dc52

merge main

explicitly check

25abb09

simplify

9e4ff51

srikarparsi requested a review from abzokhattab February 4, 2026 19:06

srikarparsi marked this pull request as ready for review February 4, 2026 19:10

srikarparsi requested review from a team as code owners February 4, 2026 19:10

melvin-bot Bot requested review from cristipaval and heyjennahay and removed request for a team February 4, 2026 19:10

Julesssss previously approved these changes Feb 4, 2026

View reviewed changes

add test

14a0d27

srikarparsi dismissed Julesssss’s stale review via 14a0d27 February 4, 2026 20:02

abzokhattab approved these changes Feb 4, 2026

View reviewed changes

melvin-bot Bot requested a review from jasperhuangg February 4, 2026 20:05

Merge branch 'main' into srikar-payElsewhere

fee5a2a

merge main

Julesssss approved these changes Feb 4, 2026

View reviewed changes

jasperhuangg removed their request for review February 4, 2026 21:05

Julesssss merged commit 19a188d into main Feb 4, 2026
33 of 34 checks passed

Julesssss deleted the srikar-payElsewhere branch February 4, 2026 21:07

melvin-bot Bot added the Emergency label Feb 4, 2026

OSBotify pushed a commit that referenced this pull request Feb 4, 2026

Merge pull request #81432 from Expensify/srikar-payElsewhere

1038c57

Don't use bank account flow for pay elsewhere (cherry picked from commit 19a188d) (cherry-picked to staging by Julesssss)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Feb 4, 2026

Julesssss removed the Emergency label Feb 4, 2026

OSBotify mentioned this pull request Feb 4, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

srikarparsi mentioned this pull request Feb 4, 2026

Don't trigger KYC flow if item.key is exactly Elsewhere in Search #81448

Merged

53 tasks

abzokhattab mentioned this pull request Feb 5, 2026

[Due for payment 2026-02-17] [$250] Reports - Mark as paid option via Pay dropdown opens bank account flow #81349

Closed

7 tasks

Uh oh!

Conversation

srikarparsi commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 4, 2026

Uh oh!

abzokhattab commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abzokhattab commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abzokhattab commented Feb 4, 2026

Uh oh!

srikarparsi commented Feb 4, 2026

Uh oh!

abzokhattab left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Feb 4, 2026

Uh oh!

codecov Bot commented Feb 4, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jasperhuangg commented Feb 4, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented Feb 4, 2026

Uh oh!

github-actions Bot commented Feb 4, 2026

Uh oh!

Julesssss commented Feb 4, 2026

Uh oh!

github-actions Bot commented Feb 4, 2026

Uh oh!

OSBotify commented Feb 4, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

srikarparsi commented Feb 4, 2026 •

edited

Loading

abzokhattab commented Feb 4, 2026 •

edited

Loading

abzokhattab commented Feb 4, 2026 •

edited

Loading

codecov Bot commented Feb 4, 2026 •

edited by github-actions Bot

Loading