[Bug] Fix RHP not closing after shipping Expensify Card by mountiny · Pull Request #81363 · Expensify/App

mountiny · 2026-02-04T02:01:40Z

Explanation of Change

Fix a logic bug in the areAllCardsShippedSelector that prevented the RHP from closing after successfully shipping an Expensify Card when the user also has personal or company cards.

The bug was in the AND logic: card?.state !== STATE_NOT_ISSUED && !isPersonalCard(card). This meant if a user had ANY personal/company card, the selector would return false even when all Expensify cards were shipped.

Changes:

Created a new areAllExpensifyCardsShipped selector in selectors/Card.ts
Uses isCard() and isExpensifyCard() to filter to only valid Expensify cards
Checks that all filtered cards have state !== STATE_NOT_ISSUED
Updated MissingPersonalDetailsMagicCodePage.tsx to use the new selector
Added 8 unit tests to prevent regression

Fixed Issues

$ #81362

Tests

Preconditions: You must have an Expensify card feed with a real bank account linked - the Plaid testing bank account feed will not ship the card actually so the state of the card is not changed

Issue a physical Expensify Card to a user who also has personal cards (CSV imported) or company cards
Sign in as that user
Go through the Missing Personal Details flow to add shipping address
Enter the magic code and submit
Verify the RHP closes automatically after the card is shipped

Verify that no errors appear in the JS console

Offline tests

N/A - The card shipping requires network connectivity

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The areAllCardsShippedSelector had a logic bug where it used AND instead of filtering. If a user had any personal or company cards, the selector would return false even when all Expensify cards were shipped. This fix: - Creates a new areAllExpensifyCardsShipped selector in Card.ts - Uses isCard and isExpensifyCard to filter to only valid Expensify cards - Checks that all filtered cards are not in STATE_NOT_ISSUED state - Adds unit tests to prevent regression of this bug

melvin-bot · 2026-02-04T02:01:46Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-04T02:05:58Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

codecov · 2026-02-04T02:20:06Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/selectors/Card.ts	`100.00% <100.00%> (ø)`
...nalDetails/MissingPersonalDetailsMagicCodePage.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

parasharrajat · 2026-02-04T06:58:02Z

Question: is it fine to issue a physical card and add address on a test account?

parasharrajat · 2026-02-04T08:53:25Z

It is not solved yet. Reason is that the card state is is still non_issued.

04.02.2026_14.21.14_REC.mp4

joekaufmanexpensify · 2026-02-04T15:56:02Z

Question: is it fine to issue a physical card and add address on a test account?

No, it won't work with the Plaid test bank account

joekaufmanexpensify

Works for me!

2026-02-04_10-52-42.mp4

parasharrajat · 2026-02-04T20:17:17Z

Any thoughts? @mountiny

mountiny · 2026-02-05T01:13:33Z

I will resolve the confclits, but this should be ready for a review

mountiny · 2026-02-05T05:46:37Z

@codex review

chatgpt-codex-connector · 2026-02-05T05:54:54Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mountiny · 2026-02-05T05:59:13Z

Actually I think we dont need a c+ review here as Joe tested it works and we can just complete the review internally given you cannot test it fully

MariaHCD · 2026-02-05T06:08:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-02-05T06:12:20Z

🚧 @MariaHCD has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-05T06:18:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81363.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8ed5bc1-2e219f78ca3bc5337bdb26c14e30c9994ec2829b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8ed5bc1-403a7d4b5b86c5a9d928e38f36d0492881f3b878/index.html

Web 🕸️
https://81363.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-05T06:21:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-05T20:49:42Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.3.13-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T21:50:08Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.3.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-10T07:06:03Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mountiny requested review from a team as code owners February 4, 2026 02:01

melvin-bot Bot assigned mountiny Feb 4, 2026

melvin-bot Bot requested a review from parasharrajat February 4, 2026 02:01

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team February 4, 2026 02:01

mountiny added the InternalQA This pull request required internal QA label Feb 4, 2026

This comment has been minimized.

Sign in to view

Prettier

d5dd470

joekaufmanexpensify previously approved these changes Feb 4, 2026

View reviewed changes

Merge main

fae505a

mountiny dismissed joekaufmanexpensify’s stale review via fae505a February 4, 2026 17:06

Merge main

ec6148f

mountiny removed the request for review from parasharrajat February 5, 2026 05:58

MariaHCD approved these changes Feb 5, 2026

View reviewed changes

MariaHCD merged commit 8ed5bc1 into main Feb 5, 2026
33 of 43 checks passed

MariaHCD deleted the vit-fixShippingCard branch February 5, 2026 06:11

OSBotify mentioned this pull request Feb 5, 2026

Deploy Checklist: New Expensify 2026-02-05 #81590

Closed

mountiny restored the vit-fixShippingCard branch February 5, 2026 23:52

Conversation

mountiny commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 4, 2026

Uh oh!

github-actions Bot commented Feb 4, 2026

Uh oh!

This comment has been minimized.

codecov Bot commented Feb 4, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

parasharrajat commented Feb 4, 2026

Uh oh!

parasharrajat commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joekaufmanexpensify commented Feb 4, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Feb 4, 2026

Uh oh!

mountiny commented Feb 5, 2026

Uh oh!

mountiny commented Feb 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Feb 5, 2026

Uh oh!

mountiny commented Feb 5, 2026

Uh oh!

MariaHCD commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Feb 5, 2026

Uh oh!

github-actions Bot commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mountiny commented Feb 4, 2026 •

edited

Loading

codecov Bot commented Feb 4, 2026 •

edited by github-actions Bot

Loading

parasharrajat commented Feb 4, 2026 •

edited

Loading

MariaHCD commented Feb 5, 2026 •

edited

Loading