Conversation
… expense to expense report
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@ZhenjaHorbach can you please test and add the checklist for this one? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridApp2026-02-02.10.55.44.moviOS: mWeb Safari2026-02-02.10.57.26.movMacOS: Chrome / Safari2026-02-02.10.51.38.mov |
|
LGTM! |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Good product polish.
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.13-1 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.15-0 🚀
|
|
Hi @collectioneur. QA team failed this PR on Native apps with an original issue 1770342081453.4.mp41770341271239.ScreenRecording_02-05-2026_20-25-17_1.mp4 |
|
Hi, preparing a quick fix |
|
The fix is ready |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀
|
Explanation of Change
I’ve updated the navigation logic.
Previously: Adding a second expense to a single-expense report from the Expenses tab would close all modals before reopening a new modal for the two-expense report.
Now: Only the modals related to adding the expense are closed. The original report stays open and is immediately replaced by the correct route for the super-wide RHP with two expenses. This way, the report doesn't actually close and reopen.
Fixed Issues
$ #79712
Tests
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-01-30.at.12.34.40.mov