Skip to content

Fix save button position on Split page when saving category #80992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deetergp merged 3 commits into from
Feb 3, 2026
Merged

Fix save button position on Split page when saving category #80992

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84112ad
Fix save button position on Split page when saving category
huult Jan 30, 2026
e5b3fe0
Merge remote-tracking branch 'upstream/main' into 79851-split-save-bu…
huult Jan 31, 2026
3605948
Merge remote-tracking branch 'upstream/main' into 79851-split-save-bu…
huult Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/pages/iou/SplitExpensePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
const transactionDetails: Partial<TransactionDetails> = getTransactionDetails(transaction, undefined, currentPolicy) ?? {};
const transactionDetailsAmount = transactionDetails?.amount ?? 0;
const sumOfSplitExpenses = (draftTransaction?.comment?.splitExpenses ?? []).reduce((acc, item) => acc + (item.amount ?? 0), 0);
const splitExpenses = draftTransaction?.comment?.splitExpenses ?? [];

Check warning on line 112 in src/pages/iou/SplitExpensePage.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

The 'splitExpenses' logical expression could make the dependencies of useEffect Hook (at line 148) change on every render. To fix this, wrap the initialization of 'splitExpenses' in its own useMemo() Hook

const currencySymbol = getCurrencySymbol(transactionDetails.currency ?? '') ?? transactionDetails.currency ?? CONST.CURRENCY.USD;

Expand Down Expand Up @@ -421,7 +421,6 @@
<ScreenWrapper
testID="SplitExpensePage"
shouldEnableMaxHeight={canUseTouchScreen()}
keyboardAvoidingViewBehavior="height"
shouldDismissKeyboardBeforeClose={false}
>
<FullPageNotFoundView shouldShow={!reportID || isEmptyObject(draftTransaction) || !isSplitAvailable}>
Expand Down
Loading