fix: [Insights] Prevent empty limit from polluting query and add description to Limit filter - #80867
Merged
lakchote merged 4 commits intoJan 30, 2026
Conversation
melvin-bot
Bot
requested review from
ShridharGoel and
joekaufmanexpensify
and removed request for
a team
January 29, 2026 08:38
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…ts-Release-1-Top-Categories-Add-a-limit-filter-to-search
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
TaduJR
changed the title
Contributor
|
Running the translations script. 👍 |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 1800f8f3..3125f24b 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -6985,7 +6985,7 @@ Fordere Spesendetails wie Belege und Beschreibungen an, lege Limits und Standard
keyword: 'Schlüsselwort',
keywords: 'Schlüsselwörter',
limit: 'Limit',
- limitDescription: 'Legen Sie eine Obergrenze für die Ergebnisse Ihrer Suche fest.',
+ limitDescription: 'Legen Sie ein Limit für die Ergebnisse Ihrer Suche fest.',
currency: 'Währung',
completed: 'Abgeschlossen',
amount: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 9fead99e..f174371f 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -7010,7 +7010,7 @@ Richiedi dettagli di spesa come ricevute e descrizioni, imposta limiti e valori
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID prelievo', //_/\__/_/ \_,_/\__/\__/\_,_/
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Categoria',
[CONST.SEARCH.GROUP_BY.MERCHANT]: 'Esercente',
- [CONST.SEARCH.GROUP_BY.TAG]: 'Tag',
+ [CONST.SEARCH.GROUP_BY.TAG]: 'Etichetta',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Mese',
[CONST.SEARCH.GROUP_BY.WEEK]: 'Settimana',
},
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 1878397d..254b5175 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6913,7 +6913,7 @@ ${reportName}
keyword: 'キーワード',
keywords: 'キーワード',
limit: '制限',
- limitDescription: '検索結果の制限を設定します。',
+ limitDescription: '検索結果の上限を設定します。',
currency: '通貨',
completed: '完了',
amount: {
@@ -6946,7 +6946,7 @@ ${reportName}
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: '差出人',
[CONST.SEARCH.GROUP_BY.CARD]: 'カード',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '出金ID',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '出金 ID',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'カテゴリ',
[CONST.SEARCH.GROUP_BY.MERCHANT]: '加盟店',
[CONST.SEARCH.GROUP_BY.TAG]: 'タグ',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 8eaa72b1..1753e2c2 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6957,7 +6957,7 @@ Vraag verplichte uitgavedetails zoals bonnetjes en beschrijvingen, stel limieten
keyword: 'Trefwoord',
keywords: 'Trefwoorden',
limit: 'Limiet',
- limitDescription: 'Stel een limiet in voor de resultaten van je zoekopdracht.',
+ limitDescription: 'Stel een limiet in voor de resultaten van uw zoekopdracht.',
currency: 'Valuta',
completed: 'Voltooid',
amount: {
@@ -6993,7 +6993,7 @@ Vraag verplichte uitgavedetails zoals bonnetjes en beschrijvingen, stel limieten
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Opname-ID',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Categorie',
[CONST.SEARCH.GROUP_BY.MERCHANT]: 'Handelaar',
- [CONST.SEARCH.GROUP_BY.TAG]: 'Tag',
+ [CONST.SEARCH.GROUP_BY.TAG]: 'Label',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Maand',
[CONST.SEARCH.GROUP_BY.WEEK]: 'Week',
},
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index e0cdbe04..897006b1 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6945,7 +6945,7 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
keyword: 'Słowo kluczowe',
keywords: 'Słowa kluczowe',
limit: 'Limit',
- limitDescription: 'Ustaw limit wyników wyszukiwania.',
+ limitDescription: 'Ustaw limit dla wyników wyszukiwania.',
currency: 'Waluta',
completed: 'Zakończone',
amount: {
@@ -6978,10 +6978,10 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: 'Od',
[CONST.SEARCH.GROUP_BY.CARD]: 'Karta',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID wypłaty',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Identyfikator wypłaty',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Kategoria',
[CONST.SEARCH.GROUP_BY.MERCHANT]: 'Sprzedawca',
- [CONST.SEARCH.GROUP_BY.TAG]: 'Tag',
+ [CONST.SEARCH.GROUP_BY.TAG]: 'Etykieta',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Miesiąc',
[CONST.SEARCH.GROUP_BY.WEEK]: 'Tydzień',
},
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index ee4d560f..62d7a1d9 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6981,8 +6981,8 @@ Exija detalhes de despesas como recibos e descrições, defina limites e padrõe
[CONST.SEARCH.GROUP_BY.CARD]: 'Cartão',
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID de saque',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Categoria',
- [CONST.SEARCH.GROUP_BY.MERCHANT]: 'Estabelecimento',
- [CONST.SEARCH.GROUP_BY.TAG]: 'Etiqueta',
+ [CONST.SEARCH.GROUP_BY.MERCHANT]: 'Comerciante',
+ [CONST.SEARCH.GROUP_BY.TAG]: 'Tag',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Mês',
[CONST.SEARCH.GROUP_BY.WEEK]: 'Semana',
},
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index b6649e7b..83ed2dc7 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6793,7 +6793,7 @@ ${reportName}
keyword: '关键字',
keywords: '关键词',
limit: '限制',
- limitDescription: '为搜索结果设置限制。',
+ limitDescription: '为搜索结果设置一个上限。',
currency: '货币',
completed: '已完成',
amount: {
@@ -6824,8 +6824,9 @@ ${reportName}
reimbursable: '可报销',
purchaseCurrency: '购买货币',
groupBy: {
- [CONST.SEARCH.GROUP_BY.FROM]: '来自',
+ [CONST.SEARCH.GROUP_BY.FROM]: '发件人',
[CONST.SEARCH.GROUP_BY.CARD]: '卡',
+ //_/\__/_/ \_,_/\__/\__/\_,_/
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '提现编号',
[CONST.SEARCH.GROUP_BY.CATEGORY]: '类别',
[CONST.SEARCH.GROUP_BY.MERCHANT]: '商户',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-01-30.at.5.42.16.AM.moviOS: mWeb Safari
MacOS: Chrome / SafariScreen.Recording.2026-01-30.at.5.43.50.AM.mov |
ShridharGoel
approved these changes
Jan 30, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.11-16 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #80675
$ #80930
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Macbook-Chrome.mp4