-
Notifications
You must be signed in to change notification settings - Fork 4k
Improve merchant matching robustness by adding Match type options: Is exactly & Contains #80778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
b974581
feat: Add match type selection for merchant rules
luacmartins b6c0b22
fix: Remove padding from match type menu item
luacmartins 6921cb0
Fix styles, remove unused copy
luacmartins 96ffdc3
Update submit button styles
luacmartins 7b15d32
feat: Use 'matches' operator for exact match type
luacmartins 264ce03
Merge branch 'main' into cmartins-merchantRulesExactMatch
luacmartins 6c81e04
Revert CONST changes
luacmartins 546a919
Use constants
luacmartins 7c413cf
Apply translations
luacmartins e7c3fad
Revert chant to category
luacmartins 2eefd88
Merge branch 'main' into cmartins-merchantRulesExactMatch
luacmartins 17adfc8
Update menu item selection
luacmartins d0ab8f2
Update selection list order
luacmartins 42529e2
Remove temp file
luacmartins 8b828a0
Apply translations
luacmartins 9950881
Fix prettier
luacmartins 9d90cc3
Update operators
luacmartins c0d80ce
Apply comments
luacmartins aef4984
Fix prettier
luacmartins 1a06258
Fix TS
luacmartins a6484f0
Merge branch 'main' into cmartins-merchantRulesExactMatch
luacmartins 1203665
Add matchType to ignore list
luacmartins e3eab8f
Fix TS
luacmartins 5772be6
refactor: Omit empty fields instead of sending null values
luacmartins ab2ce62
Update errors
luacmartins d48941f
refactor: Use null in Onyx but omit nulls from API
luacmartins c3812f1
fix: Correct operator check when loading match type for editing
luacmartins 50582c9
fix: Correct operator check in MerchantRulesSection for exact match
luacmartins 0e4c713
chore: Add expensesExactlyMatching translation to en.ts
luacmartins 1ce80cd
Update operators
luacmartins a503cc7
Apply translations
luacmartins 2662c34
resolve conflicts
luacmartins 4fdbafd
Address comments
luacmartins f9eedaa
Resolve conflicts
luacmartins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's fine to translate conditionally?
Just wondering if
exactly matchesandcontainsare at different positions in some languages.