Replace expo-av with expo-audio by blazejkustra · Pull Request #80624 · Expensify/App

blazejkustra · 2026-01-27T13:47:26Z

Explanation of Change

Fixed Issues

$ #80742
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13831

Tests

For these tests it is recommended to use a secondary device to send the messages to the main testing device.

Device volume should be turned on
App notifications should be enabled

Notifications - Receive message open app

Navigate to a conversation that is not the one with the secondary user
Secondary device - Send a message to the user in the main testing device
Verify the user receives a notification

Muting all sounds from Expensify

Navigate to settings and enable 'Mute all sounds from Expensify' option
Keep the app open
Secondary user -> Send some messages to the user in the main testing device
Verify no app sounds are reproduced when receiving the messages

Notifications - Receive message backgrounded app

Navigate to a conversation that is not the one with the secondary user
Background the app / Navigate to another tab or minimize the window in web
Secondary device - Send a message to the user in the main testing device
Verify the user receives a notification with a sound

Offline tests

N/A

QA Steps

Verify all test cases for native android and ios apps

PR Author Checklist

Screenshots/Videos

Android: Native

untitled.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2026-01-29.at.17.05.47.mov

github-actions · 2026-01-27T13:47:37Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

…in playSound function

codecov · 2026-01-27T14:02:55Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/Expensify.tsx	`84.65% <ø> (-0.17%)`	⬇️
src/libs/Sound/index.ts	`0.00% <0.00%> (ø)`
src/libs/Sound/index.native.ts	`62.50% <61.53%> (+12.50%)`	⬆️
... and 7 files with indirect coverage changes

war-in

LGTM

github-actions · 2026-01-28T16:34:46Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-28T17:18:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80624 Mobile-Expensify PR Expensify/Mobile-Expensify#13831.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-748f075d0b0c7aca5562fe33bbd00b2ed70815e9/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed

Web 🕸️
https://80624.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dukenv0307 · 2026-01-29T04:38:58Z

on it now

dukenv0307 · 2026-01-29T08:45:43Z

@blazejkustra Can you check if it works on an Android native device? I didn't receive the message on the first device after sending it from the second device. It only appears when I open the chat

Screen.Recording.2026-01-29.at.15.40.09.mov

blazejkustra · 2026-01-29T09:06:43Z

@blazejkustra Can you check if it works on an Android native device? I didn't receive the message on the first device after sending it from the second device. It only appears when I open the chat

Screen.Recording.2026-01-29.at.15.40.09.mov

I tested on a physical device and it worked well, I'll try again today and let you know

melvin-bot · 2026-01-29T13:46:08Z

@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blazejkustra · 2026-01-29T13:54:34Z

@blazejkustra Can you check if it works on an Android native device? I didn't receive the message on the first device after sending it from the second device. It only appears when I open the chat

Screen.Recording.2026-01-29.at.15.40.09.mov

Weird, I'm not receiving new messages unless I click on the chat. Could you check if it works for you on main @dukenv0307?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 202ccd4645

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

dukenv0307 · 2026-01-29T14:46:42Z

@blazejkustra I tried to build the app on main branch but still couldn't receive the new message until I opened the chat

blazejkustra · 2026-01-29T14:58:05Z

Weird, I tested it two days ago and I was able to receive new messages. It must be a recent regression on main 😢

github-actions · 2026-01-29T17:23:29Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-29T17:52:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80624 Mobile-Expensify PR Expensify/Mobile-Expensify#13831.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6841851-748f075d0b0c7aca5562fe33bbd00b2ed70815e9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4725b2ed805a31156de75bdb8265b843f59aa259/index.html

Web 🕸️
https://80624.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2026-01-29T23:17:49Z

@dukenv0307 let us know in slack how the testing is going!

dukenv0307 · 2026-02-01T04:16:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

I couldn't verify it for now because I didn't receive the push notification

Android: mWeb Chrome

iOS: HybridApp

I couldn't verify it for now because I didn't receive the push notification

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-29.at.15.33.28.1.mov

dukenv0307

LGTM

dukenv0307 · 2026-02-01T04:16:49Z

@mountiny All yours!

roryabraham

only NAB comments, we can address in a follow-up if we want

roryabraham · 2026-02-02T17:40:00Z

+
+// Sound assets must be required at compile time
+const SOUND_ASSETS: Record<ValueOf<typeof SOUNDS>, AudioSource> = {
+    [SOUNDS.DONE]: require('@assets/sounds/done.mp3') as AudioSource,


NAB follow-up - should we lazy-load these assets?

roryabraham · 2026-02-02T17:43:35Z

+    [SOUNDS.RECEIVE]: require('@assets/sounds/receive.mp3') as AudioSource,
+};
+
+setAudioModeAsync({playsInSilentMode: false, shouldPlayInBackground: true});


NAB: we are calling this async function, but we don't await it finishing before calling playSound. I imagine this could potentially expose us to some race condition where we try and play a sound before these settings finish setting.

So maybe I'd capture the promise returned by this and await it in playSound. Or just call the sync version of this function, which I assume is available.

Also, should we create a wrapper to ensure it's only called once?

OSBotify · 2026-02-02T18:05:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-03T02:14:41Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.11-19 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

jponikarchuk · 2026-02-03T09:46:23Z

This PR failing because of the issue
This issue is reproducible in: iOS app

Julesssss · 2026-02-04T17:13:14Z

This PR failing because of the issue This issue is reproducible in: iOS app

^ Verified on prod, so I'll check this off

OSBotify · 2026-02-05T20:22:17Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Replace expo-av with expo-audio

d3bb56b

melvin-bot Bot assigned blazejkustra Jan 27, 2026

blazejkustra added 2 commits January 27, 2026 14:52

Update Podfile and configuration to replace expo-av with expo-audio

c86001f

Refactor sound handling: replace player instance with local variable …

775788d

…in playSound function

war-in approved these changes Jan 27, 2026

View reviewed changes

Update audio mode configuration

0db2d34

blazejkustra mentioned this pull request Jan 28, 2026

[Due for payment 2026-03-31] Upgrade RN to 0.83 #75120

Closed

Merge branch 'main' of github.com:Expensify/App into expo-av-to-audio

deabe8d

This comment has been minimized.

Sign in to view

roryabraham requested a review from dukenv0307 January 28, 2026 17:10

mountiny self-requested a review January 29, 2026 00:05

blazejkustra marked this pull request as ready for review January 29, 2026 13:45

blazejkustra requested review from a team as code owners January 29, 2026 13:45

melvin-bot Bot requested review from joekaufmanexpensify and roryabraham and removed request for a team January 29, 2026 13:46

Merge branch 'main' of github.com:Expensify/App into expo-av-to-audio

202ccd4

github-actions Bot reviewed Jan 29, 2026

View reviewed changes

Comment thread src/libs/Sound/index.native.ts

github-actions Bot reviewed Jan 29, 2026

View reviewed changes

Comment thread src/libs/Sound/index.native.ts

github-actions Bot reviewed Jan 29, 2026

View reviewed changes

Comment thread src/libs/Sound/index.native.ts

chatgpt-codex-connector Bot reviewed Jan 29, 2026

View reviewed changes

Comment thread src/libs/Sound/index.native.ts

Merge branch 'main' of github.com:Expensify/App into expo-av-to-audio

89dde7f

dukenv0307 approved these changes Feb 1, 2026

View reviewed changes

mountiny approved these changes Feb 2, 2026

View reviewed changes

roryabraham approved these changes Feb 2, 2026

View reviewed changes

roryabraham merged commit d1d0588 into Expensify:main Feb 2, 2026
40 checks passed

OSBotify mentioned this pull request Feb 3, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

jponikarchuk mentioned this pull request Feb 3, 2026

[Due for payment 2026-03-09] [$250] Notification - Sound still plays when 'Mute all sounds from Expensify' is toggled on #81282

Closed

7 tasks

blazejkustra mentioned this pull request Feb 12, 2026

[Due for payment 2026-02-25] [$250] Android/iOS app interrupts my music whenever I send a message #82174

Closed

7 tasks

Uh oh!

Conversation

blazejkustra commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jan 27, 2026

Uh oh!

codecov Bot commented Jan 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

war-in left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 28, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Jan 28, 2026

Uh oh!

dukenv0307 commented Jan 29, 2026

Uh oh!

dukenv0307 commented Jan 29, 2026

Uh oh!

blazejkustra commented Jan 29, 2026

Uh oh!

melvin-bot Bot commented Jan 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blazejkustra commented Jan 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

dukenv0307 commented Jan 29, 2026

Uh oh!

blazejkustra commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 29, 2026

Uh oh!

github-actions Bot commented Jan 29, 2026

Uh oh!

mountiny commented Jan 29, 2026

Uh oh!

dukenv0307 commented Feb 1, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Feb 1, 2026

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 2, 2026

Uh oh!

OSBotify commented Feb 3, 2026

blazejkustra commented Jan 27, 2026 •

edited

Loading

codecov Bot commented Jan 27, 2026 •

edited by github-actions Bot

Loading

blazejkustra commented Jan 29, 2026 •

edited

Loading