Fix: Show text cursor on non-pressable content in Workflows and Reports - #80587
Conversation
trjExpensify
left a comment
There was a problem hiding this comment.
Nice catch, such a weird one. 👍
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppHover feature not available Android: mWeb ChromeHover feature not available iOS: HybridAppHover feature not available iOS: mWeb SafariHover feature not available MacOS: Chrome / SafariCleanShot.2026-01-29.at.20.27.19.mp4 |
|
@nyomanjyotisa There is still a conflict that needs to be resolve |
|
Conflict resolved |
|
Damn, so sorry was ooo and could not merge before, you got conflicts again 😢 |
|
@iwiznia Conflict resolved! |
|
🚧 @iwiznia has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.3.13-1 🚀
|
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.3.15-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀
|
Explanation of Change
Conditionally set the
roleprop based on whether the content is pressable. When it's not pressable, userole="presentation"to get the text cursor. When it is pressable, userole="button"to get the pointer cursorFixed Issues
$ #79513
PROPOSAL: #79513 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.Chrome.mp4
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
iOS-mWeb.Safari.mp4
MacOS: Chrome / Safari
MacOS-Chrome.mp4