[CP Staging] Change report: Display create report option only to owner and policy admin by s77rt · Pull Request #80453 · Expensify/App

s77rt · 2026-01-25T15:24:24Z

Explanation of Change

Display create report option only to owner and policy admin

Fixed Issues

$ #80400
PROPOSAL:

Tests

Precondittion:

Create a workspace and invite a member and non-admin approver to the workspace.

[Member] Create an expense in workspace chat and submit it
[Non-admin approver] Open the expense report and click on Report
[Non-admin approver] Verify you do not see the Create report option

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-01-25T15:25:00Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2026-01-26T07:44:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-26.at.15.38.45.mov

Android: mWeb Chrome

Screen.Recording.2026-01-26.at.15.40.24.mov

iOS: HybridApp

Screen.Recording.2026-01-26.at.15.40.13.mov

iOS: mWeb Safari

Screen.Recording.2026-01-26.at.15.38.04.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-26.at.15.33.23.mov

DylanDylann · 2026-01-26T08:29:31Z

@s77rt The change looks good to me. The "Create report" option is now hidden, but non-admin approvers can still access the edit report page through the report field. I noticed that non-admin approvers also can not move an expense to another report. Should we disable that field in the non-admin approver as well to block access fully to the edit report page?

Screen.Recording.2026-01-26.at.15.26.12.mov

DylanDylann · 2026-01-26T08:41:59Z

This is the current view from 3 accounts: non-admin approver, admin, employee

Screen.Recording.2026-01-26.at.15.33.23.mov

s77rt · 2026-01-26T10:33:36Z

I noticed that non-admin approvers also can not move an expense to another report.

I think they can but probably only to reports that they can see/access

DylanDylann · 2026-01-26T10:40:15Z

I think they can but probably only to reports that they can see/access

I've tested many cases: report's employee, report's approver,... and couldn't see any outstanding reports in the list. But to make sure that we need to check the logic in the codebase

DylanDylann · 2026-01-26T10:42:52Z

Anyway, It doens't block this PR, we can move forward.

luacmartins

LGTM

roryabraham · 2026-01-26T16:55:54Z

        () => resolvedReportOwnerAccountID === currentUserPersonalDetails.accountID || isSelectedReportUnreported,
        [resolvedReportOwnerAccountID, currentUserPersonalDetails.accountID, isSelectedReportUnreported],
    );
+    const isAdmin = useMemo(() => isPolicyAdmin(reportPolicy), [reportPolicy]);


NAB: this component is compiled by React Compiler so manual memoization is unnecessary

[CP Staging] Change report: Display create report option only to owner and policy admin (cherry picked from commit 240faf6) (cherry-picked to staging by roryabraham)

OSBotify · 2026-01-26T17:00:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-26T17:43:07Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.8-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-26T21:57:45Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.8-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-26T22:28:58Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.9-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-27T19:48:17Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

display create report option only to owner and policy admin

97f6a99

melvin-bot Bot assigned s77rt Jan 25, 2026

s77rt marked this pull request as ready for review January 25, 2026 15:24

s77rt requested review from a team as code owners January 25, 2026 15:24

melvin-bot Bot requested review from DylanDylann and heyjennahay and removed request for a team January 25, 2026 15:24

s77rt mentioned this pull request Jan 25, 2026

[Due for payment 2026-02-03] Expense - Member's expense is moved to self workspace chat after moving it to new report #80400

Closed

7 tasks

s77rt added 2 commits January 25, 2026 17:21

Merge branch 'main' into create-report-restrict-to-admin

1ddd810

lint

d7c3f11

DylanDylann approved these changes Jan 26, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins January 26, 2026 08:42

luacmartins approved these changes Jan 26, 2026

View reviewed changes

luacmartins changed the title ~~Change report: Display create report option only to owner and policy admin~~ [CP Staging] Change report: Display create report option only to owner and policy admin Jan 26, 2026

luacmartins merged commit 240faf6 into Expensify:main Jan 26, 2026
30 checks passed

roryabraham reviewed Jan 26, 2026

View reviewed changes

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 26, 2026

OSBotify mentioned this pull request Jan 26, 2026

Deploy Checklist: New Expensify 2026-01-23 #80389

Closed

43 tasks

situchan mentioned this pull request Jan 26, 2026

[Due for payment 2026-02-03] Expense - Create report button shows wrong workspace, expense cannot be moved #80414

Closed

7 tasks

s77rt mentioned this pull request Jan 27, 2026

Expense - Non-admin approver can access Report list via link when the field is disabled #80492

Closed

7 tasks

Conversation

s77rt commented Jan 25, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 25, 2026

Uh oh!

DylanDylann commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Jan 26, 2026

Uh oh!

s77rt commented Jan 26, 2026

Uh oh!

DylanDylann commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Jan 26, 2026

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roryabraham Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DylanDylann commented Jan 26, 2026 •

edited

Loading

DylanDylann commented Jan 26, 2026 •

edited

Loading

DylanDylann commented Jan 26, 2026 •

edited

Loading