Can't send message on Android when Talkback is enabled - #80446
carlosmiceli merged 4 commits into
Conversation
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1104fc90d2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
trjExpensify
left a comment
There was a problem hiding this comment.
Part of the accessibility project 👍
|
@linhvovan29546 I can send the message if I swipe right from the emoji button once, but not twice, even though the send button is still focused (just smaller). Screen.Recording.2026-01-27.at.9.55.43.PM.mov |
|
I think on the second swipe right, it shouldn’t focus. Let me investigate this |
@QichenZhu I can't reproduce Screen.Recording.2026-01-27.at.16.38.42.mov |
|
I can still reproduce it on my end. I'll try again tomorrow and let you know. |
|
Unfortunately, I can still reproduce it today. Are we testing on the same branch? |
I can reproduce now. I've applied the fix |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-native.webmAndroid: mWeb Chromeandroid-web.webmiOS: HybridAppios-native.mp4iOS: mWeb Safariios-web.mp4MacOS: Chrome / Safarimac-web.mov |
|
Focus doesn't follow the order: + -> Composer -> Emoji -> Send on iOS. Same issue exists on nab.mp4 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.11-16 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|
Explanation of Change
When using
GestureDetectoror otherbuttontypes from react-native-gesture-handler, it is necessary to ensure that the children components areaccessible. Without this, the button can't be active onAndroidwhenTalkBackis enabled. This PR addresses the issue by settingaccessibilityproperties on the children, resolving the issue described below.Fixed Issues
$ #77460
PROPOSAL: #77460 (comment)
Tests
Precondition: User is logged in
Offline tests
Same as test above
QA Steps
Same as test above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-25.at.18.27.48.mov
Android: mWeb Chrome
Screen.Recording.2026-01-25.at.18.33.45.mov
iOS: Native
Screen.Recording.2026-01-25.at.18.38.07.mov
iOS: mWeb Safari
Screen.Recording.2026-01-25.at.18.39.32.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-25.at.18.43.33.mov