[No QA] Change report:newStatus export formula to report:displaystatus - #80402
Conversation
| @@ -130,7 +130,7 @@ Enter any of the following formulas into the Formula field for each column. Be s | |||
| | {report:policyName} | Same as the workspace name. Policy is an older term for workspace.| | |||
There was a problem hiding this comment.
Terminology violation: The explanation "Policy is an older term for workspace" is helpful, but consider using "workspace" terminology consistently throughout. This note acknowledges the legacy term appropriately.
| | Status | Is the current state of the report when it was exported.| | ||
| | {report:status} | Outputs the current report status using the historical labels (Open, Processing, Approved, Reimbursed or Closed).| | ||
| | {report:newStatus} | Outputs the current report status using the new labels (Draft, Outstanding, Approved, Paid, or Done). | | ||
| | {report:displaystatus} | Outputs the current report status using the new labels (Draft, Outstanding, Approved, Paid, or Done). | |
There was a problem hiding this comment.
AI Readiness issue: After the formula change to {report:displaystatus}, this line refers to "new labels" but doesn't clarify what makes them "new" compared to the historical labels. Consider rephrasing to: "Outputs the current report status using the updated labels (Draft, Outstanding, Approved, Paid, or Done)." This provides clearer context without requiring knowledge of what came before.
HelpDot Documentation ReviewOverall AssessmentThis PR corrects a technical documentation error in the Expensify Classic export formulas reference. The change updates an outdated formula field name from Scores Summary
Key Findings
Recommendations
Files Reviewed
This review confirms the documentation change is accurate, clear, and ready for publication. |
| @@ -130,7 +130,7 @@ Enter any of the following formulas into the Formula field for each column. Be s | |||
| | {report:policyName} | Same as the workspace name. Policy is an older term for workspace.| | |||
| | Status | Is the current state of the report when it was exported.| | |||
| | {report:status} | Outputs the current report status using the historical labels (Open, Processing, Approved, Reimbursed or Closed).| | |||
There was a problem hiding this comment.
Readability issue: The description "Outputs the current report status using the historical labels" could be clearer. Consider: "Outputs the report status using legacy labels (Open, Processing, Approved, Reimbursed or Closed)." This makes it clearer that these are older labels without using the vague term "historical."
report:newStatus export formula to report:displaystatusreport:newStatus export formula to report:displaystatus
|
A preview of your ExpensifyHelp changes have been deployed to https://b67e2ff2.helpdot.pages.dev ⚡️ Updated articles: |
|
I'll update this later today |
report:newStatus export formula to report:displaystatusreport:newStatus export formula to report:displaystatus
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@mollfpr @lydiabarclay One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
|
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.11-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|
Explanation of Change
Update the page https://help.expensify.com/articles/expensify-classic/spending-insights/Export-Expenses-And-Reports to use the correct formula to output the report status in the updated format "Draft", "Outstanding", etc.
newStatuswas changed todisplaystatusa while back already.Fixed Issues
None, I noticed the documentation was wrong while reviewing an unrelated PR.
Tests
Not tested
Offline tests
N/A
QA Steps
No QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari