Remove Onyx.connect() for the key: ONYXKEYS.NVP_RECENT_WAYPOINTS from trackExpense function

[Guccio163]

Explanation of Change

This PR is part of a refactor to remove Onyx.connect for the keys: ONYXKEYS.COLLECTION.NVP_RECENT_WAYPOINTS from the src/libs/actions/IOU/index.ts file and replace it with useOnyx.

It isolates the trackExpense function from the ONYXKEYS.COLLECTION.NVP_RECENT_WAYPOINTS Onyx.connect key .

Fixed Issues

$ #73024
PROPOSAL:

Tests

1. Open 'Track Expense'
2. Fill distance details
3. Choose selfDM chat
4. Submit the distance expense
5. Verify that the distance request was created successfully

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

trackExpenseCorrect.mov

[Guccio163]

@tgolen after this PR, there will be new issues needed for removing new Onyx.connect instances:

• src/libs/ReceiptUploadRetryHandler/handleFileRetry.ts
• src/libs/actions/IOU/MoneyRequest.ts
• src/libs/actions/IOU/Duplicate.ts

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/IOU/Duplicate.ts	86.62% <100.00%> (+0.08%)	⬆️
src/libs/actions/IOU/MoneyRequest.ts	98.64% <100.00%> (+0.01%)	⬆️
src/libs/actions/IOU/index.ts	69.49% <100.00%> (+0.37%)	⬆️
...es/iou/request/step/IOURequestStepConfirmation.tsx	56.18% <100.00%> (+0.08%)	⬆️
...rc/pages/iou/request/step/IOURequestStepAmount.tsx	3.66% <0.00%> (-0.04%)	⬇️
...ou/request/step/IOURequestStepDistanceOdometer.tsx	0.00% <0.00%> (ø)
src/pages/Share/SubmitDetailsPage.tsx	0.00% <0.00%> (ø)
... and 17 files with indirect coverage changes

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[tgolen]

@Guccio163 OK, thanks for giving me a heads up! I can get them created. Is it for the same key ONYXKEYS.NVP_RECENT_WAYPOINTS and would you like them assigned to you?

[Guccio163]

Yes, for the same key, because I just had to move Onyx.connect for this key to the files of functions that use trackExpense. You can assign them to me and if there will be too many I'll just get them reassigned later 👍

[tgolen]

OK, here you go!
#80268
#80269
#80270

[Guccio163]

Great, thank you!

[melvin-bot]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Guccio163]

Test steps and recording ready ✅

[parasharrajat]

Wrong test steps @Guccio163.... you are supposed to create a expense for SelfDm. while creating a expense select your chat as target.

[parasharrajat]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

26.01.2026_22.27.27_REC.mp4

🎀 👀 🎀 C+ reviewed

[Guccio163]

Thanks for noticing @parasharrajat, just updated 👍

[joekaufmanexpensify]

No product considerations, removing my review

[Guccio163]

Hi @tgolen , I'll get back to tests' requested changes, but about the getRecentWaypoints:

I fear that exporting this method is creating more work to cleanup in the future. It doesn't look like getRecentWaypoints is referenced at all in this module, so maybe it should just be moved to the module that uses it.

I believe that this 'getter' pattern that @parasharrajat was talking about here and which resulted in creating this function is beneficial when performing recursive migration like this one - this way we add recentWaypoints as a param to one function at a time - if usage above is a component then we pass param from useOnyx and if it is just another function, then we use this getter. This way we don't copy/paste Onyx.connect call every time (significantly bumping ESLint warnings count), but use single function that ties us back to Onyx.connect used in the original file. When all usages are removed (traced to useOnyx), we simply delete both original Onyx.connect and this getter at once.

It looks like this patter is pretty common, judging by other 'getter' functions used in IOU/index.ts such as getAllPersonalDetails, getAllTransactions etc..

I expect to see recentWaypoints getting passed as a parameter to createTransaction().

This is exactly what I'm going to do after we merge this PR, in IOU/MoneyRequest.ts issue

[tgolen]

OK, yeah. Thanks! That sounds fine if it's just temporary and part of your refactoring plan. Can you please add comments to the method to indicate it's only temporary and will be removed as part of <GH_LINK>?

[Guccio163]

Sure we can, I added a comment linking it to this issue - I didn't do it previously since all the other getter functions are left without comments, but we can leave one ourselves 👍 By the way @tgolen I added the changes you requested to IOUTest.ts, can you check if this was what you were looking for?

[tgolen]

Yes, that looks nice. Thank you!

[tgolen]

All yours @rlinoz

[rlinoz]

NAB: Should we update the name of this function so no one adds new calls being unaware that this is already deprecated?

We can do that in a follow up if it makes sense.

[Guccio163]

I think that we could, but as well as other getter functions in this file, ultimately we'll get rid if it - I think that it can take a while to remove it from here, so we can leave it as it is. The worst case scenario is someone will need it with their migration, so will use it too. If you strongly feel like we should label it with @deprecated, then I can add it, otherwise I would leave it without extra comments just like getter functions above 👍

[OSBotify]

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.11-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌