Fix: Report loads infinitely after deleting split and opening the empty report by cretadn22 · Pull Request #80216 · Expensify/App

cretadn22 · 2026-01-22T12:35:15Z

Explanation of Change

Fixed Issues

$ #75783
PROPOSAL: #75783 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Go to staging.new.expensify.com
Go to workspace chat
Create an expense
Open the expense report
Click More > Split
Click Save
Open any split
Click Report field > Create report
Go back to workspace chat
Right click on the report with one split > Delete
Delete the report
The report is deleted

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-02-08.at.14.53.29.mov

Android: mWeb Chrome

Screen.Recording.2026-02-08.at.13.20.34.mov

iOS: Native

Screen.Recording.2026-02-08.at.14.58.15.mov

iOS: mWeb Safari

Screen.Recording.2026-02-08.at.15.21.17.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-08.at.13.16.13.mov

… optimistic, success, and failure data accordingly.

melvin-bot · 2026-01-22T12:35:22Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-22T12:35:28Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-22T12:45:34Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/Split.ts	`68.58% <22.22%> (+7.90%)`	⬆️
... and 21 files with indirect coverage changes

blimpich · 2026-01-26T21:39:47Z

Can we add a unit test here?

… optimistic, success, and failure data accordingly.

…lt value is used when undefined

cretadn22 · 2026-01-27T12:16:58Z

@blimpich I added tests to cover the new changes

blimpich · 2026-01-27T17:08:44Z

Thank you!

blimpich · 2026-01-29T18:28:11Z

backend changes were merged, currently waiting on it to be deployed, but at the absolute latest this should be ready to test with backend changes by tomorrow

blimpich · 2026-01-30T20:21:20Z

Backend is deployed, lets move forward 👍. cc: @hoangzinh

hoangzinh · 2026-02-01T08:37:38Z

@cretadn22, It seems the PR title is incomplete. Could you please update it? Thank you!

hoangzinh · 2026-02-01T09:04:49Z

Bug: App displays infinite loading after deleting a split expense

Create an empty report
Create an expense
Split that expense
Create another manual expense
Go offline
Move 1 split expense to new report
Delete the last split expense in report in step (1)

Expected: App should only delete the split expense in step 6 and display manual expense in step 4

Actual: App deletes the above split expense and manual expense. Also it displays infinite loading

Screen.Recording.2026-02-01.at.16.00.51.mov

hoangzinh · 2026-02-01T15:59:12Z

@cretadn22 I found it's weird when I follow testing steps:

Go back to workspace chat

After step 9, I only see 1 money report of a split expense. Repeat step 10 and 11, it displays "Not here" page

Screen.Recording.2026-02-01.at.22.55.23.mov

hoangzinh · 2026-02-05T23:00:31Z

@cretadn22 I found another bug: report preview is still clickable after delete when offline. You can check behavior when delete a normal expense in offline.

Screen.Recording.2026-02-06.at.05.55.06.mov

hoangzinh · 2026-02-05T23:17:53Z

Hi @blimpich Just in case the message gets lost in the flood, I would like to hear your opinion on this: #80216 (comment)

blimpich · 2026-02-05T23:42:21Z

Responded 👍

cretadn22 · 2026-02-08T08:06:32Z

@hoangzinh I fixed this bug by adding pendingAction to report action

hoangzinh · 2026-02-10T10:08:30Z

@cretadn22 can you confirm again if this bug has been fixed? #80216 (comment)

Screen.Recording.2026-02-10.at.17.06.12.mov

cretadn22 · 2026-02-12T18:25:32Z

@hoangzinh Could you check again? I updated

hoangzinh · 2026-02-14T23:09:25Z

                errors: null,
            },
        });
+        const isLastTransactionInReport = Object.values(allTransactionsList ?? {}).filter((itemTransaction) => itemTransaction?.reportID === expenseReportID).length === 1;


Is it possible to reuse this selector

App/src/libs/ReportUtils.ts

Lines 1274 to 1280 in a93a316

function reportTransactionsSelector(transactions: OnyxCollection<Transaction>, reportID: string | undefined): Transaction[] {

if (!transactions || !reportID) {

return [];

}

return Object.values(transactions).filter((transaction): transaction is Transaction => !!transaction && transaction.reportID === reportID);

}

?

At the moment, the reportTransactionsSelector function isn’t used anywhere in the codebase. Since the logic is fairly simple, I’d suggest keeping the current implementation for now, especially in case this function ends up being removed soon.

hoangzinh · 2026-02-14T23:10:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-17.at.16.18.30.android.mov

Android: mWeb Chrome

Screen.Recording.2026-02-17.at.16.21.08.android.c.mov

iOS: HybridApp

Screen.Recording.2026-02-17.at.16.36.50.ios.mov

iOS: mWeb Safari

Screen.Recording.2026-02-17.at.16.38.37.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-17.at.16.10.30.web.mov

hoangzinh · 2026-02-15T00:02:13Z

@cretadn22 I still can reproduce this bug

Screen.Recording.2026-02-15.at.07.00.41.mov

cretadn22 · 2026-02-16T09:02:53Z

@hoangzinh From on my testing, the pointer is disabled when hovering over the deleted report.

Screen.Recording.2026-02-16.at.15.58.51.mp4

hoangzinh

LGTM

hoangzinh · 2026-02-17T09:43:33Z

@blimpich all yours

github-actions · 2026-02-17T17:31:27Z

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-17T17:35:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80216.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-84f95b2-37c0003-7b65f0ec853b18f5263979f408228f362d525ac3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-84f95b2-37c0003-a04123623cdba0674251c95ca141dd9e93b61678/index.html

Web 🕸️
https://80216.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-18T00:05:43Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.21-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-18T22:01:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Implement logic to handle split expenses in the same report, updating…

a1925d2

… optimistic, success, and failure data accordingly.

cretadn22 requested review from a team as code owners January 22, 2026 12:35

melvin-bot Bot assigned cretadn22 Jan 22, 2026

melvin-bot Bot requested review from heyjennahay and hoangzinh and removed request for a team January 22, 2026 12:35

melvin-bot Bot requested review from a team and blimpich and removed request for a team January 22, 2026 12:35

cretadn22 changed the title ~~Implement logic to handle split expenses in the same report, updating…~~ [Hold Backend] Implement logic to handle split expenses in the same report, updating… Jan 22, 2026

github-actions Bot reviewed Jan 22, 2026

View reviewed changes

Comment thread src/libs/actions/IOU/index.ts Outdated

cretadn22 added 4 commits January 27, 2026 18:24

Merge branch 'main' into fix/infinite-loading-empty-expense-report

ec320f6

Implement logic to handle split expenses in the same report, updating…

d6912a7

… optimistic, success, and failure data accordingly.

Add test for reverting split transactions across reports

1214b8d

Refactor reportID handling in split transaction tests to ensure defau…

61d4a33

…lt value is used when undefined

blimpich changed the title ~~[Hold Backend] Implement logic to handle split expenses in the same report, updating…~~ Implement logic to handle split expenses in the same report, updating… Jan 30, 2026

hoangzinh reviewed Feb 1, 2026

View reviewed changes

Comment thread tests/actions/IOUTest/SplitTest.ts

cretadn22 added 2 commits February 8, 2026 12:10

Merge branch 'main' into fix/infinite-loading-empty-expense-report

ce835a3

Add pending action to reportPreview

0609a35

cretadn22 added 3 commits February 11, 2026 23:04

Merge branch 'main' into fix/infinite-loading-empty-expense-report

4e713eb

Merge branch 'main' into fix/infinite-loading-empty-expense-report

ade4c80

simplize the condition

1fb8a2a

hoangzinh reviewed Feb 14, 2026

View reviewed changes

hoangzinh mentioned this pull request Feb 16, 2026

[$250] Expense - Report loads infinitely after deleting split and opening the empty report #75783

Closed

8 of 16 tasks

hoangzinh approved these changes Feb 17, 2026

View reviewed changes

blimpich approved these changes Feb 17, 2026

View reviewed changes

blimpich merged commit 84f95b2 into Expensify:main Feb 17, 2026
30 of 32 checks passed

OSBotify mentioned this pull request Feb 17, 2026

Deploy Checklist: New Expensify 2026-02-17 #82716

Closed

93 tasks done

mitarachim mentioned this pull request Feb 18, 2026

Expense- Potential duplicate error appears after deleting report with 1 split #82747

Closed

1 of 7 tasks

	function reportTransactionsSelector(transactions: OnyxCollection<Transaction>, reportID: string \| undefined): Transaction[] {
	if (!transactions \|\| !reportID) {
	return [];
	}

	return Object.values(transactions).filter((transaction): transaction is Transaction => !!transaction && transaction.reportID === reportID);
	}

Conversation

cretadn22 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 22, 2026

Uh oh!

melvin-bot Bot commented Jan 22, 2026

Uh oh!

Uh oh!

codecov Bot commented Jan 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blimpich commented Jan 26, 2026

Uh oh!

cretadn22 commented Jan 27, 2026

Uh oh!

blimpich commented Jan 27, 2026

Uh oh!

blimpich commented Jan 29, 2026

Uh oh!

blimpich commented Jan 30, 2026

Uh oh!

hoangzinh commented Feb 1, 2026

Uh oh!

Uh oh!

hoangzinh commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoangzinh commented Feb 1, 2026

Uh oh!

hoangzinh commented Feb 5, 2026

Uh oh!

hoangzinh commented Feb 5, 2026

Uh oh!

blimpich commented Feb 5, 2026

Uh oh!

cretadn22 commented Feb 8, 2026

Uh oh!

hoangzinh commented Feb 10, 2026

Uh oh!

cretadn22 commented Feb 12, 2026

Uh oh!

hoangzinh Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

cretadn22 Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Feb 15, 2026

Uh oh!

cretadn22 commented Feb 16, 2026

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Feb 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Feb 17, 2026

Uh oh!

github-actions Bot commented Feb 17, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

Reviewers

cretadn22 commented Jan 22, 2026 •

edited

Loading

codecov Bot commented Jan 22, 2026 •

edited by github-actions Bot

Loading

hoangzinh commented Feb 1, 2026 •

edited

Loading

hoangzinh commented Feb 14, 2026 •

edited

Loading