Skip to content

[CP Staging] Revert "78073: Update ghost text in Expense Threads / Reports" - #79856

Merged
MonilBhavsar merged 1 commit into
mainfrom
revert-78790-feature-78073
Jan 19, 2026
Merged

[CP Staging] Revert "78073: Update ghost text in Expense Threads / Reports"#79856
MonilBhavsar merged 1 commit into
mainfrom
revert-78790-feature-78073

Conversation

@MonilBhavsar

@MonilBhavsar MonilBhavsar commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

Reverts #78790

$ #79843
$ #79842

@MonilBhavsar
MonilBhavsar marked this pull request as ready for review January 19, 2026 05:31
@MonilBhavsar
MonilBhavsar requested review from a team as code owners January 19, 2026 05:31
@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team January 19, 2026 05:31
@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 6139f13d..424e8d27 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -7999,7 +7999,6 @@ Hier is een *testbon* om je te laten zien hoe het werkt:`,
             confirm: 'Afstandstracking negeren',
         },
         zeroDistanceTripModal: {title: 'Kan geen uitgave aanmaken', prompt: 'Je kunt geen uitgave aanmaken met dezelfde begin- en eindlocatie.'},
-
         locationRequiredModal: {
             title: 'Locatietoegang vereist',
             prompt: 'Sta locatietoegang toe in de instellingen van je apparaat om GPS-afstandsregistratie te starten.',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 3fb33efb..8aafe2a1 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -7974,7 +7974,6 @@ Oto *paragon testowy*, który pokazuje, jak to działa:`,
             confirm: 'Odrzuć śledzenie dystansu',
         },
         zeroDistanceTripModal: {title: 'Nie można utworzyć wydatku', prompt: 'Nie możesz utworzyć wydatku z tym samym miejscem początkowym i końcowym.'},
-
         locationRequiredModal: {
             title: 'Wymagany dostęp do lokalizacji',
             prompt: 'Aby rozpocząć śledzenie dystansu GPS, zezwól na dostęp do lokalizacji w ustawieniach swojego urządzenia.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 4b17be35..e0d32165 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -7984,7 +7984,6 @@ Aqui está um *recibo de teste* para mostrar como funciona:`,
             confirm: 'Descartar rastreamento de distância',
         },
         zeroDistanceTripModal: {title: 'Não é possível criar a despesa', prompt: 'Você não pode criar uma despesa com o mesmo local de partida e de chegada.'},
-
         locationRequiredModal: {
             title: 'Acesso à localização necessário',
             prompt: 'Permita o acesso à localização nas configurações do seu dispositivo para iniciar o rastreamento de distância por GPS.',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 5db7cd4b..26d74611 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7790,7 +7790,6 @@ ${reportName}
         stopGpsTrackingModal: {title: '停止 GPS 追踪', prompt: '你确定吗?这将结束你当前的旅程。', cancel: '恢复追踪', confirm: '停止 GPS 追踪'},
         discardDistanceTrackingModal: {title: '丢弃距离跟踪', prompt: '您确定吗?这将放弃您当前的流程,且无法撤销。', confirm: '丢弃距离跟踪'},
         zeroDistanceTripModal: {title: '无法创建报销', prompt: '你不能创建起点和终点相同的报销。'},
-
         locationRequiredModal: {title: '需要访问位置信息', prompt: '请在设备设置中允许位置访问以开始 GPS 距离跟踪。', allow: '允许'},
         androidBackgroundLocationRequiredModal: {title: '需要后台位置访问权限', prompt: '请在设备设置中允许应用使用“始终允许”位置访问权限,以开始 GPS 距离跟踪。'},
         preciseLocationRequiredModal: {title: '需要精确位置', prompt: '请在设备设置中启用“精确位置”以开始 GPS 距离跟踪。'},

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

@melvin-bot
melvin-bot Bot requested a review from youssef-lr January 19, 2026 05:31
@melvin-bot

melvin-bot Bot commented Jan 19, 2026

Copy link
Copy Markdown

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team January 19, 2026 05:31
@codecov

codecov Bot commented Jan 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...report/ReportActionCompose/ReportActionCompose.tsx 68.99% <ø> (+0.77%) ⬆️
... and 9 files with indirect coverage changes

@lakchote lakchote left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MonilBhavsar
MonilBhavsar merged commit c783c3b into main Jan 19, 2026
34 of 38 checks passed
@MonilBhavsar
MonilBhavsar deleted the revert-78790-feature-78073 branch January 19, 2026 06:03
@melvin-bot melvin-bot Bot added the Emergency label Jan 19, 2026
@melvin-bot

melvin-bot Bot commented Jan 19, 2026

Copy link
Copy Markdown

@MonilBhavsar looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@MonilBhavsar

Copy link
Copy Markdown
Contributor Author

Straight revert

@lakchote lakchote changed the title Revert "78073: Update ghost text in Expense Threads / Reports" [CP Staging] Revert "78073: Update ghost text in Expense Threads / Reports" Jan 19, 2026
OSBotify pushed a commit that referenced this pull request Jan 19, 2026
Revert "78073: Update ghost text in Expense Threads / Reports"

(cherry picked from commit c783c3b)

(cherry-picked to staging by lakchote)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 19, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.4-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.4-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.5-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants