Skip to content

feat: Add Expensify code feature in Subscription settings - #79829

Merged
nkuoch merged 24 commits into
Expensify:mainfrom
samranahm:79087/feat-discount-code
Feb 16, 2026
Merged

nkuoch merged 24 commits into
Expensify:mainfrom
samranahm:79087/feat-discount-code

Conversation

@samranahm

@samranahm samranahm commented Jan 18, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR adds support for applying Expensify codes to user subscriptions. Users can now enter and apply discount codes through a dedicated page from the subscription settings.

Fixed Issues

$ #79087
PROPOSAL: #79087 (comment)

Tests

Precondition: User has at least one workspace and is an admin of that workspace.

Test 01

  1. Open "Account" tab and choose "Subscription" to open "Subscription" page
  2. On "Your plan" card click "Subscription settings" option to open "Subscription settings" page
  3. Scroll to bottom and verify "Expensify code" option is available above the "Request tax exempt status" option
  4. Click "Expensify code" option to open "Expensify code" page
  5. Enter an "Expensify code" and click Apply and verify Apply button is loading until Backend confirm the code
  6. Once Backend response if code is Valid verify:
    • User navigate back to "Subscription settings" page
    • The code is available in menu item under "Expensify card" option in "Subscription settings" page
    • Right arrow is not available on "Expensify card" and user can't edit this field once code applied
  7. Navigate back to "Subscription" page and verify on "Your plan" card under "Subscription settings" option the "Expensify code: ... " is available next to "Subscription size: none"
  8. Verify "Expensify code: ... " in action button is only available when the actual code is applied instead of having "Expensify code: none" when no code is applied

Test 02

  1. Open "Subscription setting" page and choose "Expensify code" option to open "Expensify code" page
  2. Press "Apply" without entering a code and verify "This field is required" error appear
  3. Enter wrong code and press "Apply" button and verify "This code is invalid" error appear after Backend validation and user does not navigate back
  4. Change the App language and repeat the above steps and verify errors appear in selected language

Test 03
Precondition:

  • Expensify code is not applied
  • Open terminal and enter this code
Onyx.merge('nvp_private_subscription', {isSecretPromoCode: true})
  1. Open Subscription page
  2. Navigate to Subscription settings
  3. Verify "Expensify code" menu item in not available in Subscription settings page
  4. Open this url https://dev.new.expensify.com:8082/settings/subscription/details/expensify-code
  5. Verify "Not found page" displayed

Test 04
Precondition:

  • Open terminal and enter this code
Onyx.merge('nvp_private_subscription', {
    expensifyCode: " TEST123",
    isSecretPromoCode: true
})
  1. Verify Expensify code:TEST123 is not display in Subscription page > Your plan > Subscription settings menu item
  2. Open Subscription settings page and Verify "Expensify code" menu item in not available
  3. Open this url https://dev.new.expensify.com:8082/settings/subscription/details/expensify-code
  4. Verify "Not found page" displayed
  • Verify that no errors appear in the JS console

Offline tests

  1. Open "Subscription setting" page and chose "Expensify code" option to open "Expensify code" page
  2. Verify "Apply" button is disabled when user is offline

QA Steps

Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android.Native.mp4
Android: mWeb Chrome
Android.mWeb.Chrome.mp4
iOS: Native
IOS.Native.mp4
iOS: mWeb Safari
IOS.mWeb.Safari.mp4
MacOS: Chrome / Safari
macOS.Chrome.mp4

Copilot AI review requested due to automatic review settings January 18, 2026 09:57
@samranahm
samranahm requested review from a team as code owners January 18, 2026 09:57
@melvin-bot

melvin-bot Bot commented Jan 18, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@samranahm samranahm changed the title 79087/feat discount code feat: Add Expensify code feature in Subscription settings Jan 18, 2026
Comment thread src/pages/settings/Subscription/ExpensifyCodePage/index.tsx Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for applying Expensify discount codes to user subscriptions. Users can now navigate to subscription settings and enter discount codes through a dedicated page that validates the code through the backend and applies it to their subscription.

Changes:

  • Added new Expensify code field to subscription data model
  • Created new page for entering and applying discount codes with form validation
  • Integrated discount code display in subscription settings and plan summary
  • Added translations for all supported languages

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/types/onyx/PrivateSubscription.ts Added optional expensifyCode field to subscription type
src/types/form/SubscriptionExpensifyCodeForm.ts Created new form type for expensify code input
src/pages/settings/Subscription/ExpensifyCodePage/index.tsx New page component for entering and applying discount codes
src/libs/actions/Subscription.ts Added applyExpensifyCode action with optimistic/success/failure data handling
src/pages/settings/Subscription/SubscriptionSettings/index.tsx Added menu item to display and access expensify code feature
src/pages/settings/Subscription/SubscriptionPlan/SubscriptionPlanCardActionButton.tsx Updated summary to conditionally include expensify code
src/languages/*.ts Added translations for expensify code feature in all supported languages
src/SCREENS.ts, src/ROUTES.ts, src/ONYXKEYS.ts Added new screen, route, and form keys for expensify code
src/libs/Navigation/* Added navigation configuration for new expensify code page
src/libs/API/types.ts, src/libs/API/parameters/* Added API command and parameters for applying expensify code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/libs/actions/Subscription.ts
Comment thread src/pages/settings/Subscription/ExpensifyCodePage/index.tsx
Comment thread src/pages/settings/Subscription/ExpensifyCodePage/index.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b9f1d15ba

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/settings/Subscription/ExpensifyCodePage/index.tsx
@codecov

codecov Bot commented Jan 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/ROUTES.ts 12.77% <ø> (-0.10%) ⬇️
src/SCREENS.ts 100.00% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 75.00% <ø> (ø)
.../settings/Subscription/ExpensifyCodePage/index.tsx 100.00% <100.00%> (ø)
src/types/form/SubscriptionExpensifyCodeForm.ts 100.00% <100.00%> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx 7.64% <0.00%> (-0.02%) ⬇️
...scriptionPlan/SubscriptionPlanCardActionButton.tsx 0.00% <0.00%> (ø)
... and 3 more
... and 182 files with indirect coverage changes

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense from a product perspective 👍

@samranahm

Copy link
Copy Markdown
Contributor Author

Writing unit tests and implementing PERF fix suggestions. Will mark the PR ready for review shortly.

@samranahm

Copy link
Copy Markdown
Contributor Author

@eVoloshchak Please take a look when you get a moment.

@eVoloshchak

Copy link
Copy Markdown
Contributor

Looks good and tests well!

Important details: Expensify Codes have a Hide promo code from account settings? setting. When this setting exists for a code applied to an account, we should hide the entire Expensify Code section from the user view.

image

@samranahm, does BE return the flag and do we handle in on FE? Is there a way for QA to test this?

@samranahm

Copy link
Copy Markdown
Contributor Author

We are currently not handling this on the FE.
@nkuoch, could you please confirm whether the hidePromoCode flag already exists in BE and what it’s exactly called?

@nkuoch

nkuoch commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

cc @flodnv , but I think:

The flag is called isSecretPromoCode and it's stored as a field inside the private_promoDiscount NVP.

@flodnv

flodnv commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

That looks correct

@samranahm

Copy link
Copy Markdown
Contributor Author

Added isSecretPromoCode handling in FE. @eVoloshchak, please take a look.

@eVoloshchak

Copy link
Copy Markdown
Contributor

@samranahm, is not displaying this functionality on native devices a hard requirement? Feels weird that you can add a promo code using the webside on your smartphone, but cannot do the same using the native app on that same smartphone

@samranahm

Copy link
Copy Markdown
Contributor Author

@eVoloshchak We don’t allow users to make any changes to their subscription on native devices, not even subscription size. So, I believe we should keep the same behavior for this feature.

Here’s the current UI of the Subscription Settings page on native.

Screenshot 2026-02-16 at 6 39 34 PM

@eVoloshchak

eVoloshchak commented Feb 16, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

N/A

Android: mWeb Chrome
Screen.Recording.2026-02-16.at.15.10.17.mov
iOS: HybridApp

N/A

iOS: mWeb Safari
Screen.Recording.2026-02-16.at.14.22.06.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-16.at.14.18.11.mov

@eVoloshchak eVoloshchak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samranahm

Copy link
Copy Markdown
Contributor Author

@nkuoch All yours, please take a look.

@nkuoch
nkuoch merged commit e2df51a into Expensify:main Feb 16, 2026
31 of 32 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @nkuoch has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Feb 17, 2026
93 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/nkuoch in version: 9.3.21-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@IuliiaHerets

Copy link
Copy Markdown

Hi @samranahm.Which valid discount code can we use for Test 1?
cc @nkuoch @joekaufmanexpensify

image

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@eVoloshchak

Copy link
Copy Markdown
Contributor

Coming from #90007
We were hiding the complete menu section if it’s a secret promo, but we should hide the code (not the complete section) and show that the discount is applied in hintText

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants