Skip to content

[NoQA] Refactor: ReportNameUtils from translateLocal to translate from hook (part 1) #79645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmiceli merged 2 commits into from
Jan 18, 2026
Merged

[NoQA] Refactor: ReportNameUtils from translateLocal to translate from hook (part 1) #79645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59cf8ee
Refactor: ReportNameUtils from translateLocal to translate from hook …
shubham1206agra Jan 15, 2026
cc2433f
Prettier
shubham1206agra Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 61 additions & 89 deletions src/libs/ReportNameUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import {Str} from 'expensify-common';
import Onyx from 'react-native-onyx';
import type {OnyxCollection, OnyxEntry} from 'react-native-onyx';
import type {LocaleContextProps} from '@components/LocaleContextProvider';
import type {LocaleContextProps, LocalizedTranslate} from '@components/LocaleContextProvider';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import type {
Expand Down Expand Up @@ -120,14 +120,14 @@
let currentUserAccountID: number | undefined;
let allPersonalDetails: OnyxEntry<PersonalDetailsList>;

Onyx.connect({

Check warning on line 123 in src/libs/ReportNameUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.SESSION,
callback: (value) => {
currentUserAccountID = value?.accountID;
},
});

Onyx.connect({

Check warning on line 130 in src/libs/ReportNameUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.PERSONAL_DETAILS_LIST,
callback: (value) => {
allPersonalDetails = value;
Expand Down Expand Up @@ -353,7 +353,13 @@
return payerPaidAmountMessage;
}

function computeReportNameBasedOnReportAction(parentReportAction?: ReportAction, report?: Report, reportPolicy?: Policy, parentReport?: Report): string | undefined {
function computeReportNameBasedOnReportAction(
translate: LocalizedTranslate,
parentReportAction?: ReportAction,
report?: Report,
reportPolicy?: Policy,
parentReport?: Report,
): string | undefined {
if (!parentReportAction) {
return undefined;
}
Expand All @@ -364,32 +370,26 @@
) {
const harvesting = !isMarkAsClosedAction(parentReportAction) ? (getOriginalMessage(parentReportAction)?.harvesting ?? false) : false;
if (harvesting) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.automaticallySubmitted');
return translate('iou.automaticallySubmitted');
}
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.submitted', {memo: getOriginalMessage(parentReportAction)?.message});
return translate('iou.submitted', {memo: getOriginalMessage(parentReportAction)?.message});
}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.FORWARDED)) {
const {automaticAction} = getOriginalMessage(parentReportAction) ?? {};
if (automaticAction) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.automaticallyForwarded');
return translate('iou.automaticallyForwarded');
}
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.forwarded');
return translate('iou.forwarded');
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REJECTED) {
return getRejectedReportMessage();
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.RETRACTED) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.retracted');
return translate('iou.retracted');
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REOPENED) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.reopened');
return translate('iou.reopened');
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.CORPORATE_UPGRADE) {
return getUpgradeWorkspaceMessage();
Expand All @@ -398,66 +398,53 @@
return getDowngradeWorkspaceMessage();
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_CURRENCY) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getWorkspaceCurrencyUpdateMessage(translateLocal, parentReportAction);
return getWorkspaceCurrencyUpdateMessage(translate, parentReportAction);
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_FIELD) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getWorkspaceUpdateFieldMessage(translateLocal, parentReportAction);
return getWorkspaceUpdateFieldMessage(translate, parentReportAction);
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.MERGED_WITH_CASH_TRANSACTION) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('systemMessage.mergedWithCashTransaction');
return translate('systemMessage.mergedWithCashTransaction');
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_NAME) {
return Str.htmlDecode(getWorkspaceNameUpdatedMessage(parentReportAction));
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_AUTO_REPORTING_FREQUENCY) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getWorkspaceFrequencyUpdateMessage(translateLocal, parentReportAction);
return getWorkspaceFrequencyUpdateMessage(translate, parentReportAction);
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_REPORT_FIELD) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getWorkspaceReportFieldAddMessage(translateLocal, parentReportAction);
return getWorkspaceReportFieldAddMessage(translate, parentReportAction);
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_REPORT_FIELD) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getWorkspaceReportFieldUpdateMessage(translateLocal, parentReportAction);
return getWorkspaceReportFieldUpdateMessage(translate, parentReportAction);
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_REPORT_FIELD) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getWorkspaceReportFieldDeleteMessage(translateLocal, parentReportAction);
return getWorkspaceReportFieldDeleteMessage(translate, parentReportAction);
}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION)) {
return getUnreportedTransactionMessage(parentReportAction);
}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_MAX_EXPENSE_AMOUNT_NO_RECEIPT)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getPolicyChangeLogMaxExpenseAmountNoReceiptMessage(translateLocal, parentReportAction);
return getPolicyChangeLogMaxExpenseAmountNoReceiptMessage(translate, parentReportAction);
}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_DEFAULT_BILLABLE)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getPolicyChangeLogDefaultBillableMessage(translateLocal, parentReportAction);
return getPolicyChangeLogDefaultBillableMessage(translate, parentReportAction);
}
if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_DEFAULT_REIMBURSABLE)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getPolicyChangeLogDefaultReimbursableMessage(translateLocal, parentReportAction);
return getPolicyChangeLogDefaultReimbursableMessage(translate, parentReportAction);
}
if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_DEFAULT_TITLE_ENFORCED)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getPolicyChangeLogDefaultTitleEnforcedMessage(translateLocal, parentReportAction);
return getPolicyChangeLogDefaultTitleEnforcedMessage(translate, parentReportAction);
}
if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_DEFAULT_TITLE)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getPolicyChangeLogDefaultTitleMessage(translateLocal, parentReportAction);
return getPolicyChangeLogDefaultTitleMessage(translate, parentReportAction);
}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.ACTIONABLE_CARD_FRAUD_ALERT) && getOriginalMessage(parentReportAction)?.resolution) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getActionableCardFraudAlertResolutionMessage(translateLocal, parentReportAction);
return getActionableCardFraudAlertResolutionMessage(translate, parentReportAction);
}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.MARKED_REIMBURSED)) {
Expand Down Expand Up @@ -488,85 +475,75 @@

if (originalMessage?.type === CONST.IOU.REPORT_ACTION_TYPE.PAY) {
if (originalMessage.paymentType === CONST.IOU.PAYMENT_TYPE.ELSEWHERE) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.paidElsewhere');
return translate('iou.paidElsewhere');
}
if (originalMessage.paymentType === CONST.IOU.PAYMENT_TYPE.VBBA) {
if (originalMessage.automaticAction) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.automaticallyPaidWithBusinessBankAccount', undefined, last4Digits);
return translate('iou.automaticallyPaidWithBusinessBankAccount', undefined, last4Digits);
}
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.businessBankAccount', undefined, last4Digits);
return translate('iou.businessBankAccount', undefined, last4Digits);
}
if (originalMessage.paymentType === CONST.IOU.PAYMENT_TYPE.EXPENSIFY) {
if (originalMessage.automaticAction) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.automaticallyPaidWithExpensify');
return translate('iou.automaticallyPaidWithExpensify');
}
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.paidWithExpensify');
return translate('iou.paidWithExpensify');
}
}
}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.APPROVED)) {
const {automaticAction} = getOriginalMessage(parentReportAction) ?? {};
if (automaticAction) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.automaticallyApproved');
return translate('iou.automaticallyApproved');
}
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.approvedMessage');
return translate('iou.approvedMessage');
}

if (isUnapprovedAction(parentReportAction)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('iou.unapproved');
return translate('iou.unapproved');
}

if (isActionableJoinRequest(parentReportAction)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getJoinRequestMessage(translateLocal, parentReportAction);
return getJoinRequestMessage(translate, parentReportAction);
}

if (isTaskReport(report) && isCanceledTaskReport(report, parentReportAction)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('parentReportAction.deletedTask');
return translate('parentReportAction.deletedTask');
}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.INTEGRATION_SYNC_FAILED)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getIntegrationSyncFailedMessage(translateLocal, parentReportAction, report?.policyID);
return getIntegrationSyncFailedMessage(translate, parentReportAction, report?.policyID);
}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.COMPANY_CARD_CONNECTION_BROKEN)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getCompanyCardConnectionBrokenMessage(translateLocal, parentReportAction);
return getCompanyCardConnectionBrokenMessage(translate, parentReportAction);
}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.TRAVEL_UPDATE)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getTravelUpdateMessage(translateLocal, parentReportAction);
return getTravelUpdateMessage(translate, parentReportAction);
}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_CUSTOM_UNIT_RATE)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getWorkspaceCustomUnitRateAddedMessage(translateLocal, parentReportAction);
return getWorkspaceCustomUnitRateAddedMessage(translate, parentReportAction);
}
if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_CUSTOM_UNIT_RATE)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getWorkspaceCustomUnitRateUpdatedMessage(translateLocal, parentReportAction);
return getWorkspaceCustomUnitRateUpdatedMessage(translate, parentReportAction);
}
if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_CUSTOM_UNIT_RATE)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getWorkspaceCustomUnitRateDeletedMessage(translateLocal, parentReportAction);
return getWorkspaceCustomUnitRateDeletedMessage(translate, parentReportAction);
}

return undefined;
}

function computeChatThreadReportName(report: Report, reportNameValuePairs: ReportNameValuePairs, reports: OnyxCollection<Report>, parentReportAction?: ReportAction): string | undefined {
function computeChatThreadReportName(
translate: LocalizedTranslate,
report: Report,
reportNameValuePairs: ReportNameValuePairs,
reports: OnyxCollection<Report>,
parentReportAction?: ReportAction,
): string | undefined {
if (!isChatThread(report)) {
return undefined;
}
Expand All @@ -587,39 +564,33 @@
}

if (!isEmptyObject(parentReportAction) && isOldDotReportAction(parentReportAction)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getMessageOfOldDotReportAction(translateLocal, parentReportAction);
return getMessageOfOldDotReportAction(translate, parentReportAction);
}

if (isRenamedAction(parentReportAction)) {
const parent = reports?.[`${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID}`];
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getRenamedAction(translateLocal, parentReportAction, isExpenseReport(parent));
return getRenamedAction(translate, parentReportAction, isExpenseReport(parent));
}

if (parentReportActionMessage?.isDeletedParentAction) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('parentReportAction.deletedMessage');
return translate('parentReportAction.deletedMessage');
}

if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.RESOLVED_DUPLICATES) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('violations.resolvedDuplicates');
return translate('violations.resolvedDuplicates');
}

const isAttachment = isReportActionAttachment(!isEmptyObject(parentReportAction) ? parentReportAction : undefined);
const reportActionMessage = getReportActionText(parentReportAction).replaceAll(/(\n+|\r\n|\n|\r)/gm, ' ');
if (isAttachment && reportActionMessage) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return `[${translateLocal('common.attachment')}]`;
return `[${translate('common.attachment')}]`;
}
if (
parentReportActionMessage?.moderationDecision?.decision === CONST.MODERATION.MODERATOR_DECISION_PENDING_HIDE ||
parentReportActionMessage?.moderationDecision?.decision === CONST.MODERATION.MODERATOR_DECISION_HIDDEN ||
parentReportActionMessage?.moderationDecision?.decision === CONST.MODERATION.MODERATOR_DECISION_PENDING_REMOVE
) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return translateLocal('parentReportAction.hiddenMessage');
return translate('parentReportAction.hiddenMessage');
}
if (isAdminRoom(report) || isUserCreatedPolicyRoom(report)) {
return reportActionMessage;
Expand All @@ -645,8 +616,7 @@
return report?.reportName ?? '';
}
if (isCardIssuedAction(parentReportAction)) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
return getCardIssuedMessage({reportAction: parentReportAction, translate: translateLocal});
return getCardIssuedMessage({reportAction: parentReportAction, translate});
}
return reportActionMessage;
}
Expand All @@ -672,7 +642,8 @@
const parentReport = reports?.[`${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID}`];
const parentReportAction = isThread(report) ? reportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report?.parentReportID}`]?.[report.parentReportActionID] : undefined;

const parentReportActionBasedName = computeReportNameBasedOnReportAction(parentReportAction, report, reportPolicy, parentReport);
// eslint-disable-next-line @typescript-eslint/no-deprecated
Comment thread
shubham1206agra marked this conversation as resolved.
const parentReportActionBasedName = computeReportNameBasedOnReportAction(translateLocal, parentReportAction, report, reportPolicy, parentReport);

if (parentReportActionBasedName) {
return parentReportActionBasedName;
Expand All @@ -682,7 +653,8 @@
return Parser.htmlToText(report?.reportName ?? '').trim();
}

const chatThreadReportName = computeChatThreadReportName(report, reportNameValuePairs ?? {}, reports ?? {}, parentReportAction);
// eslint-disable-next-line @typescript-eslint/no-deprecated
Comment thread
shubham1206agra marked this conversation as resolved.
const chatThreadReportName = computeChatThreadReportName(translateLocal, report, reportNameValuePairs ?? {}, reports ?? {}, parentReportAction);
if (chatThreadReportName) {
return chatThreadReportName;
}
Expand Down
Loading