Skip to content

[no QA] fix type of PersonalDetails in search result #78892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JS00001 merged 4 commits into from
Jan 7, 2026
+8 −7
Merged

[no QA] fix type of PersonalDetails in search result #78892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ea29c2
fix type of PersonalDetails in search result
daledah Jan 6, 2026
543ed82
fix lint
daledah Jan 6, 2026
727f5f9
fix lint
daledah Jan 6, 2026
2389713
resolve conflict and type of personal details
daledah Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/libs/SearchUIUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,7 +1176,7 @@ function createReportActionsLookupMaps(data: OnyxTypes.SearchResults['data']): {
function getToFieldValueForTransaction(
transactionItem: OnyxTypes.Transaction,
report: OnyxTypes.Report | undefined,
personalDetailsList: OnyxTypes.PersonalDetailsList,
personalDetailsList: OnyxTypes.PersonalDetailsList | undefined,
reportAction: OnyxTypes.ReportAction | undefined,
): OnyxTypes.PersonalDetails {
const shouldShowBlankTo = !report || isOpenExpenseReport(report);
Expand Down Expand Up @@ -1229,7 +1229,7 @@ function getTransactionsSections(
const allViolations = getViolations(data);

// Use Map for faster lookups of personal details and reportActions
const personalDetailsMap = new Map(Object.entries(data.personalDetailsList || {}));
const personalDetailsMap = new Map(Object.entries(data.personalDetailsList ?? {}));
const {moneyRequestReportActionsByTransactionID, holdReportActionsByTransactionID} = createReportActionsLookupMaps(data);

const transactionsSections: TransactionListItemType[] = [];
Expand Down Expand Up @@ -1783,8 +1783,8 @@ function getReportSections(
allActions,
keyForList: String(reportItem.reportID),
groupedBy: CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT,
from: fromDetails,
to: toDetails,
from: (fromDetails ?? emptyPersonalDetails) as OnyxTypes.PersonalDetails,
to: (toDetails ?? emptyPersonalDetails) as OnyxTypes.PersonalDetails,
exported: lastExportedActionByReportID.get(reportItem.reportID)?.created ?? '',
formattedFrom,
formattedTo,
Expand Down Expand Up @@ -1855,10 +1855,10 @@ function getReportSections(
};
if (reportIDToTransactions[reportKey]?.transactions) {
reportIDToTransactions[reportKey].transactions.push(transaction);
reportIDToTransactions[reportKey].from = data.personalDetailsList[data?.[reportKey as ReportKey]?.ownerAccountID ?? CONST.DEFAULT_NUMBER_ID];
reportIDToTransactions[reportKey].from = data?.personalDetailsList?.[data?.[reportKey as ReportKey]?.ownerAccountID ?? CONST.DEFAULT_NUMBER_ID] ?? emptyPersonalDetails;
} else if (reportIDToTransactions[reportKey]) {
reportIDToTransactions[reportKey].transactions = [transaction];
reportIDToTransactions[reportKey].from = data.personalDetailsList[data?.[reportKey as ReportKey]?.ownerAccountID ?? CONST.DEFAULT_NUMBER_ID];
reportIDToTransactions[reportKey].from = data?.personalDetailsList?.[data?.[reportKey as ReportKey]?.ownerAccountID ?? CONST.DEFAULT_NUMBER_ID] ?? emptyPersonalDetails;
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/types/onyx/SearchResults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,9 @@ type SearchResults = {
search: SearchResultsInfo;

/** Search results data */
// eslint-disable-next-line @typescript-eslint/no-deprecated
data: PrefixedRecord<typeof ONYXKEYS.COLLECTION.TRANSACTION, Transaction> &
Record<typeof ONYXKEYS.PERSONAL_DETAILS_LIST, Record<string, PersonalDetails>> &
Record<typeof ONYXKEYS.PERSONAL_DETAILS_LIST, Record<string, PersonalDetails> | undefined> &
PrefixedRecord<typeof ONYXKEYS.COLLECTION.REPORT_ACTIONS, Record<string, ReportAction>> &
PrefixedRecord<typeof ONYXKEYS.COLLECTION.REPORT, Report> &
PrefixedRecord<typeof ONYXKEYS.COLLECTION.POLICY, Policy> &
Expand Down
Loading