[CP Staging] Don't show Merge when selecting IOU expense - #78538
Merged
Conversation
melvin-bot
Bot
requested review from
JmillsExpensify,
flaviadefaria,
heyjennahay,
joekaufmanexpensify,
thesahindia and
trjExpensify
and removed request for
a team
December 29, 2025 15:51
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
youssef-lr
requested review from
a team
and removed request for
JmillsExpensify,
flaviadefaria,
heyjennahay,
joekaufmanexpensify,
thesahindia and
trjExpensify
December 29, 2025 15:51
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Beamanator
previously approved these changes
Dec 29, 2025
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Beamanator
approved these changes
Dec 29, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
OSBotify
pushed a commit
that referenced
this pull request
Dec 29, 2025
[CP Staging] Don't show Merge when selecting IOU expense (cherry picked from commit 599c8ce) (cherry-picked to staging by roryabraham)
53 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.2.88-1 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.88-7 🚀
|
7 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.2.89-1 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.89-6 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Hides Merge option when selecting an IOU report.
Fixed Issues
$ #78530
Tests
Offline tests
Same as above.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-12-29.at.16.48.39.mov
MacOS: Desktop