[CP Staging] Fix not found page unreported expense for new account by mollfpr · Pull Request #78451 · Expensify/App

mollfpr · 2025-12-25T06:02:17Z

Explanation of Change

The selfDMReportID is returned by OpenApp, but the actual selfDM report data may be filtered out from the response when it has no actions yet (due to getHiddenReportsFilter logic in the backend). This causes a mismatch where:

ONYXKEYS.SELF_DM_REPORT_ID is set ✅
But allReports[selfDMReportID] is undefined ❌

When createTransactionThreadReport tries to build the transaction thread, it can't find the parent selfDM report and fails.

Fixed Issues

$ #77880
PROPOSAL:

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Create an unreported legacy transaction in the OldDot with the above step
Go to NewDot
Go to the Expenses page in the Reports > Expenses
Go offline
Click on the imported transaction

QA Steps

Precondition:

Create an account with the workspace

Creating an unreported legacy transaction:

Go to OldDot
Go to Settings > Account > Wallet
Click on Import card/bank
Select Discover and sign in with expensidemo account
Choose any card and toggle off the reimbursable option
Go to the Reports page
Remove the imported transaction from the report

Screen.Recording.Dec.19.2025.mp4

Test the unreported legacy transaction can be view in the NewDot:

Go to NewDot
Go to the Expenses page in the Reports > Expenses
Click on the imported transaction
Verify it's showing the transaction detail page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.Dec.25.2025.mp4

…itself can be filtered out and not available yet

melvin-bot · 2025-12-25T06:02:22Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-25T06:10:40Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`73.01% <100.00%> (+0.02%)`	⬆️
src/libs/actions/Report.ts	`54.71% <28.57%> (-0.15%)`	⬇️
... and 6 files with indirect coverage changes

situchan · 2025-12-25T06:13:05Z

    if (selfDMReportID) {
        reportToUse = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${selfDMReportID}`];
+
+        // selfDMReportID may be set but the report is filtered out.


The root cause of this is in backend?

Yes, the root cause is in the backend. The backend behavior is intentional; changing it might affect other processes. This fix handles the specific edge case where we need the selfDM to create a transaction thread.

yes, edge case. The bug is not reproducible anymore after selfDM is created in frontend.
To reproduce again, need to create another account.

To be fixed by https://github.com/Expensify/Auth/pull/18562

situchan · 2025-12-25T06:33:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Before:

Screen.Recording.2025-12-25.at.12.31.16.PM.mov

After:

Screen.Recording.2025-12-25.at.12.32.32.PM.mov

melvin-bot · 2025-12-25T06:35:33Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2025-12-25T06:48:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…nreported-expense [CP Staging] Fix not found page unreported expense for new account (cherry picked from commit 54c7eb4) (cherry-picked to staging by marcaaron)

OSBotify · 2025-12-25T21:43:22Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.2.87-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-29T12:12:03Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.87-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-29T12:31:38Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.2.88-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-30T14:58:52Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.88-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mollfpr added 3 commits December 25, 2025 12:51

add option to use existing selfDMReportID

eb6b14b

Set the optimistic selfDM report

36b3539

New account have the selfDMReportID in the Onyx but the selfDMReport …

deb37ee

…itself can be filtered out and not available yet

mollfpr self-assigned this Dec 25, 2025

mollfpr requested review from a team as code owners December 25, 2025 06:02

melvin-bot Bot requested a review from Ollyws December 25, 2025 06:02

melvin-bot Bot removed the request for review from a team December 25, 2025 06:02

mollfpr requested review from situchan and removed request for a team and Ollyws December 25, 2025 06:03

fix eslint and prettier

279a737

situchan reviewed Dec 25, 2025

View reviewed changes

situchan approved these changes Dec 25, 2025

View reviewed changes

melvin-bot Bot requested a review from MonilBhavsar December 25, 2025 06:35

MonilBhavsar approved these changes Dec 25, 2025

View reviewed changes

MonilBhavsar merged commit 54c7eb4 into main Dec 25, 2025
36 of 38 checks passed

MonilBhavsar deleted the mollfpr-fix-not-found-page-unreported-expense branch December 25, 2025 06:39

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 25, 2025

OSBotify mentioned this pull request Dec 25, 2025

Deploy Checklist: New Expensify 2025-12-24 #78431

Closed

62 tasks

mollfpr mentioned this pull request Dec 26, 2025

[Due for payment 2026-01-06] [CMB] Unreported expense showing $0.00 and then “Hmm, it’s not there” error when it's open #77880

Closed

Uh oh!

Conversation

mollfpr commented Dec 25, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 25, 2025

Uh oh!

codecov Bot commented Dec 25, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

situchan Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

mollfpr Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

situchan Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

situchan commented Dec 25, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 25, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 25, 2025

Uh oh!

OSBotify commented Dec 25, 2025

Uh oh!

OSBotify commented Dec 29, 2025

Uh oh!

OSBotify commented Dec 29, 2025

Uh oh!

OSBotify commented Dec 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Dec 25, 2025 •

edited by github-actions Bot

Loading