[CP Staging + Prod] fix: Workspaces page crashing when Domain data is incomplete by mhawryluk · Pull Request #78113 · Expensify/App

mhawryluk · 2025-12-19T10:52:00Z

Explanation of Change

Skips domains that don't have accountID or email when creating rows for the Domains section. (These properties should normally be there, but sometimes backend sends a wrong object, this is a quick fix for the crash, not an eventual target solution).

Fixed Issues

$ #78013
PROPOSAL: N/A

Tests

Go to Workspaces tab on an account that has some private domains.
Remove "email" or "accountID" from the domain's onyx data.
The domain row should disappear, and the page shouldn't crash.

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Nagranie.z.ekranu.2025-12-19.o.11.51.21.mov

melvin-bot · 2025-12-19T10:55:27Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-19T11:00:58Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/workspace/WorkspacesListPage.tsx	`76.62% <100.00%> (ø)`
... and 8 files with indirect coverage changes

ZhenjaHorbach · 2025-12-19T11:07:54Z


        return Object.values(allDomains).reduce<DomainItem[]>((domainItems, domain) => {
-            if (!domain) {
+            if (!domain || domain.accountID === undefined || !domain.email) {


I suppose domain.accountID as an empty line is also not a valid case
Or no?

accountID should be a number and I assume 0 is not valid, but can't be sure, so I allow it here

0 is not valid

I think we should use !domain.accountID like we do at other places in the code. CONST.DEFAULT_NUMBER_ID is 0. Using domain.accountID === undefined would let a 0 slip through, which isn’t a valid ID.

ok, thanks. changed domain.accountID === undefined to !domain.accountID

ShridharGoel · 2025-12-19T11:15:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-12-19.at.4.42.14.PM.mov

mountiny

Thank you!

…rash-when-incomplete-domain [CP Staging + Prod] fix: Workspaces page crashing when Domain data is incomplete (cherry picked from commit bd763a9) (cherry-picked to staging by mountiny)

OSBotify · 2025-12-19T11:49:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…rash-when-incomplete-domain [CP Staging + Prod] fix: Workspaces page crashing when Domain data is incomplete (cherry picked from commit bd763a9) (cherry-picked to production by mountiny)

OSBotify · 2025-12-19T12:22:01Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.82-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-19T12:37:29Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.83-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-19T13:20:48Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.84-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-19T23:41:56Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-20T00:00:56Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.85-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-23T00:34:09Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Workspaces page crashing when Domain data is incomplete

f8d7740

melvin-bot Bot assigned mhawryluk Dec 19, 2025

mhawryluk marked this pull request as ready for review December 19, 2025 10:55

mhawryluk requested review from a team as code owners December 19, 2025 10:55

melvin-bot Bot requested review from ShridharGoel and removed request for a team December 19, 2025 10:55

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team December 19, 2025 10:55

mountiny changed the title ~~fix: Workspaces page crashing when Domain data is incomplete~~ [CP STaging] fix: Workspaces page crashing when Domain data is incomplete Dec 19, 2025

ZhenjaHorbach reviewed Dec 19, 2025

View reviewed changes

mountiny changed the title ~~[CP STaging] fix: Workspaces page crashing when Domain data is incomplete~~ [CP Staging] fix: Workspaces page crashing when Domain data is incomplete Dec 19, 2025

Review fix

e7338b9

ZhenjaHorbach approved these changes Dec 19, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny December 19, 2025 11:26

mountiny changed the title ~~[CP Staging] fix: Workspaces page crashing when Domain data is incomplete~~ [CP Staging + Prod] fix: Workspaces page crashing when Domain data is incomplete Dec 19, 2025

mountiny approved these changes Dec 19, 2025

View reviewed changes

ShridharGoel approved these changes Dec 19, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny December 19, 2025 11:28

mountiny approved these changes Dec 19, 2025

View reviewed changes

mountiny merged commit bd763a9 into Expensify:main Dec 19, 2025
34 of 36 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 19, 2025

mountiny mentioned this pull request Dec 19, 2025

Fix domain crash #78075

Closed

53 tasks

OSBotify mentioned this pull request Dec 19, 2025

Deploy Checklist: New Expensify 2025-12-18 #78018

Closed

OSBotify added the CP Production label Dec 19, 2025

melvin-bot Bot mentioned this pull request Dec 19, 2025

[Due for payment 2025-12-30] [Due for payment 2025-12-26] [$250] Workspace - App crashes after deleting workspace #78013

Closed

7 tasks

Uh oh!

Conversation

mhawryluk commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 19, 2025

Uh oh!

codecov Bot commented Dec 19, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ZhenjaHorbach Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

mhawryluk Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

mhawryluk Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 20, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mhawryluk commented Dec 19, 2025 •

edited

Loading

codecov Bot commented Dec 19, 2025 •

edited by github-actions Bot

Loading

ShridharGoel commented Dec 19, 2025 •

edited

Loading