Skip to content

fix Money Requests - Location permission denied leaves Setting button infinite loading #77977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarioExpensify merged 3 commits into from
Dec 26, 2025
Merged

fix Money Requests - Location permission denied leaves Setting button infinite loading #77977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d405ca
fix Money Requests - Location permission denied leaves Setting button…
apeyada Dec 18, 2025
9a779ce
fix android
apeyada Dec 18, 2025
6c09f09
Merge branch 'main' of https://github.com/apeyada/Expensify into fix-…
apeyada Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/LocationPermissionModal/index.android.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ function LocationPermissionModal({startPermissionFlow, resetPermissionFlow, onDe
}, [startPermissionFlow]);

const handledBlockedPermission = (cb: () => void) => () => {
setIsLoading(true);
if (hasError && Linking.openSettings) {
Linking.openSettings();
setShowModal(false);
setHasError(false);
resetPermissionFlow();
return;
}
setIsLoading(true);
cb();
};

Expand Down
3 changes: 2 additions & 1 deletion src/components/LocationPermissionModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ function LocationPermissionModal({startPermissionFlow, resetPermissionFlow, onDe
const checkPermission = useCallback(() => {
getLocationPermission().then((status) => {
if (status !== RESULTS.GRANTED && status !== RESULTS.LIMITED) {
setHasError(status === RESULTS.BLOCKED);
return;
}
onGrant();
Expand Down Expand Up @@ -73,7 +74,6 @@ function LocationPermissionModal({startPermissionFlow, resetPermissionFlow, onDe
}, [startPermissionFlow]);

const handledBlockedPermission = (cb: () => void) => () => {
setIsLoading(true);
if (hasError) {
if (Linking.openSettings) {
Linking.openSettings();
Expand All @@ -90,6 +90,7 @@ function LocationPermissionModal({startPermissionFlow, resetPermissionFlow, onDe
setShowModal(false);
return;
}
setIsLoading(true);
cb();
};

Expand Down
Loading