Fix migrated unreported expense showing not found page by mollfpr · Pull Request #77889 · Expensify/App

mollfpr · 2025-12-17T14:41:25Z

Explanation of Change

When creating the optimistic IOU action and transaction thread for an unreported transaction, we check if it's a track expense to get the selfDM report. This is a failure for legacy/historical unreported expense because to check the track expense, we are using the transaction reportAction which has not been created yet.

Fixed Issues

$ #77880
PROPOSAL:

Tests

Precondition:

Create an account with the workspace

Creating an unreported legacy transaction:

Go to OldDot
Go to Settings > Account > Wallet
Click on Import card/bank
Select Discover and sign in with expensidemo account
Choose any card and toggle off the reimbursable option
Go to the Reports page
Remove the imported transaction from the report

Screen.Recording.Dec.19.2025.mp4

Test the unreported legacy transaction can be view in the NewDot:

Go to NewDot
Go to the Expenses page in the Reports > Expenses
Click on the imported transaction
Verify it's showing the transaction detail page

Verify that no errors appear in the JS console

Offline tests

Create an unreported legacy transaction in the OldDot with the above step
Go to NewDot
Go to the Expenses page in the Reports > Expenses
Go offline
Click on the imported transaction

QA Steps

Precondition:

Create an account with the workspace

Creating an unreported legacy transaction:

Go to OldDot
Go to Settings > Account > Wallet
Click on Import card/bank
Select Discover and sign in with expensidemo account
Choose any card and toggle off the reimbursable option
Go to the Reports page
Remove the imported transaction from the report

Screen.Recording.Dec.19.2025.mp4

Test the unreported legacy transaction can be view in the NewDot:

Go to NewDot
Go to the Expenses page in the Reports > Expenses
Click on the imported transaction
Verify it's showing the transaction detail page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.Dec.17.2025.mp4

…ed transaction

melvin-bot · 2025-12-17T14:50:17Z

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-17T14:50:26Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/SearchUIUtils.ts	`61.59% <100.00%> (ø)`
src/libs/actions/Report.ts	`54.19% <50.00%> (+0.02%)`	⬆️
... and 8 files with indirect coverage changes

github-actions · 2025-12-17T14:52:48Z

🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-17T15:27:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #77889.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/77889/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/77889/NewExpensify.dmg	https://77889.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

situchan · 2025-12-18T10:12:38Z

-    // For track expenses without iouReport, get the selfDM report
-    if (isTrackExpense && selfDMReportID) {
+    // For track expenses or unreported transactions, get the selfDM report
+    if (selfDMReportID) {


For track expenses or

The comment doesn't match condition

situchan · 2025-12-18T10:29:32Z

I am not able to reproduce linked issue (When the user clicks on the expense, it shows a not found page). Tested against main. (I don't have self DM)
Do you have detailed repro step?

Screen.Recording.2025-12-18.at.4.34.32.PM.mov

…ated-unreported-expense

mollfpr · 2025-12-19T07:56:51Z

@situchan You need to have very old expense that doesn't have an IOU action. We already test the adhoc and supportal to the customer account here https://expensify.slack.com/archives/C07NMDKEFMH/p1765986698585519?thread_ts=1765913637.237579&cid=C07NMDKEFMH.

mollfpr · 2025-12-19T08:21:02Z

@situchan I have updated the test step, you need to create the unreported legacy transaction first then view the transaction in the NewDot.

Screen.Recording.Dec.19.2025.mp4

situchan · 2025-12-19T14:41:12Z

Thanks. So Remove the imported transaction from the report is the key to reproduce

situchan · 2025-12-23T12:37:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-23.at.7.29.41.PM.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Before:

Screen.Recording.2025-12-23.at.6.33.40.PM.mov

After:

Screen.Recording.2025-12-23.at.6.36.38.PM.mov

Offline:

Screen.Recording.2025-12-23.at.6.46.23.PM.mov

melvin-bot · 2025-12-23T13:31:28Z

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

robertjchen · 2025-12-24T02:29:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2025-12-24T02:39:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-24T19:10:22Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.2.87-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

kavimuru · 2025-12-25T02:42:57Z

@mollfpr failing with original bug #77880

https://platform.applause.com/services/links/v1/external/b2fa48d4c58f063e63b677d475d72f6fd1cb21f82d3a4416e9cee7dc1095c774
https://platform.applause.com/services/links/v1/external/153f1a8558257e3b25cddd289e4c75ab6547f62d885da87be926eb73e2da3a00
https://platform.applause.com/services/links/v1/external/4296df383ab8d2c3a8b73b2f93b9cc96f4b23807c5e9e699d8c79877ccb6911c

situchan · 2025-12-25T02:47:59Z

I have ever noticed this while testing. But not reproduced anymore.

mollfpr · 2025-12-25T02:55:15Z

@kavimuru Is the account has the selfDM report in NewDot?

izarutskaya · 2025-12-26T20:13:43Z

After sending a message in the self DM chat, the PR passes.

1766775113108.77889-Web.mp4

1766775113108.77889-A16.mp4

1766775113107.77889-iOS.mp4

situchan · 2025-12-26T20:16:18Z

@izarutskaya please also test without sending a message in the self DM chat on latest staging 9.2.87-4

izarutskaya · 2025-12-26T20:48:59Z

The PR passes without sending a message
Build v9.2.87-4
The same as the previous tests.

77889-Web_2.1.mp4

OSBotify · 2025-12-29T12:11:06Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.87-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mollfpr added 2 commits December 17, 2025 19:51

fix the optimistic IOU action and transaction thread for the unreport…

4a4a404

…ed transaction

fix the optimistic IOU action not available for unreported transaction

0713daa

mollfpr self-assigned this Dec 17, 2025

mollfpr marked this pull request as ready for review December 17, 2025 14:49

mollfpr requested review from a team as code owners December 17, 2025 14:49

melvin-bot Bot requested review from heyjennahay and inimaga and removed request for a team December 17, 2025 14:49

mollfpr requested a review from mountiny December 17, 2025 14:52

mollfpr requested a review from situchan December 17, 2025 15:13

situchan reviewed Dec 18, 2025

View reviewed changes

mollfpr added 2 commits December 19, 2025 11:10

Merge branch 'main' of github.com:Expensify/App into mollfpr-fix-migr…

3ba772f

…ated-unreported-expense

remove comment

39a8072

situchan approved these changes Dec 23, 2025

View reviewed changes

melvin-bot Bot requested a review from madmax330 December 23, 2025 13:31

robertjchen approved these changes Dec 24, 2025

View reviewed changes

robertjchen merged commit 2dcf2fc into main Dec 24, 2025
35 checks passed

robertjchen deleted the mollfpr-fix-migrated-unreported-expense branch December 24, 2025 02:30

OSBotify mentioned this pull request Dec 24, 2025

Deploy Checklist: New Expensify 2025-12-24 #78431

Closed

62 tasks

kavimuru mentioned this pull request Dec 25, 2025

[Due for payment 2026-01-06] [CMB] Unreported expense showing $0.00 and then “Hmm, it’s not there” error when it's open #77880

Closed

Uh oh!

Conversation

mollfpr commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 17, 2025

Uh oh!

codecov Bot commented Dec 17, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Dec 17, 2025

Uh oh!

github-actions Bot commented Dec 17, 2025

Uh oh!

situchan Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

situchan commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mollfpr commented Dec 19, 2025

Uh oh!

mollfpr commented Dec 19, 2025

Uh oh!

situchan commented Dec 19, 2025

Uh oh!

situchan commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 23, 2025

Uh oh!

robertjchen commented Dec 24, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

kavimuru commented Dec 25, 2025

Uh oh!

situchan commented Dec 25, 2025

Uh oh!

mollfpr commented Dec 25, 2025

Uh oh!

izarutskaya commented Dec 26, 2025

Uh oh!

situchan commented Dec 26, 2025

Uh oh!

izarutskaya commented Dec 26, 2025

Uh oh!

OSBotify commented Dec 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mollfpr commented Dec 17, 2025 •

edited

Loading

codecov Bot commented Dec 17, 2025 •

edited by github-actions Bot

Loading

situchan commented Dec 18, 2025 •

edited

Loading

situchan commented Dec 23, 2025 •

edited

Loading